From: Michael Ellerman <mpe@ellerman•id.au>
To: Daniel Axtens <dja@axtens•net>, linuxppc-dev@ozlabs•org
Cc: mikey@neuling•org, imunsie@au•ibm.com,
Ryan Grimm <grimm@linux•vnet.ibm.com>,
Daniel Axtens <dja@axtens•net>
Subject: Re: cxl: Remove racy attempt to force EEH invocation in reset
Date: Fri, 28 Aug 2015 07:58:33 +1000 (AEST) [thread overview]
Message-ID: <20150827215833.2F0331401AF@ozlabs.org> (raw)
In-Reply-To: <1440141915-27716-1-git-send-email-dja@axtens.net>
On Fri, 2015-21-08 at 07:25:15 UTC, Daniel Axtens wrote:
> cxl_reset currently PERSTs the slot, and then repeatedly tries to
> read MMIO space in order to kick off EEH.
>
> There are 2 problems with this: it's unnecessary, and it's racy.
>
> It's unnecessary because the PERST will bring down the PHB link.
> That will be picked up by the CAPP, which will send out an HMI.
> Skiboot, noticing an HMI from the CAPP, will send an OPAL
> notification to the kernel, which will trigger EEH recovery.
>
> It's also racy: the EEH recovery triggered by the CAPP will
> eventually cause the MMIO space to have its mapping invalidated
> and the pointer NULLed out. This races with our attempt to read
> the MMIO space. This is causing OOPSes in testing.
>
> Simply drop all the attempts to force EEH detection, and trust
> that Skiboot will send the notification and that we'll act on it.
> The Skiboot code to send the EEH notification has been in Skiboot
> for as long as CAPP recovery has been supported, so we don't need
> to worry about breaking obscure setups with ancient firmware.
>
> Cc: Ryan Grimm <grimm@linux•vnet.ibm.com>
> Cc: stable@vger•kernel.org
> Fixes: 62fa19d4b4fd ("cxl: Add ability to reset the card")
> Signed-off-by: Daniel Axtens <dja@axtens•net>
> Acked-by: Ian Munsie <imunsie@au1•ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/9d8e27673c45927fee9e7d89
cheers
prev parent reply other threads:[~2015-08-27 21:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 7:25 [PATCH] cxl: Remove racy attempt to force EEH invocation in reset Daniel Axtens
2015-08-21 8:06 ` Ian Munsie
2015-08-27 21:58 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150827215833.2F0331401AF@ozlabs.org \
--to=mpe@ellerman$(echo .)id.au \
--cc=dja@axtens$(echo .)net \
--cc=grimm@linux$(echo .)vnet.ibm.com \
--cc=imunsie@au$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mikey@neuling$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox