Subject: Re: [v2 04/11] soc/fsl: Introduce drivers for the DPAA QMan

From: Scott Wood <[email-masked]>
Date: Fri, 11 Sep 2015 20:10:05 -0500

On Wed, Aug 12, 2015 at 04:14:50PM -0400, Roy Pledge wrote:
> +/* Lock/unlock frame queues, subject to the "LOCKED" flag. This is about
> + * inter-processor locking only. Note, FQLOCK() is always called either under a
> + * local_irq_save() or from interrupt context - hence there's no need for irq
> + * protection (and indeed, attempting to nest irq-protection doesn't work, as
> + * the "irq en/disable" machinery isn't recursive...). */
> +#define FQLOCK(fq) \
> +	do { \
> +		struct qman_fq *__fq478 = (fq); \
> +		if (fq_isset(__fq478, QMAN_FQ_FLAG_LOCKED)) \
> +			spin_lock(&__fq478->fqlock); \
> +	} while (0)
> +#define FQUNLOCK(fq) \
> +	do { \
> +		struct qman_fq *__fq478 = (fq); \
> +		if (fq_isset(__fq478, QMAN_FQ_FLAG_LOCKED)) \
> +			spin_unlock(&__fq478->fqlock); \
> +	} while (0)
> +

I don't see QMAN_FQ_FLAG_LOCKED set anywhere.  What is the use case?

-Scott