From: Nicolin Chen <nicoleotsuka@gmail•com>
To: Rob Herring <robh@kernel•org>
Cc: Shengjiu Wang <shengjiu.wang@freescale•com>,
pawel.moll@arm•com, mark.rutland@arm•com,
ijc+devicetree@hellion•org.uk, galak@codeaurora•org,
timur@tabi•org, Xiubo.Lee@gmail•com, lgirdwood@gmail•com,
broonie@kernel•org, perex@perex•cz, tiwai@suse•com,
shawnguo@kernel•org, alsa-devel@alsa-project•org,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
devicetree@vger•kernel.org
Subject: Re: [PATCH V2 3/3] ASoC: fsl_asrc: spba clock is needed by asrc device
Date: Fri, 20 Nov 2015 14:00:16 -0800 [thread overview]
Message-ID: <20151120220015.GA10156@Asurada> (raw)
In-Reply-To: <20151120142946.GA6949@rob-hp-laptop>
On Fri, Nov 20, 2015 at 08:29:46AM -0600, Rob Herring wrote:
> On Fri, Nov 20, 2015 at 02:17:53PM +0800, Shengjiu Wang wrote:
> > ASRC need to enable the spba clock, when sdma is using share peripheral
> > script. In this case, there is two spba master port is used, if don't
> > enable the clock, the spba bus will have arbitration issue, which may
> > cause read/write wrong data from/to ASRC registers
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@freescale•com>
> > ---
> > Documentation/devicetree/bindings/sound/fsl,asrc.txt | 2 ++
> > sound/soc/fsl/fsl_asrc.c | 10 ++++++++++
> > sound/soc/fsl/fsl_asrc.h | 1 +
> > 3 files changed, 13 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> > index b93362a..d8eeee3 100644
> > --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> > +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> > @@ -25,6 +25,8 @@ Required properties:
> > "mem" Peripheral access clock to access registers.
> > "ipg" Peripheral clock to driver module.
> > "asrck_<0-f>" Clock sources for input and output clock.
> > + "spba" The spba clock is needed when two spba master port
> > + is used.
>
> I'm assuming the same comments on patch 1 apply to all 3.
Yes. I should have mentioned that.
Nicolin
prev parent reply other threads:[~2015-11-20 22:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 6:17 [PATCH V2 0/3] add spba clock for fsl audio IP Shengjiu Wang
2015-11-20 6:17 ` [PATCH V2 1/3] ASoC: fsl_esai: spba clock is needed by esai device Shengjiu Wang
2015-11-20 7:39 ` Nicolin Chen
2015-11-20 6:17 ` [PATCH V2 2/3] ASoC: fsl_spdif: spba clk is needed by spdif device Shengjiu Wang
2015-11-20 6:17 ` [PATCH V2 3/3] ASoC: fsl_asrc: spba clock is needed by asrc device Shengjiu Wang
2015-11-20 14:29 ` Rob Herring
2015-11-20 22:00 ` Nicolin Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151120220015.GA10156@Asurada \
--to=nicoleotsuka@gmail$(echo .)com \
--cc=Xiubo.Lee@gmail$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=galak@codeaurora$(echo .)org \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=pawel.moll@arm$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=robh@kernel$(echo .)org \
--cc=shawnguo@kernel$(echo .)org \
--cc=shengjiu.wang@freescale$(echo .)com \
--cc=timur@tabi$(echo .)org \
--cc=tiwai@suse$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox