From: Bjorn Helgaas <helgaas@kernel•org>
To: Ganapatrao Kulkarni <gkulkarni@caviumnetworks•com>
Cc: linux-arm-kernel@lists•infradead.org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-pci@vger•kernel.org,
linux-ia64@vger•kernel.org, linux-metag@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, linux-s390@vger•kernel.org,
linux-sh@vger•kernel.org, linux-arch@vger•kernel.org,
Will.Deacon@arm•com, catalin.marinas@arm•com,
grant.likely@linaro•org, leif.lindholm@linaro•org,
rfranz@cavium•com, ard.biesheuvel@linaro•org, msalter@redhat•com,
robh+dt@kernel•org, steve.capper@linaro•org,
hanjun.guo@linaro•org, al.stone@linaro•org, arnd@arndb•de,
pawel.moll@arm•com, mark.rutland@arm•com,
ijc+devicetree@hellion•org.uk, galak@codeaurora•org,
rjw@rjwysocki•net, lenb@kernel•org, marc.zyngier@arm•com,
lorenzo.pieralisi@arm•com, bhelgaas@google•com,
tony.luck@intel•com, fenghua.yu@intel•com,
james.hogan@imgtec•com, benh@kernel•crashing.org,
tglx@linutronix•de, mingo@redhat•com, hpa@zytor•com,
x86@kernel•org, jonathan@jonmasters•org, rrichter@cavium•com,
Prasun.Kapoor@caviumnetworks•com, gpkulkarni@gmail•com
Subject: Re: [PATCH v9 1/6] arm64, numa: adding numa support for arm64 platforms.
Date: Tue, 26 Jan 2016 12:52:38 -0600 [thread overview]
Message-ID: <20160126185238.GB17600@localhost> (raw)
In-Reply-To: <1453134965-6125-2-git-send-email-gkulkarni@caviumnetworks.com>
On Mon, Jan 18, 2016 at 10:06:00PM +0530, Ganapatrao Kulkarni wrote:
> Adding numa support for arm64 based platforms.
> This patch adds by default the dummy numa node and
> maps all memory and cpus to node 0.
> using this patch, numa can be simulated on single node arm64 platforms.
> diff --git a/arch/arm64/include/asm/mmzone.h b/arch/arm64/include/asm/mmzone.h
> new file mode 100644
> index 0000000..2cd804d
> --- /dev/null
> +++ b/arch/arm64/include/asm/mmzone.h
> @@ -0,0 +1,18 @@
> +#ifndef __ASM_MMZONE_H
> +#define __ASM_MMZONE_H
> +
> +#ifdef CONFIG_NUMA
> +
> +#include <linux/mmdebug.h>
> +#include <linux/types.h>
> +
> +#include <asm/smp.h>
> +#include <asm/numa.h>
Are all these #includes really necessary? s390 looks very similar and
doesn't need the #includes.
> +extern struct pglist_data *node_data[];
> +
> +#define NODE_DATA(nid) (node_data[(nid)])
> +
> +#endif /* CONFIG_NUMA */
> +
> +#endif /* __ASM_MMZONE_H */
> diff --git a/arch/arm64/include/asm/numa.h b/arch/arm64/include/asm/numa.h
> new file mode 100644
> index 0000000..f28f15b0
> --- /dev/null
> +++ b/arch/arm64/include/asm/numa.h
> @@ -0,0 +1,40 @@
> +#ifndef __ASM_NUMA_H
> +#define __ASM_NUMA_H
> +
> +#include <linux/nodemask.h>
> +#include <asm/topology.h>
> +
> +#ifdef CONFIG_NUMA
> +
> +/* currently, arm64 implements flat NUMA topology */
> +#define parent_node(node) (node)
> +
> +extern int __node_distance(int from, int to);
Below you add some extern function declarations without the "extern"
keyword. I don't know what the convention is for arm64 (I omit the
"extern" for PCI), but it seems like you should at least be
consistent.
> +#define node_distance(a, b) __node_distance(a, b)
> +
> +extern int cpu_to_node_map[NR_CPUS];
> +extern nodemask_t numa_nodes_parsed __initdata;
> +
> +/* Mappings between node number and cpus on that node. */
> +extern cpumask_var_t node_to_cpumask_map[MAX_NUMNODES];
> +extern void numa_clear_node(unsigned int cpu);
> +#ifdef CONFIG_DEBUG_PER_CPU_MAPS
> +extern const struct cpumask *cpumask_of_node(int node);
> +#else
> +/* Returns a pointer to the cpumask of CPUs on Node 'node'. */
> +static inline const struct cpumask *cpumask_of_node(int node)
> +{
> + return node_to_cpumask_map[node];
> +}
> +#endif
> +
> +void __init arm64_numa_init(void);
> +int __init numa_add_memblk(int nodeid, u64 start, u64 end);
> +void __init numa_set_distance(int from, int to, int distance);
> +void __init numa_reset_distance(void);
> +void numa_store_cpu_info(unsigned int cpu);
next prev parent reply other threads:[~2016-01-26 18:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 16:35 [PATCH v9 0/6] arm64, numa: Add numa support for arm64 platforms Ganapatrao Kulkarni
2016-01-18 16:36 ` [PATCH v9 1/6] arm64, numa: adding " Ganapatrao Kulkarni
2016-01-26 18:52 ` Bjorn Helgaas [this message]
2016-01-18 16:36 ` [PATCH v9 2/6] Documentation, dt, arm64/arm: dt bindings for numa Ganapatrao Kulkarni
2016-01-20 14:18 ` Rob Herring
2016-01-26 17:16 ` Ganapatrao Kulkarni
2016-01-18 16:36 ` [PATCH v9 3/6] arm64/arm, numa, dt: adding numa dt binding implementation for arm64 platforms Ganapatrao Kulkarni
2016-01-26 20:36 ` Bjorn Helgaas
2016-01-28 14:39 ` Will Deacon
2016-01-28 17:12 ` Ganapatrao Kulkarni
2016-01-28 18:08 ` Will Deacon
2016-01-28 18:48 ` Ganapatrao Kulkarni
2016-01-18 16:36 ` [PATCH v9 4/6] arm64, dt, thunderx: Add initial dts for Cavium Thunderx in 2 node topology Ganapatrao Kulkarni
2016-01-18 17:49 ` David Daney
2016-01-18 16:36 ` [PATCH v9 5/6] PCI: generic: Make pci-host-generic driver numa aware Ganapatrao Kulkarni
2016-01-18 17:41 ` David Daney
2016-01-19 5:58 ` Ganapatrao Kulkarni
2016-01-19 9:41 ` Lorenzo Pieralisi
2016-01-19 12:32 ` Ganapatrao Kulkarni
2016-01-26 20:50 ` Bjorn Helgaas
2016-01-26 20:52 ` Bjorn Helgaas
2016-01-18 16:36 ` [RFC PATCH v9 6/6] topology, cleanup: Avoid redefinition of cpumask_of_pcibus in asm header files Ganapatrao Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126185238.GB17600@localhost \
--to=helgaas@kernel$(echo .)org \
--cc=Prasun.Kapoor@caviumnetworks$(echo .)com \
--cc=Will.Deacon@arm$(echo .)com \
--cc=al.stone@linaro$(echo .)org \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bhelgaas@google$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=fenghua.yu@intel$(echo .)com \
--cc=galak@codeaurora$(echo .)org \
--cc=gkulkarni@caviumnetworks$(echo .)com \
--cc=gpkulkarni@gmail$(echo .)com \
--cc=grant.likely@linaro$(echo .)org \
--cc=hanjun.guo@linaro$(echo .)org \
--cc=hpa@zytor$(echo .)com \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=james.hogan@imgtec$(echo .)com \
--cc=jonathan@jonmasters$(echo .)org \
--cc=leif.lindholm@linaro$(echo .)org \
--cc=lenb@kernel$(echo .)org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-metag@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=marc.zyngier@arm$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=msalter@redhat$(echo .)com \
--cc=pawel.moll@arm$(echo .)com \
--cc=rfranz@cavium$(echo .)com \
--cc=rjw@rjwysocki$(echo .)net \
--cc=robh+dt@kernel$(echo .)org \
--cc=rrichter@cavium$(echo .)com \
--cc=steve.capper@linaro$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox