From: Will Deacon <will.deacon@arm•com>
To: Ganapatrao Kulkarni <gpkulkarni@gmail•com>
Cc: Bjorn Helgaas <helgaas@kernel•org>,
Ganapatrao Kulkarni <gkulkarni@caviumnetworks•com>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
linux-pci@vger•kernel.org, linux-ia64@vger•kernel.org,
linux-metag@vger•kernel.org,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
linux-s390@vger•kernel.org, linux-sh@vger•kernel.org,
linux-arch@vger•kernel.org,
Catalin Marinas <catalin.marinas@arm•com>,
Grant Likely <grant.likely@linaro•org>,
Leif Lindholm <leif.lindholm@linaro•org>,
rfranz@cavium•com, Ard Biesheuvel <ard.biesheuvel@linaro•org>,
"msalter@redhat•com" <msalter@redhat•com>,
Rob Herring <robh+dt@kernel•org>,
Steve Capper <steve.capper@linaro•org>,
Hanjun Guo <hanjun.guo@linaro•org>,
Al Stone <al.stone@linaro•org>, Arnd Bergmann <arnd@arndb•de>,
Pawel Moll <pawel.moll@arm•com>,
Mark Rutland <mark.rutland@arm•com>,
Ian Campbell <ijc+devicetree@hellion•org.uk>,
Kumar Gala <galak@codeaurora•org>,
"Rafael J. Wysocki" <rjw@rjwysocki•net>,
Len Brown <lenb@kernel•org>, Marc Zyngier <marc.zyngier@arm•com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm•com>,
Bjorn Helgaas <bhelgaas@google•com>,
tony.luck@intel•com, fenghua.yu@intel•com,
james.hogan@imgtec•com,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
"tglx@linutronix•de" <tglx@linutronix•de>,
mingo@redhat•com, hpa@zytor•com, x86@kernel•org,
Jon Masters <jonathan@jonmasters•org>,
Robert Richter <rrichter@cavium•com>,
Prasun Kapoor <Prasun.Kapoor@caviumnetworks•com>
Subject: Re: [PATCH v9 3/6] arm64/arm, numa, dt: adding numa dt binding implementation for arm64 platforms.
Date: Thu, 28 Jan 2016 18:08:24 +0000 [thread overview]
Message-ID: <20160128180824.GP775@arm.com> (raw)
In-Reply-To: <CAFpQJXVhEVw7vSq233wfkOGkTanf-msO+PEcWJ2OVAFUhn7n+w@mail.gmail.com>
On Thu, Jan 28, 2016 at 10:42:17PM +0530, Ganapatrao Kulkarni wrote:
> On Thu, Jan 28, 2016 at 8:09 PM, Will Deacon <will.deacon@arm•com> wrote:
> > On Tue, Jan 26, 2016 at 02:36:04PM -0600, Bjorn Helgaas wrote:
> >> Subject is "arm64/arm, numa, dt: adding ..." What is the significance
> >> of the "arm" part? The other patches only mention "arm64".
> >>
> >> General comment: the code below has little, if anything, that is
> >> actually arm64-specific. Maybe this is the first DT-based NUMA
> >> platform? I don't see other similar code for other arches, so maybe
> >> it's too early to try to generalize it, but we should try to avoid
> >> adding duplicates of this code if/when other arches do show up.
> >
> > Having it in the core code would allow us to share it with arch/arm/
> > fairly straightforwardly.
> This binding can be used for arm too.
> however at this moment it is the need of arm64 platforms.
> can we please keep this to arm64 as it's too early to try to
> generalize it(as Bjorn suggested)
> I prefer to keep it as it is, otherwise ok.
> Please suggest.
My suggestions time and time again on the NUMA patches from you have
consistently been around consolidation of existing code, or moving things
that aren't architecture-specific out of the architecture code.
Will
next prev parent reply other threads:[~2016-01-28 18:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 16:35 [PATCH v9 0/6] arm64, numa: Add numa support for arm64 platforms Ganapatrao Kulkarni
2016-01-18 16:36 ` [PATCH v9 1/6] arm64, numa: adding " Ganapatrao Kulkarni
2016-01-26 18:52 ` Bjorn Helgaas
2016-01-18 16:36 ` [PATCH v9 2/6] Documentation, dt, arm64/arm: dt bindings for numa Ganapatrao Kulkarni
2016-01-20 14:18 ` Rob Herring
2016-01-26 17:16 ` Ganapatrao Kulkarni
2016-01-18 16:36 ` [PATCH v9 3/6] arm64/arm, numa, dt: adding numa dt binding implementation for arm64 platforms Ganapatrao Kulkarni
2016-01-26 20:36 ` Bjorn Helgaas
2016-01-28 14:39 ` Will Deacon
2016-01-28 17:12 ` Ganapatrao Kulkarni
2016-01-28 18:08 ` Will Deacon [this message]
2016-01-28 18:48 ` Ganapatrao Kulkarni
2016-01-18 16:36 ` [PATCH v9 4/6] arm64, dt, thunderx: Add initial dts for Cavium Thunderx in 2 node topology Ganapatrao Kulkarni
2016-01-18 17:49 ` David Daney
2016-01-18 16:36 ` [PATCH v9 5/6] PCI: generic: Make pci-host-generic driver numa aware Ganapatrao Kulkarni
2016-01-18 17:41 ` David Daney
2016-01-19 5:58 ` Ganapatrao Kulkarni
2016-01-19 9:41 ` Lorenzo Pieralisi
2016-01-19 12:32 ` Ganapatrao Kulkarni
2016-01-26 20:50 ` Bjorn Helgaas
2016-01-26 20:52 ` Bjorn Helgaas
2016-01-18 16:36 ` [RFC PATCH v9 6/6] topology, cleanup: Avoid redefinition of cpumask_of_pcibus in asm header files Ganapatrao Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128180824.GP775@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=Prasun.Kapoor@caviumnetworks$(echo .)com \
--cc=al.stone@linaro$(echo .)org \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bhelgaas@google$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=fenghua.yu@intel$(echo .)com \
--cc=galak@codeaurora$(echo .)org \
--cc=gkulkarni@caviumnetworks$(echo .)com \
--cc=gpkulkarni@gmail$(echo .)com \
--cc=grant.likely@linaro$(echo .)org \
--cc=hanjun.guo@linaro$(echo .)org \
--cc=helgaas@kernel$(echo .)org \
--cc=hpa@zytor$(echo .)com \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=james.hogan@imgtec$(echo .)com \
--cc=jonathan@jonmasters$(echo .)org \
--cc=leif.lindholm@linaro$(echo .)org \
--cc=lenb@kernel$(echo .)org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-metag@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=marc.zyngier@arm$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=msalter@redhat$(echo .)com \
--cc=pawel.moll@arm$(echo .)com \
--cc=rfranz@cavium$(echo .)com \
--cc=rjw@rjwysocki$(echo .)net \
--cc=robh+dt@kernel$(echo .)org \
--cc=rrichter@cavium$(echo .)com \
--cc=steve.capper@linaro$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox