public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: linux-kernel@vger•kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
	stable@vger•kernel.org, Jan Stancek <jstancek@redhat•com>,
	Raghavendra K T <raghavendra.kt@linux•vnet.ibm.com>,
	gkurz@linux•vnet.ibm.com, grant.likely@linaro•org,
	nikunj@linux•vnet.ibm.com, vdavydov@parallels•com,
	linuxppc-dev@lists•ozlabs.org, linux-mm@kvack•org,
	peterz@infradead•org, benh@kernel•crashing.org, paulus@samba•org,
	mpe@ellerman•id.au, anton@samba•org,
	Ingo Molnar <mingo@kernel•org>
Subject: [PATCH 4.3 156/200] sched: Fix crash in sched_init_numa()
Date: Sun, 14 Feb 2016 14:22:43 -0800	[thread overview]
Message-ID: <20160214222223.033623423@linuxfoundation.org> (raw)
In-Reply-To: <20160214222217.084543173@linuxfoundation.org>

4.3-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Raghavendra K T <raghavendra.kt@linux•vnet.ibm.com>

commit 9c03ee147193645be4c186d3688232fa438c57c7 upstream.

The following PowerPC commit:

  c118baf80256 ("arch/powerpc/mm/numa.c: do not allocate bootmem memory for non existing nodes")

avoids allocating bootmem memory for non existent nodes.

But when DEBUG_PER_CPU_MAPS=y is enabled, my powerNV system failed to boot
because in sched_init_numa(), cpumask_or() operation was done on
unallocated nodes.

Fix that by making cpumask_or() operation only on existing nodes.

[ Tested with and w/o DEBUG_PER_CPU_MAPS=y on x86 and PowerPC. ]

Reported-by: Jan Stancek <jstancek@redhat•com>
Tested-by: Jan Stancek <jstancek@redhat•com>
Signed-off-by: Raghavendra K T <raghavendra.kt@linux•vnet.ibm.com>
Cc: <gkurz@linux•vnet.ibm.com>
Cc: <grant.likely@linaro•org>
Cc: <nikunj@linux•vnet.ibm.com>
Cc: <vdavydov@parallels•com>
Cc: <linuxppc-dev@lists•ozlabs.org>
Cc: <linux-mm@kvack•org>
Cc: <peterz@infradead•org>
Cc: <benh@kernel•crashing.org>
Cc: <paulus@samba•org>
Cc: <mpe@ellerman•id.au>
Cc: <anton@samba•org>
Link: http://lkml.kernel.org/r/1452884483-11676-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel•org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation•org>

---
 kernel/sched/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6678,7 +6678,7 @@ static void sched_init_numa(void)
 
 			sched_domains_numa_masks[i][j] = mask;
 
-			for (k = 0; k < nr_node_ids; k++) {
+			for_each_node(k) {
 				if (node_distance(j, k) > sched_domains_numa_distance[i])
 					continue;
 

           reply	other threads:[~2016-02-14 22:48 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20160214222217.084543173@linuxfoundation.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160214222223.033623423@linuxfoundation.org \
    --to=gregkh@linuxfoundation$(echo .)org \
    --cc=anton@samba$(echo .)org \
    --cc=benh@kernel$(echo .)crashing.org \
    --cc=gkurz@linux$(echo .)vnet.ibm.com \
    --cc=grant.likely@linaro$(echo .)org \
    --cc=jstancek@redhat$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-mm@kvack$(echo .)org \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=mingo@kernel$(echo .)org \
    --cc=mpe@ellerman$(echo .)id.au \
    --cc=nikunj@linux$(echo .)vnet.ibm.com \
    --cc=paulus@samba$(echo .)org \
    --cc=peterz@infradead$(echo .)org \
    --cc=raghavendra.kt@linux$(echo .)vnet.ibm.com \
    --cc=stable@vger$(echo .)kernel.org \
    --cc=vdavydov@parallels$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox