From: Will Deacon <will.deacon@arm•com>
To: David Daney <ddaney.cavm@gmail•com>
Cc: linux-arm-kernel@lists•infradead.org,
Mark Rutland <mark.rutland@arm•com>,
Catalin Marinas <catalin.marinas@arm•com>,
Tony Luck <tony.luck@intel•com>,
Fenghua Yu <fenghua.yu@intel•com>,
James Hogan <james.hogan@imgtec•com>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Michael Ellerman <mpe@ellerman•id.au>,
Martin Schwidefsky <schwidefsky@de•ibm.com>,
Heiko Carstens <heiko.carstens@de•ibm.com>,
Yoshinori Sato <ysato@users•sourceforge.jp>,
Rich Felker <dalias@libc•org>,
"David S. Miller" <davem@davemloft•net>,
Chris Metcalf <cmetcalf@ezchip•com>,
Thomas Gleixner <tglx@linutronix•de>,
Ingo Molnar <mingo@redhat•com>, "H. Peter Anvin" <hpa@zytor•com>,
x86@kernel•org, Arnd Bergmann <arnd@arndb•de>,
linux-ia64@vger•kernel.org, linux-metag@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, linux-s390@vger•kernel.org,
linux-sh@vger•kernel.org, sparclinux@vger•kernel.org,
linux-arch@vger•kernel.org, linux-kernel@vger•kernel.org,
Ganapatrao Kulkarni <gkulkarni@caviumnetworks•com>,
David Daney <david.daney@cavium•com>
Subject: Re: [PATCH 2/2] numa, mm, cleanup: remove redundant NODE_DATA macro from asm header files.
Date: Wed, 2 Mar 2016 02:15:50 +0000 [thread overview]
Message-ID: <20160302021550.GI14022@arm.com> (raw)
In-Reply-To: <1456358528-24213-3-git-send-email-ddaney.cavm@gmail.com>
On Wed, Feb 24, 2016 at 04:02:08PM -0800, David Daney wrote:
> From: Ganapatrao Kulkarni <gkulkarni@caviumnetworks•com>
>
> NODE_DATA is defined across multiple asm header files.
> Moving generic definition to asm-generic/mmzone.h to
> remove redundant definitions.
>
> Reviewed-by: Robert Richter <rrichter@cavium•com>
> Signed-off-by: Ganapatrao Kulkarni <gkulkarni@caviumnetworks•com>
> Signed-off-by: David Daney <david.daney@cavium•com>
> ---
> arch/arm64/include/asm/mmzone.h | 4 +---
> arch/m32r/include/asm/mmzone.h | 4 +---
> arch/metag/include/asm/mmzone.h | 4 +---
> arch/powerpc/include/asm/mmzone.h | 8 ++------
> arch/s390/include/asm/mmzone.h | 6 +-----
> arch/sh/include/asm/mmzone.h | 4 +---
> arch/sparc/include/asm/mmzone.h | 6 ++----
> arch/x86/include/asm/mmzone.h | 3 +--
> arch/x86/include/asm/mmzone_32.h | 5 -----
> arch/x86/include/asm/mmzone_64.h | 17 -----------------
> include/asm-generic/mmzone.h | 24 ++++++++++++++++++++++++
> 11 files changed, 34 insertions(+), 51 deletions(-)
> delete mode 100644 arch/x86/include/asm/mmzone_64.h
> create mode 100644 include/asm-generic/mmzone.h
>
> diff --git a/arch/arm64/include/asm/mmzone.h b/arch/arm64/include/asm/mmzone.h
> index a0de9e6..611a1cf 100644
> --- a/arch/arm64/include/asm/mmzone.h
> +++ b/arch/arm64/include/asm/mmzone.h
> @@ -4,9 +4,7 @@
> #ifdef CONFIG_NUMA
>
> #include <asm/numa.h>
> -
> -extern struct pglist_data *node_data[];
> -#define NODE_DATA(nid) (node_data[(nid)])
> +#include <asm-generic/mmzone.h>
>
> #endif /* CONFIG_NUMA */
> #endif /* __ASM_MMZONE_H */
Actually, we can remove the header file entirely and use a generic-y
line in Kbuild instead.
Will
prev parent reply other threads:[~2016-03-02 2:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 0:02 [PATCH 0/2] NUMA related header file cleanups David Daney
2016-02-25 0:02 ` [PATCH 1/2] topology, cleanup: Avoid redefinition of cpumask_of_pcibus in asm header files David Daney
2016-03-02 2:17 ` Will Deacon
2016-02-25 0:02 ` [PATCH 2/2] numa, mm, cleanup: remove redundant NODE_DATA macro from " David Daney
2016-03-02 2:15 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302021550.GI14022@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=cmetcalf@ezchip$(echo .)com \
--cc=dalias@libc$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=david.daney@cavium$(echo .)com \
--cc=ddaney.cavm@gmail$(echo .)com \
--cc=fenghua.yu@intel$(echo .)com \
--cc=gkulkarni@caviumnetworks$(echo .)com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=james.hogan@imgtec$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-metag@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=x86@kernel$(echo .)org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox