From: Daniel Vetter <daniel@ffwll•ch>
To: Joe Perches <joe@perches•com>
Cc: "Gustavo Padovan" <gustavo@padovan•org>,
"Rob Clark" <robdclark@gmail•com>,
"Gustavo Padovan" <gustavo.padovan@collabora•co.uk>,
"Benjamin Herrenschmidt" <benh@kernel•crashing.org>,
"Paul Mackerras" <paulus@samba•org>,
"Michael Ellerman" <mpe@ellerman•id.au>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Linux Kernel Mailing List" <linux-kernel@vger•kernel.org>,
devel@driverdev•osuosl.org,
"dri-devel@lists•freedesktop.org"
<dri-devel@lists•freedesktop.org>,
"Daniel Stone" <daniels@collabora•com>,
"Arve Hjønnevåg" <arve@android•com>,
"Riley Andrews" <riandrews@android•com>,
"Daniel Vetter" <daniel.vetter@ffwll•ch>,
"Greg Hackmann" <ghackmann@google•com>,
"John Harrison" <John.C.Harrison@intel•com>,
"Maarten Lankhorst" <maarten.lankhorst@linux•intel.com>,
"Andrew Morton" <akpm@linux-foundation•org>,
"David Airlie" <airlied@linux•ie>,
"Daniel Vetter" <daniel.vetter@intel•com>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr()
Date: Fri, 18 Mar 2016 09:23:56 +0100 [thread overview]
Message-ID: <20160318082356.GF14170@phenom.ffwll.local> (raw)
In-Reply-To: <1458250430.9556.39.camel@perches.com>
On Thu, Mar 17, 2016 at 02:33:50PM -0700, Joe Perches wrote:
> On Thu, 2016-03-17 at 18:19 -0300, Gustavo Padovan wrote:
> > 2016-03-17 Joe Perches <joe@perches•com>:
> > > On Thu, 2016-03-17 at 16:50 -0400, Rob Clark wrote:
> > > > On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches <joe@perches•com> wrote:
> > > []
> > > > > It's a name that seems like it should be a straightforward
> > > > > cast of a kernel pointer to a __user pointer like:
> > > > >
> > > > > static inline void __user *to_user_ptr(void *p)
> > > > > {
> > > > > return (void __user *)p;
> > > > > }
> > > > ahh, ok. I guess I was used to using it in the context of ioctl
> > > > structs.. in that context u64 -> (void __user *) made more sense.
> > > >
> > > > Maybe uapi_to_ptr()? (ok, not super-creative.. maybe someone has a
> > > > better idea)
> > > Maybe u64_to_user_ptr?
> > That is a good name. If everyone agrees I can resend this patch
> > changing it to u64_to_user_ptr. Then should we still keep it on
> > kernel.h?
>
> I've no particular opinion about location,
> but maybe compat.h might be appropriate.
>
> Maybe add all variants:
>
> void __user *u32_to_user_ptr(u32 val)
> void __user *u64_to_user_ptr(u64 val)
> u32 user_ptr_to_u32(void __user *p)
> u64 user_ptr_to_u64(void __user *p)
>
> Maybe there's something about 32 bit userspace on
> 64 OS that should be done too.
Tbh I really don't think we should add 32bit variants and encourage the
mispractice of having 32bit user ptrs in ioctl structs and stuff. Anyway,
just my bikeshed on top ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2016-03-18 8:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1458235817-28375-1-git-send-email-gustavo@padovan.org>
[not found] ` <1458235817-28375-2-git-send-email-gustavo@padovan.org>
[not found] ` <1458236486.9556.11.camel@perches.com>
[not found] ` <20160317180523.GA2619@joana>
[not found] ` <20160317184318.GA2611@joana>
2016-03-17 20:22 ` [PATCH v9 2/3] kernel.h: add to_user_ptr() Joe Perches
2016-03-17 20:33 ` Rob Clark
2016-03-17 20:40 ` Joe Perches
2016-03-17 20:50 ` Rob Clark
2016-03-17 21:10 ` Joe Perches
2016-03-17 21:19 ` Gustavo Padovan
2016-03-17 21:25 ` Rob Clark
2016-03-17 21:33 ` Joe Perches
2016-03-17 22:16 ` Gustavo Padovan
2016-03-18 8:23 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318082356.GF14170@phenom.ffwll.local \
--to=daniel@ffwll$(echo .)ch \
--cc=John.C.Harrison@intel$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arve@android$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=daniel.vetter@ffwll$(echo .)ch \
--cc=daniel.vetter@intel$(echo .)com \
--cc=daniels@collabora$(echo .)com \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=ghackmann@google$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=gustavo.padovan@collabora$(echo .)co.uk \
--cc=gustavo@padovan$(echo .)org \
--cc=joe@perches$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
--cc=riandrews@android$(echo .)com \
--cc=robdclark@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox