Subject: Re: [RFC PATCH 2/3] arch/powerpc : optprobes for powerpc core

From: Masami Hiramatsu <[email-masked]>
Date: Fri, 20 May 2016 20:35:15 +0900

On Thu, 19 May 2016 13:19:42 +0530
Anju T <[email-masked]> wrote:

> >> +void arch_unoptimize_kprobes(struct list_head *oplist,
> >> +			     struct list_head *done_list)
> >> +{
> >> +	struct optimized_kprobe *op;
> >> +	struct optimized_kprobe *tmp;
> >> +
> >> +	list_for_each_entry_safe(op, tmp, oplist, list) {
> >> +		arch_unoptimize_kprobe(op);
> >> +		list_move(&op->list, done_list);
> >> +	}
> >> +}
> >> +
> >> +int arch_within_optimized_kprobe(struct optimized_kprobe *op,
> >> +				 unsigned long addr)
> >> +{
> > Please make sure addr != op->kp.addr and addr is aligned.
> 
> The only case this check will succeed is if kp.addr is not a multiple of 4, which is not a valid address at all on
> Power.So should we again check here for that?

Ah, right. OK, so we may not need that.

Thank you,
-- 
Masami Hiramatsu <[email-masked]>