From: Gautham R Shenoy <ego@linux•vnet.ibm.com>
To: "Shreyas B. Prabhu" <shreyas@linux•vnet.ibm.com>
Cc: mpe@ellerman•id.au, linuxppc-dev@lists•ozlabs.org,
paulus@ozlabs•org, linux-kernel@vger•kernel.org,
mikey@neuling•org, ego@linux•vnet.ibm.com
Subject: Re: [PATCH v3 3/9] powerpc/powernv: Rename reusable idle functions to hardware agnostic names
Date: Tue, 24 May 2016 14:00:49 +0530 [thread overview]
Message-ID: <20160524083049.GB12860@in.ibm.com> (raw)
In-Reply-To: <1464016722-7488-4-git-send-email-shreyas@linux.vnet.ibm.com>
On Mon, May 23, 2016 at 08:48:36PM +0530, Shreyas B. Prabhu wrote:
> Functions like power7_wakeup_loss, power7_wakeup_noloss,
> power7_wakeup_tb_loss are used by POWER7 and POWER8 hardware. They can
> also be used by POWER9. Hence rename these functions hardware agnostic
> names.
>
> Suggested-by: Gautham R. Shenoy <ego@linux•vnet.ibm.com>
> Signed-off-by: Shreyas B. Prabhu <shreyas@linux•vnet.ibm.com>
> ---
> New in v3
>
> arch/powerpc/kernel/exceptions-64s.S | 6 +++---
> arch/powerpc/kernel/idle_power_common.S | 16 ++++++++--------
> arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++--
> 3 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
> index 4a74d6a..a0da627 100644
> --- a/arch/powerpc/kernel/exceptions-64s.S
> +++ b/arch/powerpc/kernel/exceptions-64s.S
> @@ -108,7 +108,7 @@ BEGIN_FTR_SECTION
>
> cmpwi cr3,r13,2
> GET_PACA(r13)
> - bl power7_restore_hyp_resource
> + bl pnv_restore_hyp_resource
>
> li r0,PNV_THREAD_RUNNING
> stb r0,PACA_THREAD_IDLE_STATE(r13) /* Clear thread state */
> @@ -128,8 +128,8 @@ BEGIN_FTR_SECTION
> /* Return SRR1 from power7_nap() */
> mfspr r3,SPRN_SRR1
> blt cr3,2f
> - b power7_wakeup_loss
> -2: b power7_wakeup_noloss
> + b pnv_wakeup_loss
> +2: b pnv_wakeup_noloss
>
> 9:
> END_FTR_SECTION_IFSET(CPU_FTR_HVMODE | CPU_FTR_ARCH_206)
> diff --git a/arch/powerpc/kernel/idle_power_common.S b/arch/powerpc/kernel/idle_power_common.S
> index db59613..973c9a1 100644
> --- a/arch/powerpc/kernel/idle_power_common.S
> +++ b/arch/powerpc/kernel/idle_power_common.S
The comment at the beginning of idle_power_common.S still reads
"This file contains the power_save function for Power7 CPUs."
Please update that as well.
Reviewed-by: Gautham R. Shenoy <ego@linux•vnet.ibm.com>
next prev parent reply other threads:[~2016-05-24 8:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 15:18 [PATCH v3 0/9] powerpc/powernv/cpuidle: Add support for POWER ISA v3 idle states Shreyas B. Prabhu
2016-05-23 15:18 ` [PATCH v3 1/9] powerpc/kvm: make hypervisor state restore a function Shreyas B. Prabhu
2016-05-23 15:18 ` [PATCH v3 2/9] powerpc/powernv: Rename idle_power7.S to idle_power_common.S Shreyas B. Prabhu
2016-05-24 8:27 ` Gautham R Shenoy
2016-05-23 15:18 ` [PATCH v3 3/9] powerpc/powernv: Rename reusable idle functions to hardware agnostic names Shreyas B. Prabhu
2016-05-24 8:30 ` Gautham R Shenoy [this message]
2016-05-23 15:18 ` [PATCH v3 4/9] powerpc/powernv: Make power7_powersave_common more generic Shreyas B. Prabhu
2016-05-24 8:54 ` Gautham R Shenoy
2016-05-23 15:18 ` [PATCH v3 5/9] powerpc/powernv: abstraction for saving SPRs before entering deep idle states Shreyas B. Prabhu
2016-05-24 8:55 ` Gautham R Shenoy
2016-05-23 15:18 ` [PATCH v3 6/9] powerpc/powernv: set power_save func after the idle states are initialized Shreyas B. Prabhu
2016-05-23 15:18 ` [PATCH v3 7/9] powerpc/powernv: Add platform support for stop instruction Shreyas B. Prabhu
2016-05-24 8:47 ` Madhavan Srinivasan
2016-05-24 10:24 ` Gautham R Shenoy
2016-05-25 2:16 ` Shreyas B Prabhu
[not found] ` <886163be-b915-b60f-b25b-bf770f3ed821@linux.vnet.ibm.com>
2016-05-25 2:12 ` Shreyas B Prabhu
2016-05-23 15:18 ` [PATCH v3 8/9] cpuidle/powernv: Add support for POWER ISA v3 idle states Shreyas B. Prabhu
2016-05-24 10:37 ` Gautham R Shenoy
2016-05-23 15:18 ` [PATCH v3 9/9] powerpc/powernv: Use deepest stop state when cpu is offlined Shreyas B. Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160524083049.GB12860@in.ibm.com \
--to=ego@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@ozlabs$(echo .)org \
--cc=shreyas@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox