From: Gavin Shan <gwshan@linux•vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: linuxppc dev list <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH] powerpc/pci: Reduce log level of PCI I/O space warning
Date: Fri, 24 Jun 2016 16:31:15 +1000 [thread overview]
Message-ID: <20160624063115.GA13944@gwshan> (raw)
In-Reply-To: <1466580187.4089.23.camel@kernel.crashing.org>
On Wed, Jun 22, 2016 at 05:23:07PM +1000, Benjamin Herrenschmidt wrote:
>If a PHB has no I/O space, there's no need to make it look like
>something bad happened, a pr_debug() is plenty enough since this
>is the case of all our modern POWER chips.
>
>Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Reviewed-by: Gavin Shan <gwshan@linux•vnet.ibm.com>
>---
> arch/powerpc/kernel/pci-common.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
>index 2a67b16..3ab1f7b 100644
>--- a/arch/powerpc/kernel/pci-common.c
>+++ b/arch/powerpc/kernel/pci-common.c
>@@ -1487,9 +1487,9 @@ static void pcibios_setup_phb_resources(struct pci_controller *hose,
> res = &hose->io_resource;
>
> if (!res->flags) {
>- pr_info("PCI: I/O resource not set for host"
>- " bridge %s (domain %d)\n",
>- hose->dn->full_name, hose->global_number);
>+ pr_debug("PCI: I/O resource not set for host"
>+ " bridge %s (domain %d)\n",
>+ hose->dn->full_name, hose->global_number);
> } else {
> offset = pcibios_io_space_offset(hose);
>
>
>
>_______________________________________________
>Linuxppc-dev mailing list
>Linuxppc-dev@lists•ozlabs.org
>https://lists.ozlabs.org/listinfo/linuxppc-dev
next prev parent reply other threads:[~2016-06-24 6:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 7:23 [PATCH] powerpc/pci: Reduce log level of PCI I/O space warning Benjamin Herrenschmidt
2016-06-24 6:31 ` Gavin Shan [this message]
2016-06-28 12:10 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624063115.GA13944@gwshan \
--to=gwshan@linux$(echo .)vnet.ibm.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox