From: Boris Brezillon <boris.brezillon@free-electrons•com>
To: Raghav Dogra <raghav.dogra@nxp•com>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Michael Ellerman <mpe@ellerman•id.au>
Cc: <linux-mtd@lists•infradead.org>,
prabhakar.kushwaha@nxp•com, leoyang.li@nxp•com, oss@buserror•net,
computersforpeace@gmail•com, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH][v2] driver/memory: Update dependency of IFC for Layerscape
Date: Mon, 4 Jul 2016 11:29:26 +0200 [thread overview]
Message-ID: <20160704112926.351aebf4@bbrezillon> (raw)
In-Reply-To: <1467388950-4895-1-git-send-email-raghav.dogra@nxp.com>
+PPC maintainers.
Hi Raghav,
Since you're touching powerpc drivers, the least you could do is add
ppc maintainers in Cc, so that they can ack/review your patch...
On Fri, 1 Jul 2016 21:32:30 +0530
Raghav Dogra <raghav.dogra@nxp•com> wrote:
> This patch enables IFC NAND support on ARM layerscape platform.
> It fixes the dependency to enable NAND. The include files are being modified
> to ensure complilation for both PowerPC and ARM architectures.
Still think this could be separated in 2 commits:
- the first one getting rid of the asm/prom.h inclusion
- the second one changing the Kconfig dependency
>
> Signed-off-by: Raghav Dogra <raghav.dogra@nxp•com>
> ---
> Applicable to git://git.infradead.org/l2-mtd.git
>
> Changes for v2: updated commit description
>
> drivers/memory/Kconfig | 2 +-
> drivers/memory/fsl_ifc.c | 4 +++-
> drivers/mtd/nand/Kconfig | 2 +-
> 3 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index 81ddb17..5645705 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -104,7 +104,7 @@ config FSL_CORENET_CF
>
> config FSL_IFC
> bool
> - depends on FSL_SOC
> + depends on FSL_SOC || ARCH_LAYERSCAPE
>
> config JZ4780_NEMC
> bool "Ingenic JZ4780 SoC NEMC driver"
> diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c
> index 904b4af..1b182b1 100644
> --- a/drivers/memory/fsl_ifc.c
> +++ b/drivers/memory/fsl_ifc.c
> @@ -31,7 +31,9 @@
> #include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/fsl_ifc.h>
> -#include <asm/prom.h>
> +#include <linux/irqdomain.h>
> +#include <linux/of_address.h>
> +#include <linux/of_irq.h>
>
> struct fsl_ifc_ctrl *fsl_ifc_ctrl_dev;
> EXPORT_SYMBOL(fsl_ifc_ctrl_dev);
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index f05e0e9..eace3ef 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -438,7 +438,7 @@ config MTD_NAND_FSL_ELBC
>
> config MTD_NAND_FSL_IFC
> tristate "NAND support for Freescale IFC controller"
> - depends on MTD_NAND && FSL_SOC
> + depends on MTD_NAND && (FSL_SOC || ARCH_LAYERSCAPE)
> select FSL_IFC
> select MEMORY
> help
next parent reply other threads:[~2016-07-04 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1467388950-4895-1-git-send-email-raghav.dogra@nxp.com>
2016-07-04 9:29 ` Boris Brezillon [this message]
2016-07-04 9:49 ` [PATCH][v2] driver/memory: Update dependency of IFC for Layerscape Benjamin Herrenschmidt
2016-07-04 9:53 ` Raghav Dogra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704112926.351aebf4@bbrezillon \
--to=boris.brezillon@free-electrons$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=computersforpeace@gmail$(echo .)com \
--cc=leoyang.li@nxp$(echo .)com \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=oss@buserror$(echo .)net \
--cc=paulus@samba$(echo .)org \
--cc=prabhakar.kushwaha@nxp$(echo .)com \
--cc=raghav.dogra@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox