From: Dan Carpenter <dan.carpenter@oracle•com>
To: Alexander Graf <agraf@suse•com>, Bharat Bhushan <r65777@freescale•com>
Cc: "Paolo Bonzini" <pbonzini@redhat•com>,
"Radim Krčmář" <rkrcmar@redhat•com>,
"Benjamin Herrenschmidt" <benh@kernel•crashing.org>,
"Paul Mackerras" <paulus@samba•org>,
"Michael Ellerman" <mpe@ellerman•id.au>,
kvm-ppc@vger•kernel.org, kvm@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, kernel-janitors@vger•kernel.org
Subject: [patch] KVM: PPC: fix a sanity check
Date: Thu, 14 Jul 2016 13:15:46 +0300 [thread overview]
Message-ID: <20160714101545.GB18175@mwanda> (raw)
We use logical negate where bitwise negate was intended. It means that
we never return -EINVAL here.
Fixes: ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle•com>
diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index 02b4672..df3f270 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -2038,7 +2038,7 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,
if (type == KVMPPC_DEBUG_NONE)
continue;
- if (type & !(KVMPPC_DEBUG_WATCH_READ |
+ if (type & ~(KVMPPC_DEBUG_WATCH_READ |
KVMPPC_DEBUG_WATCH_WRITE |
KVMPPC_DEBUG_BREAKPOINT))
return -EINVAL;
next reply other threads:[~2016-07-14 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 10:15 Dan Carpenter [this message]
2016-07-14 11:10 ` [patch] KVM: PPC: fix a sanity check Alexander Graf
2016-09-27 5:46 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714101545.GB18175@mwanda \
--to=dan.carpenter@oracle$(echo .)com \
--cc=agraf@suse$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
--cc=pbonzini@redhat$(echo .)com \
--cc=r65777@freescale$(echo .)com \
--cc=rkrcmar@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox