From: David Gibson <david@gibson•dropbear.id.au>
To: Alexey Kardashevskiy <aik@ozlabs•ru>
Cc: linuxppc-dev@lists•ozlabs.org,
Alex Williamson <alex.williamson@redhat•com>,
Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCH kernel 13/15] KVM: PPC: Pass kvm* to kvmppc_find_table()
Date: Fri, 12 Aug 2016 14:45:49 +1000 [thread overview]
Message-ID: <20160812044549.GP16493@voom.fritz.box> (raw)
In-Reply-To: <1470213656-1042-14-git-send-email-aik@ozlabs.ru>
[-- Attachment #1: Type: text/plain, Size: 5109 bytes --]
On Wed, Aug 03, 2016 at 06:40:54PM +1000, Alexey Kardashevskiy wrote:
> The guest view TCE tables are per KVM anyway (not per VCPU) so pass kvm*
> there. This will be used in the following patches where we will be
> attaching VFIO containers to LIOBNs via ioctl() to KVM (rather than
> to VCPU).
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs•ru>
Reviewed-by: David Gibson <david@gibson•dropbear.id.au>
> ---
> arch/powerpc/include/asm/kvm_ppc.h | 2 +-
> arch/powerpc/kvm/book3s_64_vio.c | 7 ++++---
> arch/powerpc/kvm/book3s_64_vio_hv.c | 13 +++++++------
> 3 files changed, 12 insertions(+), 10 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/kvm_ppc.h b/arch/powerpc/include/asm/kvm_ppc.h
> index 2544eda..7f1abe9 100644
> --- a/arch/powerpc/include/asm/kvm_ppc.h
> +++ b/arch/powerpc/include/asm/kvm_ppc.h
> @@ -167,7 +167,7 @@ extern int kvmppc_pseries_do_hcall(struct kvm_vcpu *vcpu);
> extern long kvm_vm_ioctl_create_spapr_tce(struct kvm *kvm,
> struct kvm_create_spapr_tce_64 *args);
> extern struct kvmppc_spapr_tce_table *kvmppc_find_table(
> - struct kvm_vcpu *vcpu, unsigned long liobn);
> + struct kvm *kvm, unsigned long liobn);
> extern long kvmppc_ioba_validate(struct kvmppc_spapr_tce_table *stt,
> unsigned long ioba, unsigned long npages);
> extern long kvmppc_tce_validate(struct kvmppc_spapr_tce_table *tt,
> diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c
> index c379ff5..15df8ae 100644
> --- a/arch/powerpc/kvm/book3s_64_vio.c
> +++ b/arch/powerpc/kvm/book3s_64_vio.c
> @@ -212,12 +212,13 @@ fail:
> long kvmppc_h_put_tce(struct kvm_vcpu *vcpu, unsigned long liobn,
> unsigned long ioba, unsigned long tce)
> {
> - struct kvmppc_spapr_tce_table *stt = kvmppc_find_table(vcpu, liobn);
> + struct kvmppc_spapr_tce_table *stt;
> long ret;
>
> /* udbg_printf("H_PUT_TCE(): liobn=0x%lx ioba=0x%lx, tce=0x%lx\n", */
> /* liobn, ioba, tce); */
>
> + stt = kvmppc_find_table(vcpu->kvm, liobn);
> if (!stt)
> return H_TOO_HARD;
>
> @@ -245,7 +246,7 @@ long kvmppc_h_put_tce_indirect(struct kvm_vcpu *vcpu,
> u64 __user *tces;
> u64 tce;
>
> - stt = kvmppc_find_table(vcpu, liobn);
> + stt = kvmppc_find_table(vcpu->kvm, liobn);
> if (!stt)
> return H_TOO_HARD;
>
> @@ -299,7 +300,7 @@ long kvmppc_h_stuff_tce(struct kvm_vcpu *vcpu,
> struct kvmppc_spapr_tce_table *stt;
> long i, ret;
>
> - stt = kvmppc_find_table(vcpu, liobn);
> + stt = kvmppc_find_table(vcpu->kvm, liobn);
> if (!stt)
> return H_TOO_HARD;
>
> diff --git a/arch/powerpc/kvm/book3s_64_vio_hv.c b/arch/powerpc/kvm/book3s_64_vio_hv.c
> index a3be4bd..8a6834e 100644
> --- a/arch/powerpc/kvm/book3s_64_vio_hv.c
> +++ b/arch/powerpc/kvm/book3s_64_vio_hv.c
> @@ -49,10 +49,9 @@
> * WARNING: This will be called in real or virtual mode on HV KVM and virtual
> * mode on PR KVM
> */
> -struct kvmppc_spapr_tce_table *kvmppc_find_table(struct kvm_vcpu *vcpu,
> +struct kvmppc_spapr_tce_table *kvmppc_find_table(struct kvm *kvm,
> unsigned long liobn)
> {
> - struct kvm *kvm = vcpu->kvm;
> struct kvmppc_spapr_tce_table *stt;
>
> list_for_each_entry_lockless(stt, &kvm->arch.spapr_tce_tables, list)
> @@ -194,12 +193,13 @@ static struct mm_iommu_table_group_mem_t *kvmppc_rm_iommu_lookup(
> long kvmppc_rm_h_put_tce(struct kvm_vcpu *vcpu, unsigned long liobn,
> unsigned long ioba, unsigned long tce)
> {
> - struct kvmppc_spapr_tce_table *stt = kvmppc_find_table(vcpu, liobn);
> + struct kvmppc_spapr_tce_table *stt;
> long ret;
>
> /* udbg_printf("H_PUT_TCE(): liobn=0x%lx ioba=0x%lx, tce=0x%lx\n", */
> /* liobn, ioba, tce); */
>
> + stt = kvmppc_find_table(vcpu->kvm, liobn);
> if (!stt)
> return H_TOO_HARD;
>
> @@ -252,7 +252,7 @@ long kvmppc_rm_h_put_tce_indirect(struct kvm_vcpu *vcpu,
> unsigned long tces, entry, ua = 0;
> unsigned long *rmap = NULL;
>
> - stt = kvmppc_find_table(vcpu, liobn);
> + stt = kvmppc_find_table(vcpu->kvm, liobn);
> if (!stt)
> return H_TOO_HARD;
>
> @@ -335,7 +335,7 @@ long kvmppc_rm_h_stuff_tce(struct kvm_vcpu *vcpu,
> struct kvmppc_spapr_tce_table *stt;
> long i, ret;
>
> - stt = kvmppc_find_table(vcpu, liobn);
> + stt = kvmppc_find_table(vcpu->kvm, liobn);
> if (!stt)
> return H_TOO_HARD;
>
> @@ -356,12 +356,13 @@ long kvmppc_rm_h_stuff_tce(struct kvm_vcpu *vcpu,
> long kvmppc_h_get_tce(struct kvm_vcpu *vcpu, unsigned long liobn,
> unsigned long ioba)
> {
> - struct kvmppc_spapr_tce_table *stt = kvmppc_find_table(vcpu, liobn);
> + struct kvmppc_spapr_tce_table *stt;
> long ret;
> unsigned long idx;
> struct page *page;
> u64 *tbl;
>
> + stt = kvmppc_find_table(vcpu->kvm, liobn);
> if (!stt)
> return H_TOO_HARD;
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-12 4:48 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 8:40 [PATCH kernel 00/15] powerpc/kvm/vfio: Enable in-kernel acceleration Alexey Kardashevskiy
2016-08-03 8:40 ` [PATCH kernel 01/15] Revert "iommu: Add a function to find an iommu group by id" Alexey Kardashevskiy
2016-08-15 4:58 ` Paul Mackerras
2016-08-03 8:40 ` [PATCH kernel 02/15] KVM: PPC: Finish enabling VFIO KVM device on POWER Alexey Kardashevskiy
2016-08-04 5:21 ` David Gibson
2016-08-03 8:40 ` [PATCH kernel 03/15] KVM: PPC: Reserve KVM_CAP_SPAPR_TCE_VFIO capability number Alexey Kardashevskiy
2016-08-03 8:40 ` [PATCH kernel 04/15] powerpc/powernv/ioda: Fix TCE invalidate to work in real mode again Alexey Kardashevskiy
2016-08-04 5:23 ` David Gibson
2016-08-09 11:26 ` [kernel, " Michael Ellerman
2016-08-03 8:40 ` [PATCH kernel 05/15] powerpc/iommu: Stop using @current in mm_iommu_xxx Alexey Kardashevskiy
2016-08-03 10:10 ` Nicholas Piggin
2016-08-05 7:00 ` Michael Ellerman
2016-08-09 5:29 ` Alexey Kardashevskiy
2016-08-09 4:43 ` Balbir Singh
2016-08-09 6:04 ` Nicholas Piggin
2016-08-09 6:17 ` Balbir Singh
2016-08-12 2:57 ` David Gibson
2016-08-12 4:56 ` Alexey Kardashevskiy
2016-08-15 10:58 ` David Gibson
2016-08-03 8:40 ` [PATCH kernel 06/15] powerpc/mm/iommu: Put pages on process exit Alexey Kardashevskiy
2016-08-03 10:11 ` Nicholas Piggin
2016-08-12 3:13 ` David Gibson
2016-08-03 8:40 ` [PATCH kernel 07/15] powerpc/iommu: Cleanup iommu_table disposal Alexey Kardashevskiy
2016-08-12 3:18 ` David Gibson
2016-08-03 8:40 ` [PATCH kernel 08/15] powerpc/vfio_spapr_tce: Add reference counting to iommu_table Alexey Kardashevskiy
2016-08-12 3:29 ` David Gibson
2016-08-03 8:40 ` [PATCH kernel 09/15] powerpc/mmu: Add real mode support for IOMMU preregistered memory Alexey Kardashevskiy
2016-08-12 4:02 ` David Gibson
2016-08-03 8:40 ` [PATCH kernel 10/15] KVM: PPC: Use preregistered memory API to access TCE list Alexey Kardashevskiy
2016-08-12 4:17 ` David Gibson
2016-08-03 8:40 ` [PATCH kernel 11/15] powerpc/powernv/iommu: Add real mode version of iommu_table_ops::exchange() Alexey Kardashevskiy
2016-08-12 4:29 ` David Gibson
2016-08-03 8:40 ` [PATCH kernel 12/15] KVM: PPC: Enable IOMMU_API for KVM_BOOK3S_64 permanently Alexey Kardashevskiy
2016-08-12 4:34 ` David Gibson
2016-08-03 8:40 ` [PATCH kernel 13/15] KVM: PPC: Pass kvm* to kvmppc_find_table() Alexey Kardashevskiy
2016-08-12 4:45 ` David Gibson [this message]
2016-08-03 8:40 ` [PATCH kernel 14/15] vfio/spapr_tce: Export container API for external users Alexey Kardashevskiy
2016-08-08 16:43 ` Alex Williamson
2016-08-09 5:19 ` Alexey Kardashevskiy
2016-08-09 12:16 ` Alex Williamson
2016-08-10 5:37 ` Alexey Kardashevskiy
2016-08-10 16:46 ` Alex Williamson
2016-08-12 5:46 ` David Gibson
2016-08-12 6:12 ` Alexey Kardashevskiy
2016-08-15 11:07 ` David Gibson
2016-08-17 8:31 ` Alexey Kardashevskiy
2016-08-12 15:22 ` Alex Williamson
2016-08-17 3:17 ` David Gibson
2016-08-18 0:22 ` Alexey Kardashevskiy
2016-08-29 6:35 ` Alexey Kardashevskiy
2016-08-29 13:27 ` David Gibson
2016-09-07 9:09 ` Alexey Kardashevskiy
2016-09-21 6:56 ` Alexey Kardashevskiy
2016-09-23 7:12 ` David Gibson
2016-10-17 6:06 ` Alexey Kardashevskiy
2016-10-18 1:42 ` David Gibson
2016-08-15 3:59 ` Paul Mackerras
2016-08-15 15:32 ` Alex Williamson
2016-08-12 5:25 ` David Gibson
2016-08-03 8:40 ` [PATCH kernel 15/15] KVM: PPC: Add in-kernel acceleration for VFIO Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812044549.GP16493@voom.fritz.box \
--to=david@gibson$(echo .)dropbear.id.au \
--cc=aik@ozlabs$(echo .)ru \
--cc=alex.williamson@redhat$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox