Subject: Re: [PATCH V2 1/5] powerpc/64/kexec: NULL check "clear_all" in kexec_sequence

From: Balbir Singh <[email-masked]>
Date: Mon, 22 Aug 2016 18:56:06 +1000

On Fri, Aug 19, 2016 at 02:22:35PM +0530, Aneesh Kumar K.V wrote:
> From: Benjamin Herrenschmidt <[email-masked]>
> 
> With Radix, it can be NULL even on !BOOKE these days so replace
> the ifdef with a NULL check which is cleaner anyway.
> 
> Signed-off-by: Benjamin Herrenschmidt <[email-masked]>
> Signed-off-by: Aneesh Kumar K.V <[email-masked]>
> ---
>  arch/powerpc/kernel/misc_64.S | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/misc_64.S b/arch/powerpc/kernel/misc_64.S
> index cb195157b318..7902f4b12d3f 100644
> --- a/arch/powerpc/kernel/misc_64.S
> +++ b/arch/powerpc/kernel/misc_64.S
> @@ -659,7 +659,9 @@ _GLOBAL(kexec_sequence)
>  	li	r6,1
>  	stw	r6,kexec_flag-1b(5)
>  
> -#ifndef CONFIG_PPC_BOOK3E
> +	cmpdi	r27,0
> +	beq	1f
> +

Having a comment inline would help as well. I presume we are not going
to tear down the page tables for radix

Acked-by: Balbir Singh <[email-masked]>
 
Balbir Singh