From: Mel Gorman <mgorman@techsingularity•net>
To: Michal Hocko <mhocko@kernel•org>
Cc: Srikar Dronamraju <srikar@linux•vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation•org>,
Linux-MM <linux-mm@kvack•org>, Rik van Riel <riel@surriel•com>,
Vlastimil Babka <vbabka@suse•cz>,
Johannes Weiner <hannes@cmpxchg•org>,
Minchan Kim <minchan@kernel•org>,
Joonsoo Kim <iamjoonsoo.kim@lge•com>,
LKML <linux-kernel@vger•kernel.org>,
Michael Ellerman <mpe@ellerman•id.au>,
linuxppc-dev@lists•ozlabs.org,
Mahesh Salgaonkar <mahesh@linux•vnet.ibm.com>,
Hari Bathini <hbathini@linux•vnet.ibm.com>
Subject: Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes
Date: Wed, 31 Aug 2016 13:46:54 +0100 [thread overview]
Message-ID: <20160831124654.GZ8119@techsingularity.net> (raw)
In-Reply-To: <20160831110932.GB21661@dhcp22.suse.cz>
On Wed, Aug 31, 2016 at 01:09:33PM +0200, Michal Hocko wrote:
> > We cannot just convert populated_zone() as many existing users really
> > need to check for present_pages. This patch introduces a managed_zone()
> > helper and uses it in the few cases where it is critical that the check
> > is made for managed pages -- zonelist constuction and page reclaim.
>
> OK, the patch makes sense to me. I am not happy about two very similar
> functions, to be honest though. managed vs. present checks will be quite
> subtle and it is not entirely clear when to use which one.
In the vast majority of cases, the distinction is irrelevant. The patch
only updates the places where it really matters to minimise any
confusion.
> Acked-by: Michal Hocko <mhocko@suse•com>
Thanks.
> /*
> * Returns true if a zone has pages managed by the buddy allocator.
> * All the reclaim decisions have to use this function rather than
> * populated_zone(). If the whole zone is reserved then we can easily
> * end up with populated_zone() && !managed_zone().
> */
>
> What do you think?
>
This makes a lot of sense. I've updated the patch and will await a test
from Srikar before reposting.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2016-08-31 12:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1467970510-21195-1-git-send-email-mgorman@techsingularity.net>
[not found] ` <1467970510-21195-8-git-send-email-mgorman@techsingularity.net>
2016-08-29 9:38 ` [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes Srikar Dronamraju
2016-08-30 12:07 ` Mel Gorman
2016-08-30 14:25 ` Srikar Dronamraju
2016-08-30 15:00 ` Mel Gorman
2016-08-31 6:09 ` Srikar Dronamraju
2016-08-31 8:49 ` Mel Gorman
2016-08-31 11:09 ` Michal Hocko
2016-08-31 12:46 ` Mel Gorman [this message]
2016-08-31 17:33 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831124654.GZ8119@techsingularity.net \
--to=mgorman@techsingularity$(echo .)net \
--cc=akpm@linux-foundation$(echo .)org \
--cc=hannes@cmpxchg$(echo .)org \
--cc=hbathini@linux$(echo .)vnet.ibm.com \
--cc=iamjoonsoo.kim@lge$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mahesh@linux$(echo .)vnet.ibm.com \
--cc=mhocko@kernel$(echo .)org \
--cc=minchan@kernel$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=riel@surriel$(echo .)com \
--cc=srikar@linux$(echo .)vnet.ibm.com \
--cc=vbabka@suse$(echo .)cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox