From: Bjorn Andersson <bjorn.andersson@linaro•org>
To: Linus Torvalds <torvalds@linux-foundation•org>
Cc: "Luis R. Rodriguez" <mcgrof@kernel•org>,
Daniel Vetter <daniel.vetter@ffwll•ch>,
Mimi Zohar <zohar@linux•vnet.ibm.com>,
Felix Fietkau <nbd@nbd•name>,
David Woodhouse <dwmw2@infradead•org>,
Roman Pen <r.peniaev@gmail•com>,
Ming Lei <ming.lei@canonical•com>,
Andrew Morton <akpm@linux-foundation•org>,
Michal Marek <mmarek@suse•com>,
Greg KH <gregkh@linuxfoundation•org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Vikram Mulukutla <markivx@codeaurora•org>,
Stephen Boyd <stephen.boyd@linaro•org>,
Mark Brown <broonie@kernel•org>, Takashi Iwai <tiwai@suse•de>,
Johannes Berg <johannes@sipsolutions•net>,
Christian Lamparter <chunkeey@googlemail•com>,
Hauke Mehrtens <hauke@hauke-m•de>,
Josh Boyer <jwboyer@fedoraproject•org>,
Dmitry Torokhov <dmitry.torokhov@gmail•com>,
Jiri Slaby <jslaby@suse•com>,
Andy Lutomirski <luto@amacapital•net>,
Wu Fengguang <fengguang.wu@intel•com>,
Richard Purdie <rpurdie@rpsys•net>, Jeff Mahoney <jeffm@suse•com>,
Jacek Anaszewski <j.anaszewski@samsung•com>,
Abhay_Salunke@dell•com, Julia Lawall <Julia.Lawall@lip6•fr>,
Gilles.Muller@lip6•fr, nicolas.palix@imag•fr,
Tom Gundersen <teg@jklm•no>, Kay Sievers <kay@vrfy•org>,
David Howells <dhowells@redhat•com>,
Alessandro Rubini <rubini@gnudd•com>,
Kevin Cernekee <cernekee@gmail•com>,
Kees Cook <keescook@chromium•org>,
Jonathan Corbet <corbet@lwn•net>,
Thierry Martinez <martinez@nsup•org>,
cocci@systeme•lip6.fr,
linux-serial <linux-serial@vger•kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger•kernel.org>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [RFC] fs: add userspace critical mounts event support
Date: Tue, 6 Sep 2016 14:11:17 -0700 [thread overview]
Message-ID: <20160906211117.GE15161@tuxbot> (raw)
In-Reply-To: <CA+55aFw01BW2_etsPJGMRY=3BXdo_+g9+c_vRCW59gRpj9GVsw@mail.gmail.com>
On Tue 06 Sep 11:32 PDT 2016, Linus Torvalds wrote:
> On Tue, Sep 6, 2016 at 10:46 AM, Bjorn Andersson
> <bjorn.andersson@linaro•org> wrote:
> >
> > Linus, I reversed the order of your questions/answers to fit my answer
> > better.
>
> Nobody has actually answered the "why don't we just tie the firmware
> and module together" question.
>
The answer to this depends on the details of the suggestion; but
generally there's a much stronger bond between the kernel and the driver
than between the driver and the firmware in my cases.
E.g. we have a single remoteproc driver loading and controlling the
Hexagon DSP found in several Qualcomm platforms, so a single kernel
binary could (practically) load hundreds of variants of the firmware.
Both the kernel binary and the firmware in this example are side-loaded
onto the device during development - independently of each other, as
they are developed by different teams (or maybe even different
companies).
I assume that you're not suggesting to actually tie the module together,
as that would be practically difficult and a waste of resources.
Which leaves us with the suggestion that we should store the kernel
module with the firmware file, which is just infeasible from a few
practical reasons - again mostly related to the development flow and how
the files are contained on the devices.
> Really. If the driver doesn't work without the firmware, then why the
> hell is it separated from it in the first place?
>
In several cases we have a single remoteproc driver controlling several
different co-processors. Further more with the aspiration of being able
to run the same kernel binary (including modules) on more than one
product this is simply not feasible.
As I said above, beyond development there are hundreds of variants of
these firmware files in products - each weighting in at 10-50MB.
The firmware loading part (remoteproc) doesn't care about these
differences and the functional drivers attaching to the services
provided by the firmware can handle the differences between them.
> The hack is a hack, and it just sounds *stupid*.
>
This I totally agree with.
Regards,
Bjorn
next prev parent reply other threads:[~2016-09-06 21:11 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1466117661-22075-1-git-send-email-mcgrof@kernel.org>
2016-06-16 22:54 ` [PATCH v2 2/5] firmware: annotate thou shalt not request fw on init or probe Luis R. Rodriguez
2016-08-24 6:55 ` Daniel Vetter
2016-08-24 20:39 ` Luis R. Rodriguez
2016-08-25 11:05 ` Daniel Vetter
2016-08-25 19:41 ` Luis R. Rodriguez
2016-08-25 20:10 ` Daniel Vetter
2016-08-25 20:25 ` Luis R. Rodriguez
2016-08-25 20:30 ` Dmitry Torokhov
2016-09-02 23:59 ` Luis R. Rodriguez
2016-09-03 0:20 ` [RFC] fs: add userspace critical mounts event support Luis R. Rodriguez
2016-09-03 4:11 ` Linus Torvalds
2016-09-03 4:20 ` Dmitry Torokhov
2016-09-03 4:41 ` Linus Torvalds
2016-09-03 17:49 ` Dmitry Torokhov
2016-09-03 18:01 ` Linus Torvalds
2016-09-03 18:10 ` Dmitry Torokhov
2016-09-06 21:52 ` Luis R. Rodriguez
2016-09-06 22:28 ` Bjorn Andersson
2016-09-06 23:14 ` Luis R. Rodriguez
2016-09-24 1:37 ` Herbert, Marc
2016-09-24 17:41 ` Dmitry Torokhov
2016-10-05 0:00 ` Luis R. Rodriguez
2016-10-05 0:12 ` Linus Torvalds
2016-10-05 0:24 ` Luis R. Rodriguez
2016-10-05 0:32 ` Linus Torvalds
2016-10-05 17:38 ` Luis R. Rodriguez
2016-10-05 1:48 ` Josh Triplett
2016-10-05 1:58 ` Linus Torvalds
2016-09-06 17:46 ` Bjorn Andersson
2016-09-06 18:32 ` Linus Torvalds
2016-09-06 21:11 ` Bjorn Andersson [this message]
2016-09-06 21:50 ` Linus Torvalds
2016-09-06 23:04 ` Luis R. Rodriguez
2016-09-06 22:32 ` Luis R. Rodriguez
2016-09-14 2:38 ` Rob Landley
2016-10-05 18:00 ` Luis R. Rodriguez
2016-10-05 18:08 ` Linus Torvalds
2016-10-05 19:46 ` Luis R. Rodriguez
2016-11-08 22:47 ` Luis R. Rodriguez
2016-11-09 9:13 ` Daniel Wagner
2016-11-09 11:21 ` Andy Lutomirski
2016-11-09 23:53 ` Luis R. Rodriguez
2016-11-29 21:54 ` Luis R. Rodriguez
2016-11-09 23:40 ` Luis R. Rodriguez
2016-11-15 9:28 ` Johannes Berg
2016-11-29 21:10 ` Tom Gundersen
2016-11-29 21:37 ` Luis R. Rodriguez
2016-11-30 8:18 ` Johannes Berg
[not found] ` <1471999507-913-1-git-send-email-mcgrof@kernel.org>
2016-08-24 0:45 ` [PATCH v3 2/5] firmware: annotate thou shalt not request fw on init or probe mcgrof
2016-08-24 8:17 ` Gabriel Paubert
2016-09-02 18:26 ` Luis R. Rodriguez
[not found] ` <1473208930-6835-1-git-send-email-mcgrof@kernel.org>
2016-09-07 0:42 ` [PATCH v4 " Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906211117.GE15161@tuxbot \
--to=bjorn.andersson@linaro$(echo .)org \
--cc=Abhay_Salunke@dell$(echo .)com \
--cc=Gilles.Muller@lip6$(echo .)fr \
--cc=Julia.Lawall@lip6$(echo .)fr \
--cc=akpm@linux-foundation$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=cernekee@gmail$(echo .)com \
--cc=chunkeey@googlemail$(echo .)com \
--cc=cocci@systeme$(echo .)lip6.fr \
--cc=corbet@lwn$(echo .)net \
--cc=daniel.vetter@ffwll$(echo .)ch \
--cc=dhowells@redhat$(echo .)com \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=dwmw2@infradead$(echo .)org \
--cc=fengguang.wu@intel$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hauke@hauke-m$(echo .)de \
--cc=j.anaszewski@samsung$(echo .)com \
--cc=jeffm@suse$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=jslaby@suse$(echo .)com \
--cc=jwboyer@fedoraproject$(echo .)org \
--cc=kay@vrfy$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=luto@amacapital$(echo .)net \
--cc=markivx@codeaurora$(echo .)org \
--cc=martinez@nsup$(echo .)org \
--cc=mcgrof@kernel$(echo .)org \
--cc=ming.lei@canonical$(echo .)com \
--cc=mmarek@suse$(echo .)com \
--cc=nbd@nbd$(echo .)name \
--cc=nicolas.palix@imag$(echo .)fr \
--cc=r.peniaev@gmail$(echo .)com \
--cc=rpurdie@rpsys$(echo .)net \
--cc=rubini@gnudd$(echo .)com \
--cc=stephen.boyd@linaro$(echo .)org \
--cc=teg@jklm$(echo .)no \
--cc=tiwai@suse$(echo .)de \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=zohar@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox