From: Arnaldo Carvalho de Melo <acme@kernel•org>
To: Ravi Bangoria <ravi.bangoria@linux•vnet.ibm.com>
Cc: linux-kernel@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
peterz@infradead•org, mingo@redhat•com,
alexander.shishkin@linux•intel.com, treeze.taeung@gmail•com,
naveen.n.rao@linux•vnet.ibm.com, markus@trippelsdorf•de,
chris.ryder@arm•com, pawel.moll@arm•com, mhiramat@kernel•org,
rmk+kernel@arm•linux.org.uk, jolsa@kernel•org,
mpe@ellerman•id.au, hemant@linux•vnet.ibm.com,
namhyung@kernel•org
Subject: Re: [PATCH v6 3/7] perf annotate: Add support for powerpc
Date: Mon, 19 Sep 2016 12:26:02 -0300 [thread overview]
Message-ID: <20160919152602.GB4840@kernel.org> (raw)
In-Reply-To: <1471611578-11255-4-git-send-email-ravi.bangoria@linux.vnet.ibm.com>
Em Fri, Aug 19, 2016 at 06:29:34PM +0530, Ravi Bangoria escreveu:
> From: "Naveen N. Rao" <naveen.n.rao@linux•vnet.ibm.com>
>
> +static struct ins *ins__find_powerpc(const char *name)
> +{
> + int i;
> + struct ins *ins;
> + struct ins_ops *ops;
> + static struct instructions_powerpc head;
> + static bool list_initialized;
> +
> + /*
> + * - Interested only if instruction starts with 'b'.
> + * - Few start with 'b', but aren't branch instructions.
> + */
> + if (name[0] != 'b' ||
> + !strncmp(name, "bcd", 3) ||
> + !strncmp(name, "brinc", 5) ||
> + !strncmp(name, "bper", 4))
> + return NULL;
> +
> + if (!list_initialized) {
> + INIT_LIST_HEAD(&head.list);
> + list_initialized = true;
> + }
Why not ditch list_initialized and instead just declare the list as:
static struct instructions_powerpc head = {
.list = LIST_HEAD_INIT(head.list),
}
Just like the kernel sources do? See for instance:
net/core/net_namespace.c
struct net init_net = {
.dev_base_head = LIST_HEAD_INIT(init_net.dev_base_head),
};
> +
> + /*
> + * Return if we already have object of 'struct ins' for this instruction
> + */
> + ins = list_search__ins_powerpc(&head, name);
> + if (ins)
> + return ins;
> +
> + ops = &jump_ops;
> +
> + i = strlen(name) - 1;
> + if (i < 0)
> + return NULL;
> +
> + /* ignore optional hints at the end of the instructions */
> + if (name[i] == '+' || name[i] == '-')
> + i--;
> +
> + if (name[i] == 'l' || (name[i] == 'a' && name[i-1] == 'l')) {
> + /*
> + * if the instruction ends up with 'l' or 'la', then
> + * those are considered 'calls' since they update LR.
> + * ... except for 'bnl' which is branch if not less than
> + * and the absolute form of the same.
> + */
> + if (strcmp(name, "bnl") && strcmp(name, "bnl+") &&
> + strcmp(name, "bnl-") && strcmp(name, "bnla") &&
> + strcmp(name, "bnla+") && strcmp(name, "bnla-"))
> + ops = &call_ops;
> + }
> + if (name[i] == 'r' && name[i-1] == 'l')
> + /*
> + * instructions ending with 'lr' are considered to be
> + * return instructions
> + */
> + ops = &ret_ops;
> +
> + /*
> + * Add instruction to list so next time no need to
> + * allocate memory for it.
> + */
> + return list_add__ins_powerpc(&head, name, ops);
> +}
> +
> static void ins__sort(struct ins *instructions, int nmemb)
> {
> qsort(instructions, nmemb, sizeof(struct ins), ins__cmp);
> @@ -585,6 +699,8 @@ static struct ins *ins__find(const char *name, const char *norm_arch)
> } else if (!strcmp(norm_arch, NORM_ARM)) {
> instructions = instructions_arm;
> nmemb = ARRAY_SIZE(instructions_arm);
> + } else if (!strcmp(norm_arch, NORM_POWERPC)) {
> + return ins__find_powerpc(name);
> } else {
> pr_err("perf annotate not supported by %s arch\n", norm_arch);
> return NULL;
> --
> 2.5.5
next prev parent reply other threads:[~2016-09-19 15:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 12:59 [PATCH v6 0/7] perf: Cross arch annotate + few miscellaneous fixes Ravi Bangoria
2016-08-19 12:59 ` [PATCH v6 1/7] perf: Define macro for normalized arch names Ravi Bangoria
2016-08-19 12:59 ` [PATCH v6 2/7] perf annotate: Add cross arch annotate support Ravi Bangoria
2016-08-22 23:01 ` Kim Phillips
2016-08-23 2:17 ` Namhyung Kim
2016-08-23 20:36 ` Kim Phillips
2016-08-26 6:21 ` Namhyung Kim
2016-08-26 7:26 ` Ravi Bangoria
2016-08-27 0:40 ` [PATCH] perf annotate: cross arch annotate support fixes for ARM Kim Phillips
2016-08-19 12:59 ` [PATCH v6 3/7] perf annotate: Add support for powerpc Ravi Bangoria
2016-09-19 15:26 ` Arnaldo Carvalho de Melo [this message]
2016-08-19 12:59 ` [PATCH v6 4/7] perf annotate: Do not ignore call instruction with indirect target Ravi Bangoria
2016-09-19 15:44 ` Arnaldo Carvalho de Melo
2016-09-20 14:35 ` Ravi Bangoria
2016-09-20 14:56 ` Arnaldo Carvalho de Melo
2016-08-19 12:59 ` [PATCH v6 5/7] perf annotate: Show raw form for jump " Ravi Bangoria
2016-08-19 12:59 ` [PATCH v6 6/7] perf annotate: Support jump instruction with target as second operand Ravi Bangoria
2016-08-19 12:59 ` [PATCH v6 7/7] perf annotate: Fix jump target outside of function address range Ravi Bangoria
2016-09-07 15:39 ` [PATCH v6 0/7] perf: Cross arch annotate + few miscellaneous fixes Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919152602.GB4840@kernel.org \
--to=acme@kernel$(echo .)org \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=chris.ryder@arm$(echo .)com \
--cc=hemant@linux$(echo .)vnet.ibm.com \
--cc=jolsa@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=markus@trippelsdorf$(echo .)de \
--cc=mhiramat@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=namhyung@kernel$(echo .)org \
--cc=naveen.n.rao@linux$(echo .)vnet.ibm.com \
--cc=pawel.moll@arm$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=ravi.bangoria@linux$(echo .)vnet.ibm.com \
--cc=rmk+kernel@arm$(echo .)linux.org.uk \
--cc=treeze.taeung@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox