From: Peter Zijlstra <peterz@infradead•org>
To: Christian Borntraeger <borntraeger@de•ibm.com>
Cc: Pan Xinhui <xinhui.pan@linux•vnet.ibm.com>,
linux-kernel@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
virtualization@lists•linux-foundation.org,
linux-s390@vger•kernel.org,
xen-devel-request@lists•xenproject.org, kvm@vger•kernel.org,
benh@kernel•crashing.org, paulus@samba•org, mpe@ellerman•id.au,
mingo@redhat•com, paulmck@linux•vnet.ibm.com,
will.deacon@arm•com, kernellwp@gmail•com, jgross@suse•com,
pbonzini@redhat•com, bsingharora@gmail•com,
Heiko Carstens <heiko.carstens@de•ibm.com>
Subject: Re: [PATCH v3 0/4] implement vcpu preempted check
Date: Thu, 29 Sep 2016 12:31:33 +0200 [thread overview]
Message-ID: <20160929103133.GW5016@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <166f3bad-f700-4624-6c1c-996f90ad609c@de.ibm.com>
On Thu, Sep 29, 2016 at 12:23:19PM +0200, Christian Borntraeger wrote:
> On 09/29/2016 12:10 PM, Peter Zijlstra wrote:
> > On Thu, Jul 21, 2016 at 07:45:10AM -0400, Pan Xinhui wrote:
> >> change from v2:
> >> no code change, fix typos, update some comments
> >>
> >> change from v1:
> >> a simplier definition of default vcpu_is_preempted
> >> skip mahcine type check on ppc, and add config. remove dedicated macro.
> >> add one patch to drop overload of rwsem_spin_on_owner and mutex_spin_on_owner.
> >> add more comments
> >> thanks boqun and Peter's suggestion.
> >>
> >> This patch set aims to fix lock holder preemption issues.
> >
> > So I really like the concept, but I would also really like to see
> > support for more hypervisors included before we can move forward with
> > this.
> >
> > Please consider s390 and (x86/arm) KVM. Once we have a few, more can
> > follow later, but I think its important to not only have PPC support for
> > this.
>
> Actually the s390 preemted check via sigp sense running is available for
> all hypervisors (z/VM, LPAR and KVM) which implies everywhere as you can no
> longer buy s390 systems without LPAR.
>
> As Heiko already pointed out we could simply use a small inline function
> that calls cpu_is_preempted from arch/s390/lib/spinlock (or smp_vcpu_scheduled from smp.c)
Sure, and I had vague memories of Heiko's email. This patch set however
completely fails to do that trivial hooking up.
next prev parent reply other threads:[~2016-09-29 10:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 11:45 [PATCH v3 0/4] implement vcpu preempted check Pan Xinhui
2016-07-21 11:45 ` [PATCH v3 1/4] kernel/sched: introduce vcpu preempted check interface Pan Xinhui
2016-07-21 11:45 ` [PATCH v3 2/4] powerpc/spinlock: support vcpu preempted check Pan Xinhui
2016-07-21 11:45 ` [PATCH v3 3/4] locking/osq: Drop the overhead of osq_lock() Pan Xinhui
2016-07-21 11:45 ` [PATCH v3 4/4] kernel/locking: Drop the overhead of {mutex, rwsem}_spin_on_owner Pan Xinhui
2016-09-29 10:10 ` [PATCH v3 0/4] implement vcpu preempted check Peter Zijlstra
2016-09-29 10:23 ` Christian Borntraeger
2016-09-29 10:31 ` Peter Zijlstra [this message]
2016-09-30 5:03 ` Pan Xinhui
2016-09-30 6:58 ` Paolo Bonzini
2016-09-30 8:52 ` Pan Xinhui
2016-09-30 9:08 ` Paolo Bonzini
2016-09-30 9:31 ` Pan Xinhui
2016-09-30 10:44 ` Christian Borntraeger
2016-09-29 10:40 ` Christian Borntraeger
2016-09-29 11:05 ` Christian Borntraeger
2016-09-30 4:00 ` Pan Xinhui
2016-10-05 11:00 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929103133.GW5016@twins.programming.kicks-ass.net \
--to=peterz@infradead$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=bsingharora@gmail$(echo .)com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=jgross@suse$(echo .)com \
--cc=kernellwp@gmail$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulmck@linux$(echo .)vnet.ibm.com \
--cc=paulus@samba$(echo .)org \
--cc=pbonzini@redhat$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=will.deacon@arm$(echo .)com \
--cc=xen-devel-request@lists$(echo .)xenproject.org \
--cc=xinhui.pan@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox