From: Jason Gunthorpe <jgunthorpe@obsidianresearch•com>
To: Kees Cook <keescook@chromium•org>
Cc: Michael Ellerman <mpe@ellerman•id.au>,
Andrew Morton <akpm@linux-foundation•org>,
Denys Vlasenko <dvlasenk@redhat•com>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>,
Oleg Nesterov <oleg@redhat•com>,
Florian Weimer <fweimer@redhat•com>,
Linux-MM <linux-mm@kvack•org>,
LKML <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH v6] powerpc: Do not make the entire heap executable
Date: Thu, 20 Oct 2016 16:45:21 -0600 [thread overview]
Message-ID: <20161020224521.GA24970@obsidianresearch.com> (raw)
In-Reply-To: <CAGXu5jJ3PpvNBYyBWa_M8ELLPuJOcJt-KuH0uRK66peJM_CnSg@mail.gmail.com>
On Tue, Oct 04, 2016 at 09:54:12AM -0700, Kees Cook wrote:
> On Mon, Oct 3, 2016 at 5:18 PM, Michael Ellerman <mpe@ellerman•id.au> wrote:
> > Kees Cook <keescook@chromium•org> writes:
> >
> >> On Mon, Oct 3, 2016 at 9:13 AM, Denys Vlasenko <dvlasenk@redhat•com> wrote:
> >>> On 32-bit powerpc the ELF PLT sections of binaries (built with --bss-plt,
> >>> or with a toolchain which defaults to it) look like this:
> > ...
> >>>
> >>> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch•com>
> >>> Signed-off-by: Denys Vlasenko <dvlasenk@redhat•com>
> >>> Acked-by: Kees Cook <keescook@chromium•org>
> >>> Acked-by: Michael Ellerman <mpe@ellerman•id.au>
> >>> CC: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> >>> CC: Paul Mackerras <paulus@samba•org>
> >>> CC: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>
> >>> CC: Kees Cook <keescook@chromium•org>
> >>> CC: Oleg Nesterov <oleg@redhat•com>
> >>> CC: Michael Ellerman <mpe@ellerman•id.au>
> >>> CC: Florian Weimer <fweimer@redhat•com>
> >>> CC: linux-mm@kvack•org
> >>> CC: linuxppc-dev@lists•ozlabs.org
> >>> CC: linux-kernel@vger•kernel.org
> >>> Changes since v5:
> >>> * made do_brk_flags() error out if any bits other than VM_EXEC are set.
> >>> (Kees Cook: "With this, I'd be happy to Ack.")
> >>> See https://patchwork.ozlabs.org/patch/661595/
> >>
> >> Excellent, thanks for the v6! Should this go via the ppc tree or the -mm tree?
> >
> > -mm would be best, given the diffstat I think it's less likely to
> > conflict if it goes via -mm.
>
> Okay, excellent. Andrew, do you have this already in email? I think
> you weren't on the explicit CC from the v6...
FWIW (and ping),
Tested-by: Jason Gunthorpe <jgunthorpe@obsidianresearch•com>
On ARM32 (kirkwood) and PPC32 (405)
For reference, here is the patchwork URL:
https://patchwork.ozlabs.org/patch/677753/
Jason
next prev parent reply other threads:[~2016-10-20 22:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 16:13 [PATCH v6] powerpc: Do not make the entire heap executable Denys Vlasenko
2016-10-03 21:51 ` Kees Cook
2016-10-04 0:18 ` Michael Ellerman
2016-10-04 16:54 ` Kees Cook
2016-10-20 22:45 ` Jason Gunthorpe [this message]
2016-10-24 23:17 ` Kees Cook
2016-11-04 22:03 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020224521.GA24970@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=dvlasenk@redhat$(echo .)com \
--cc=fweimer@redhat$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=oleg@redhat$(echo .)com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox