From: Arnaldo Carvalho de Melo <acme@kernel•org>
To: Ravi Bangoria <ravi.bangoria@linux•vnet.ibm.com>
Cc: peterz@infradead•org, mingo@redhat•com,
alexander.shishkin@linux•intel.com, chris.ryder@arm•com,
mhiramat@kernel•org, kim.phillips@arm•com,
treeze.taeung@gmail•com, markus@trippelsdorf•de,
naveen.n.rao@linux•vnet.ibm.com, linux-kernel@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v8 2/3] perf annotate: Support jump instruction with target as second operand
Date: Tue, 13 Dec 2016 13:23:01 -0300 [thread overview]
Message-ID: <20161213162301.GM5482@kernel.org> (raw)
In-Reply-To: <1480953407-7605-2-git-send-email-ravi.bangoria@linux.vnet.ibm.com>
Em Mon, Dec 05, 2016 at 09:26:46PM +0530, Ravi Bangoria escreveu:
> +++ b/tools/perf/util/annotate.c
> @@ -223,8 +223,12 @@ bool ins__is_call(const struct ins *ins)
> static int jump__parse(struct arch *arch __maybe_unused, struct ins_operands *ops, struct map *map __maybe_unused)
> {
> const char *s = strchr(ops->raw, '+');
> + const char *c = strchr(ops->raw, ',');
>
> - ops->target.addr = strtoull(ops->raw, NULL, 16);
> + if (c++ != NULL)
> + ops->target.addr = strtoull(c, NULL, 16);
> + else
> + ops->target.addr = strtoull(ops->raw, NULL, 16);
>
> if (s++ != NULL)
> ops->target.offset = strtoull(s, NULL, 16);
Simple enough, applied.
- Arnaldo
next prev parent reply other threads:[~2016-12-13 16:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 15:56 [PATCH v8 1/3] perf annotate: Show raw form for jump instruction with indirect target Ravi Bangoria
2016-12-05 15:56 ` [PATCH v8 2/3] perf annotate: Support jump instruction with target as second operand Ravi Bangoria
2016-12-06 6:08 ` Ravi Bangoria
2016-12-13 16:23 ` Arnaldo Carvalho de Melo [this message]
2016-12-05 15:56 ` [PATCH v8 3/3] perf annotate: Fix jump target outside of function address range Ravi Bangoria
2016-12-13 16:27 ` Arnaldo Carvalho de Melo
2016-12-05 19:22 ` [PATCH v8 1/3] perf annotate: Show raw form for jump instruction with indirect target Arnaldo Carvalho de Melo
2016-12-05 20:21 ` Arnaldo Carvalho de Melo
2016-12-05 20:31 ` Arnaldo Carvalho de Melo
2016-12-13 16:15 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213162301.GM5482@kernel.org \
--to=acme@kernel$(echo .)org \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=chris.ryder@arm$(echo .)com \
--cc=kim.phillips@arm$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=markus@trippelsdorf$(echo .)de \
--cc=mhiramat@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=naveen.n.rao@linux$(echo .)vnet.ibm.com \
--cc=peterz@infradead$(echo .)org \
--cc=ravi.bangoria@linux$(echo .)vnet.ibm.com \
--cc=treeze.taeung@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox