From: Gautham R Shenoy <ego@linux•vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman•id.au>
Cc: "Rafael J. Wysocki" <rafael@kernel•org>,
"Gautham R. Shenoy" <ego@linux•vnet.ibm.com>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
"Rafael J. Wysocki" <rjw@rjwysocki•net>,
Daniel Lezcano <daniel.lezcano@linaro•org>,
Michael Neuling <mikey@neuling•org>,
Vaidyanathan Srinivasan <svaidy@linux•vnet.ibm.com>,
"Shreyas B. Prabhu" <shreyasbp@gmail•com>,
Shilpasri G Bhat <shilpa.bhat@linux•vnet.ibm.com>,
Stewart Smith <stewart@linux•vnet.ibm.com>,
Balbir Singh <bsingharora@gmail•com>,
"Oliver O'Halloran" <oohall@gmail•com>,
Rob Herring <robh+dt@kernel•org>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux PM <linux-pm@vger•kernel.org>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
Mark Rutland <mark.rutland@arm•com>
Subject: Re: [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate powernv idle states.
Date: Mon, 30 Jan 2017 17:11:05 +0530 [thread overview]
Message-ID: <20170130114105.GA4290@in.ibm.com> (raw)
In-Reply-To: <87efzkx0dd.fsf@concordia.ellerman.id.au>
On Mon, Jan 30, 2017 at 10:17:50PM +1100, Michael Ellerman wrote:
> "Rafael J. Wysocki" <rafael@kernel•org> writes:
>
> > On Mon, Jan 30, 2017 at 4:47 AM, Michael Ellerman <mpe@ellerman•id.au> wrote:
> >> "Gautham R. Shenoy" <ego@linux•vnet.ibm.com> writes:
> >>
> >>> From: "Gautham R. Shenoy" <ego@linux•vnet.ibm.com>
> >>>
> >>> In the current code for powernv_add_idle_states, there is a lot of code
> >>> duplication while initializing an idle state in powernv_states table.
> >>>
> >>> Add an inline helper function to populate the powernv_states[] table
> >>> for a given idle state. Invoke this for populating the "Nap",
> >>> "Fastsleep" and the stop states in powernv_add_idle_states.
> >>>
> >>> Acked-by: Balbir Singh <bsingharora@gmail•com>
> >>> Signed-off-by: Gautham R. Shenoy <ego@linux•vnet.ibm.com>
> >>> ---
> >>> drivers/cpuidle/cpuidle-powernv.c | 89 +++++++++++++++++++++++----------------
> >>> include/linux/cpuidle.h | 1 +
> >>
> >> I was going to merge this, but I see you've touched cpuidle.h, so I feel
> >> like I should get an ACK from the cpuidle folks.
> >>
> >> It's a fairly uncontroversial change, but it's their API.
> >
> > OK, please add an ACK from me to it then.
>
> Thanks.
Thanks Rafael and Michal.
>
> cheers
>
--
Thanks and Regards
gautham.
next prev parent reply other threads:[~2017-01-30 11:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 8:36 [PATCH v6 0/5] powernv:stop: Use psscr_val,mask provided by firmware Gautham R. Shenoy
2017-01-25 8:36 ` [PATCH v6 1/5] powernv:idle: Add IDLE_STATE_ENTER_SEQ_NORET macro Gautham R. Shenoy
2017-02-01 1:05 ` [v6,1/5] " Michael Ellerman
2017-01-25 8:36 ` [PATCH v6 2/5] powernv:stop: Rename pnv_arch300_idle_init to pnv_power9_idle_init Gautham R. Shenoy
2017-01-25 8:36 ` [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate powernv idle states Gautham R. Shenoy
2017-01-30 3:47 ` Michael Ellerman
2017-01-30 7:12 ` Rafael J. Wysocki
2017-01-30 11:17 ` Michael Ellerman
2017-01-30 11:41 ` Gautham R Shenoy [this message]
2017-01-25 8:36 ` [PATCH v6 4/5] powernv: Pass PSSCR value and mask to power9_idle_stop Gautham R. Shenoy
2017-01-25 8:36 ` [PATCH v6 5/5] Documentation:powerpc: Add device-tree bindings for power-mgt Gautham R. Shenoy
2017-01-30 17:49 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130114105.GA4290@in.ibm.com \
--to=ego@linux$(echo .)vnet.ibm.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bsingharora@gmail$(echo .)com \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mikey@neuling$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=oohall@gmail$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=rafael@kernel$(echo .)org \
--cc=rjw@rjwysocki$(echo .)net \
--cc=robh+dt@kernel$(echo .)org \
--cc=shilpa.bhat@linux$(echo .)vnet.ibm.com \
--cc=shreyasbp@gmail$(echo .)com \
--cc=stewart@linux$(echo .)vnet.ibm.com \
--cc=svaidy@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox