From: Dan Carpenter <dan.carpenter@oracle•com>
To: benh@kernel•crashing.org
Cc: linuxppc-dev@lists•ozlabs.org
Subject: [bug report] powerpc/xive: Native exploitation of the XIVE interrupt controller
Date: Thu, 20 Apr 2017 04:20:31 +0300 [thread overview]
Message-ID: <20170420012031.k4vx75eqrm2aborg@mwanda> (raw)
Hello Benjamin Herrenschmidt,
The patch 243e25112d06: "powerpc/xive: Native exploitation of the
XIVE interrupt controller" from Apr 5, 2017, leads to the following
static checker warning:
arch/powerpc/sysdev/xive/native.c:184 __xive_native_disable_queue()
info: ignoring unreachable code.
arch/powerpc/sysdev/xive/native.c
176 static void __xive_native_disable_queue(u32 vp_id, struct xive_q *q, u8 prio)
177 {
178 s64 rc;
179
180 /* Disable the queue in HW */
181 for (;;) {
182 rc = opal_xive_set_queue_info(vp_id, prio, 0, 0, 0);
183 break;
This should be "if (!rc) break;"
184 msleep(1);
185 }
186 if (rc)
But we need some kind of timeout to ever print this error message.
187 pr_err("Error %lld disabling queue for prio %d\n", rc, prio);
188 }
regards,
dan carpenter
next reply other threads:[~2017-04-20 1:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 1:20 Dan Carpenter [this message]
2017-04-20 1:28 ` [bug report] powerpc/xive: Native exploitation of the XIVE interrupt controller Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420012031.k4vx75eqrm2aborg@mwanda \
--to=dan.carpenter@oracle$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox