From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: Michael Ellerman <mpe@ellerman•id.au>
Cc: linux-kernel@vger•kernel.org,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Vineet Gupta <vgupta@synopsys•com>,
Bart Van Assche <bart.vanassche@sandisk•com>,
Robin Murphy <robin.murphy@arm•com>,
Joerg Roedel <jroedel@suse•de>, Johan Hovold <johan@kernel•org>,
Alexey Kardashevskiy <aik@ozlabs•ru>,
Krzysztof Kozlowski <krzk@kernel•org>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 11/16] powerpc: vio_cmo: use dev_groups and not dev_attrs for bus_type
Date: Fri, 9 Jun 2017 07:44:02 +0200 [thread overview]
Message-ID: <20170609054402.GA12563@kroah.com> (raw)
In-Reply-To: <87r2yuhz19.fsf@concordia.ellerman.id.au>
On Fri, Jun 09, 2017 at 08:53:22AM +1000, Michael Ellerman wrote:
> Greg Kroah-Hartman <gregkh@linuxfoundation•org> writes:
>
> > On Thu, Jun 08, 2017 at 11:12:10PM +1000, Michael Ellerman wrote:
> >> Greg Kroah-Hartman <gregkh@linuxfoundation•org> writes:
> >>
> >> > The dev_attrs field has long been "depreciated" and is finally being
> >> > removed, so move the driver to use the "correct" dev_groups field
> >> > instead for struct bus_type.
> >> >
> >> > Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> >> > Cc: Paul Mackerras <paulus@samba•org>
> >> > Cc: Michael Ellerman <mpe@ellerman•id.au>
> >> > Cc: Vineet Gupta <vgupta@synopsys•com>
> >> > Cc: Bart Van Assche <bart.vanassche@sandisk•com>
> >> > Cc: Robin Murphy <robin.murphy@arm•com>
> >> > Cc: Joerg Roedel <jroedel@suse•de>
> >> > Cc: Johan Hovold <johan@kernel•org>
> >> > Cc: Alexey Kardashevskiy <aik@ozlabs•ru>
> >> > Cc: Krzysztof Kozlowski <krzk@kernel•org>
> >> > Cc: <linuxppc-dev@lists•ozlabs.org>
> >> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
> >> > ---
> >> > arch/powerpc/platforms/pseries/vio.c | 37 +++++++++++++++++++++---------------
> >> > 1 file changed, 22 insertions(+), 15 deletions(-)
> >>
> >> This one needed a bit more work to get building, the incremental diff is
> >> below. We need a forward declaration of name, devspec and modalias,
> >> which is a bit weird, but that's how the code is currently structured.
> >> And there's dev and bus attributes with the same name, so that needed an
> >> added "bus".
> >>
> >> I booted v2 of patch 10 and this one and everything looks identical to
> >> upstream.
> >
> > Ah, many thanks, this was on my todo list to fix up today.
> >
> > But you renamed the sysfs files when you added "bus" to the function
> > names, are you sure you want to do that? I don't mind, but if you
> > happen to have userspace tools that look at those files, they just broke
> > :(
>
> Ugh crap, no that won't work.
>
> I didn't see it when I tested because my machine doesn't have the CMO
> feature enabled.
>
> I guess we have to open code some of the BUS_ATTR_RO() etc. so we can
> avoid the name clash.
Or split it into multiple files, I've solved this that way in the past.
You shouldn't have to "open code" BUS_ATTR_RO().
thanks,
greg k-h
next prev parent reply other threads:[~2017-06-09 5:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170606192221.1617-1-gregkh@linuxfoundation.org>
2017-06-06 19:22 ` [PATCH 07/16] macintosh: use dev_groups and not dev_attrs for bus_type Greg Kroah-Hartman
2017-06-06 19:22 ` [PATCH 08/16] powerpc: ps3: " Greg Kroah-Hartman
2017-06-06 21:33 ` Geoff Levand
2017-06-07 10:17 ` Greg Kroah-Hartman
2017-06-06 19:22 ` [PATCH 09/16] powerpc: ibmebus: " Greg Kroah-Hartman
2017-06-06 19:22 ` [PATCH 10/16] powerpc: vio: " Greg Kroah-Hartman
2017-06-06 19:30 ` Greg Kroah-Hartman
2017-06-06 23:04 ` Benjamin Herrenschmidt
2017-06-07 5:45 ` Greg Kroah-Hartman
2017-06-07 5:56 ` Benjamin Herrenschmidt
2017-06-07 8:58 ` [PATCH 10/16 v2] " Greg Kroah-Hartman
2017-06-06 19:22 ` [PATCH 11/16] powerpc: vio_cmo: " Greg Kroah-Hartman
2017-06-08 13:12 ` Michael Ellerman
2017-06-08 13:39 ` Greg Kroah-Hartman
2017-06-08 22:53 ` Michael Ellerman
2017-06-09 5:44 ` Greg Kroah-Hartman [this message]
2017-06-09 11:23 ` Michael Ellerman
2017-06-10 12:48 ` Greg Kroah-Hartman
2017-06-12 6:58 ` Greg Kroah-Hartman
2017-06-13 10:09 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609054402.GA12563@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=aik@ozlabs$(echo .)ru \
--cc=bart.vanassche@sandisk$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=johan@kernel$(echo .)org \
--cc=jroedel@suse$(echo .)de \
--cc=krzk@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
--cc=robin.murphy@arm$(echo .)com \
--cc=vgupta@synopsys$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox