From: Darren Hart <dvhart@infradead•org>
To: Jiri Slaby <jslaby@suse•cz>
Cc: tglx@linutronix•de, mingo@redhat•com, peterz@infradead•org,
linux-kernel@vger•kernel.org, Richard Henderson <rth@twiddle•net>,
Ivan Kokshaysky <ink@jurassic•park.msu.ru>,
Matt Turner <mattst88@gmail•com>,
Vineet Gupta <vgupta@synopsys•com>,
Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will.deacon@arm•com>,
Richard Kuo <rkuo@codeaurora•org>,
Tony Luck <tony.luck@intel•com>,
Fenghua Yu <fenghua.yu@intel•com>,
Michal Simek <monstr@monstr•eu>,
Ralf Baechle <ralf@linux-mips•org>,
Jonas Bonn <jonas@southpole•se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti•fi>,
Stafford Horne <shorne@gmail•com>,
"James E.J. Bottomley" <jejb@parisc-linux•org>,
Helge Deller <deller@gmx•de>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Martin Schwidefsky <schwidefsky@de•ibm.com>,
Yoshinori Sato <ysato@users•sourceforge.jp>,
Rich Felker <dalias@libc•org>,
"David S. Miller" <davem@davemloft•net>,
"H. Peter Anvin" <hpa@zytor•com>, Chris Zankel <chris@zankel•net>,
Max Filippov <jcmvbkbc@gmail•com>, Arnd Bergmann <arnd@arndb•de>,
x86@kernel•org, linux-alpha@vger•kernel.org,
linux-snps-arc@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
linux-hexagon@vger•kernel.org, linux-ia64@vger•kernel.org,
linux-mips@linux-mips•org, openrisc@lists•librecores.org,
linux-parisc@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-s390@vger•kernel.org, linux-sh@vger•kernel.org,
sparclinux@vger•kernel.org, linux-xtensa@linux-xtensa•org,
linux-arch@vger•kernel.org
Subject: Re: [PATCH 1/1] futex: remove duplicated code and fix UB
Date: Wed, 21 Jun 2017 20:53:37 -0700 [thread overview]
Message-ID: <20170622035337.GF25900@fury> (raw)
In-Reply-To: <20170621115318.2781-1-jslaby@suse.cz>
On Wed, Jun 21, 2017 at 01:53:18PM +0200, Jiri Slaby wrote:
> There is code duplicated over all architecture's headers for
> futex_atomic_op_inuser. Namely op decoding, access_ok check for uaddr,
> and comparison of the result.
>
> Remove this duplication and leave up to the arches only the needed
> assembly which is now in arch_futex_atomic_op_inuser.
>
> This effectively distributes the Will Deacon's arm64 fix for undefined
> behaviour reported by UBSAN to all architectures. The fix was done in
> commit 5f16a046f8e1 (arm64: futex: Fix undefined behaviour with
> FUTEX_OP_OPARG_SHIFT usage). Look there for an example dump.
>
> Note that s390 removed access_ok check in d12a29703 ("s390/uaccess:
> remove pointless access_ok() checks") as access_ok there returns true.
> We introduce it back to the helper for the sake of simplicity (it gets
> optimized away anyway).
>
This required a minor manual merge for ARM on the tip of Linus' tree today. The
reduced duplication is a welcome improvement.
Reviewed-by: Darren Hart (VMware) <dvhart@infradead•org>
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-06-22 3:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 11:53 [PATCH 1/1] futex: remove duplicated code and fix UB Jiri Slaby
2017-06-22 3:53 ` Darren Hart [this message]
2017-06-23 7:51 ` Thomas Gleixner
2017-06-26 12:02 ` Jiri Slaby
2017-06-26 12:08 ` Will Deacon
2017-07-03 10:18 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622035337.GF25900@fury \
--to=dvhart@infradead$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chris@zankel$(echo .)net \
--cc=dalias@libc$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=fenghua.yu@intel$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=jejb@parisc-linux$(echo .)org \
--cc=jonas@southpole$(echo .)se \
--cc=jslaby@suse$(echo .)cz \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mattst88@gmail$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=openrisc@lists$(echo .)librecores.org \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=rkuo@codeaurora$(echo .)org \
--cc=rth@twiddle$(echo .)net \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=shorne@gmail$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=stefan.kristiansson@saunalahti$(echo .)fi \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=vgupta@synopsys$(echo .)com \
--cc=will.deacon@arm$(echo .)com \
--cc=x86@kernel$(echo .)org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox