* [PATCH] cpufreq: Convert to using %pOF instead of full_name
@ 2017-07-18 21:42 Rob Herring
2017-07-19 6:38 ` Viresh Kumar
2017-07-19 7:06 ` Patrice CHOTARD
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2017-07-18 21:42 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: linux-kernel, devicetree, Viresh Kumar, Benjamin Herrenschmidt,
Paul Mackerras, Michael Ellerman, Patrice Chotard, linux-pm,
linuxppc-dev, linux-arm-kernel, kernel
Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.
Signed-off-by: Rob Herring <robh@kernel•org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki•net>
Cc: Viresh Kumar <viresh.kumar@linaro•org>
Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: Paul Mackerras <paulus@samba•org>
Cc: Michael Ellerman <mpe@ellerman•id.au>
Cc: Patrice Chotard <patrice.chotard@st•com>
Cc: linux-pm@vger•kernel.org
Cc: linuxppc-dev@lists•ozlabs.org
Cc: linux-arm-kernel@lists•infradead.org
Cc: kernel@stlinux•com
---
drivers/cpufreq/pmac64-cpufreq.c | 2 +-
drivers/cpufreq/sti-cpufreq.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/cpufreq/pmac64-cpufreq.c b/drivers/cpufreq/pmac64-cpufreq.c
index 267e0894c62d..be623dd7b9f2 100644
--- a/drivers/cpufreq/pmac64-cpufreq.c
+++ b/drivers/cpufreq/pmac64-cpufreq.c
@@ -516,7 +516,7 @@ static int __init g5_pm72_cpufreq_init(struct device_node *cpunode)
goto bail;
}
- DBG("cpufreq: i2c clock chip found: %s\n", hwclock->full_name);
+ DBG("cpufreq: i2c clock chip found: %pOF\n", hwclock);
/* Now get all the platform functions */
pfunc_cpu_getfreq =
diff --git a/drivers/cpufreq/sti-cpufreq.c b/drivers/cpufreq/sti-cpufreq.c
index d2d0430d09d4..47105735df12 100644
--- a/drivers/cpufreq/sti-cpufreq.c
+++ b/drivers/cpufreq/sti-cpufreq.c
@@ -65,8 +65,8 @@ static int sti_cpufreq_fetch_major(void) {
ret = of_property_read_u32_index(np, "st,syscfg",
MAJOR_ID_INDEX, &major_offset);
if (ret) {
- dev_err(dev, "No major number offset provided in %s [%d]\n",
- np->full_name, ret);
+ dev_err(dev, "No major number offset provided in %pOF [%d]\n",
+ np, ret);
return ret;
}
@@ -92,8 +92,8 @@ static int sti_cpufreq_fetch_minor(void)
MINOR_ID_INDEX, &minor_offset);
if (ret) {
dev_err(dev,
- "No minor number offset provided %s [%d]\n",
- np->full_name, ret);
+ "No minor number offset provided %pOF [%d]\n",
+ np, ret);
return ret;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: Convert to using %pOF instead of full_name
2017-07-18 21:42 [PATCH] cpufreq: Convert to using %pOF instead of full_name Rob Herring
@ 2017-07-19 6:38 ` Viresh Kumar
2017-07-19 7:06 ` Patrice CHOTARD
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2017-07-19 6:38 UTC (permalink / raw)
To: Rob Herring
Cc: Rafael J. Wysocki, linux-kernel, devicetree,
Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Patrice Chotard, linux-pm, linuxppc-dev, linux-arm-kernel, kernel
On 18-07-17, 16:42, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@kernel•org>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki•net>
> Cc: Viresh Kumar <viresh.kumar@linaro•org>
> Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> Cc: Paul Mackerras <paulus@samba•org>
> Cc: Michael Ellerman <mpe@ellerman•id.au>
> Cc: Patrice Chotard <patrice.chotard@st•com>
> Cc: linux-pm@vger•kernel.org
> Cc: linuxppc-dev@lists•ozlabs.org
> Cc: linux-arm-kernel@lists•infradead.org
> Cc: kernel@stlinux•com
> ---
> drivers/cpufreq/pmac64-cpufreq.c | 2 +-
> drivers/cpufreq/sti-cpufreq.c | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/cpufreq/pmac64-cpufreq.c b/drivers/cpufreq/pmac64-cpufreq.c
> index 267e0894c62d..be623dd7b9f2 100644
> --- a/drivers/cpufreq/pmac64-cpufreq.c
> +++ b/drivers/cpufreq/pmac64-cpufreq.c
> @@ -516,7 +516,7 @@ static int __init g5_pm72_cpufreq_init(struct device_node *cpunode)
> goto bail;
> }
>
> - DBG("cpufreq: i2c clock chip found: %s\n", hwclock->full_name);
> + DBG("cpufreq: i2c clock chip found: %pOF\n", hwclock);
>
> /* Now get all the platform functions */
> pfunc_cpu_getfreq =
> diff --git a/drivers/cpufreq/sti-cpufreq.c b/drivers/cpufreq/sti-cpufreq.c
> index d2d0430d09d4..47105735df12 100644
> --- a/drivers/cpufreq/sti-cpufreq.c
> +++ b/drivers/cpufreq/sti-cpufreq.c
> @@ -65,8 +65,8 @@ static int sti_cpufreq_fetch_major(void) {
> ret = of_property_read_u32_index(np, "st,syscfg",
> MAJOR_ID_INDEX, &major_offset);
> if (ret) {
> - dev_err(dev, "No major number offset provided in %s [%d]\n",
> - np->full_name, ret);
> + dev_err(dev, "No major number offset provided in %pOF [%d]\n",
> + np, ret);
> return ret;
> }
>
> @@ -92,8 +92,8 @@ static int sti_cpufreq_fetch_minor(void)
> MINOR_ID_INDEX, &minor_offset);
> if (ret) {
> dev_err(dev,
> - "No minor number offset provided %s [%d]\n",
> - np->full_name, ret);
> + "No minor number offset provided %pOF [%d]\n",
> + np, ret);
> return ret;
> }
Acked-by: Viresh Kumar <viresh.kumar@linaro•org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: Convert to using %pOF instead of full_name
2017-07-18 21:42 [PATCH] cpufreq: Convert to using %pOF instead of full_name Rob Herring
2017-07-19 6:38 ` Viresh Kumar
@ 2017-07-19 7:06 ` Patrice CHOTARD
1 sibling, 0 replies; 3+ messages in thread
From: Patrice CHOTARD @ 2017-07-19 7:06 UTC (permalink / raw)
To: Rob Herring, Rafael J. Wysocki
Cc: linux-kernel@vger•kernel.org, devicetree@vger•kernel.org,
Viresh Kumar, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, linux-pm@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org,
linux-arm-kernel@lists•infradead.org, kernel@stlinux•com
DQpPbiAwNy8xOC8yMDE3IDExOjQyIFBNLCBSb2IgSGVycmluZyB3cm90ZToNCj4gTm93IHRoYXQg
d2UgaGF2ZSBhIGN1c3RvbSBwcmludGYgZm9ybWF0IHNwZWNpZmllciwgY29udmVydCB1c2VycyBv
Zg0KPiBmdWxsX25hbWUgdG8gdXNlICVwT0YgaW5zdGVhZC4gVGhpcyBpcyBwcmVwYXJhdGlvbiB0
byByZW1vdmUgc3RvcmluZw0KPiBvZiB0aGUgZnVsbCBwYXRoIHN0cmluZyBmb3IgZWFjaCBub2Rl
Lg0KPiANCj4gU2lnbmVkLW9mZi1ieTogUm9iIEhlcnJpbmcgPHJvYmhAa2VybmVsLm9yZz4NCj4g
Q2M6ICJSYWZhZWwgSi4gV3lzb2NraSIgPHJqd0Byand5c29ja2kubmV0Pg0KPiBDYzogVmlyZXNo
IEt1bWFyIDx2aXJlc2gua3VtYXJAbGluYXJvLm9yZz4NCj4gQ2M6IEJlbmphbWluIEhlcnJlbnNj
aG1pZHQgPGJlbmhAa2VybmVsLmNyYXNoaW5nLm9yZz4NCj4gQ2M6IFBhdWwgTWFja2VycmFzIDxw
YXVsdXNAc2FtYmEub3JnPg0KPiBDYzogTWljaGFlbCBFbGxlcm1hbiA8bXBlQGVsbGVybWFuLmlk
LmF1Pg0KPiBDYzogUGF0cmljZSBDaG90YXJkIDxwYXRyaWNlLmNob3RhcmRAc3QuY29tPg0KPiBD
YzogbGludXgtcG1Admdlci5rZXJuZWwub3JnDQo+IENjOiBsaW51eHBwYy1kZXZAbGlzdHMub3ps
YWJzLm9yZw0KPiBDYzogbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnDQo+IENj
OiBrZXJuZWxAc3RsaW51eC5jb20NCj4gLS0tDQo+ICAgZHJpdmVycy9jcHVmcmVxL3BtYWM2NC1j
cHVmcmVxLmMgfCAyICstDQo+ICAgZHJpdmVycy9jcHVmcmVxL3N0aS1jcHVmcmVxLmMgICAgfCA4
ICsrKystLS0tDQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRp
b25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9jcHVmcmVxL3BtYWM2NC1jcHVmcmVx
LmMgYi9kcml2ZXJzL2NwdWZyZXEvcG1hYzY0LWNwdWZyZXEuYw0KPiBpbmRleCAyNjdlMDg5NGM2
MmQuLmJlNjIzZGQ3YjlmMiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9jcHVmcmVxL3BtYWM2NC1j
cHVmcmVxLmMNCj4gKysrIGIvZHJpdmVycy9jcHVmcmVxL3BtYWM2NC1jcHVmcmVxLmMNCj4gQEAg
LTUxNiw3ICs1MTYsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBnNV9wbTcyX2NwdWZyZXFfaW5pdChz
dHJ1Y3QgZGV2aWNlX25vZGUgKmNwdW5vZGUpDQo+ICAgCQlnb3RvIGJhaWw7DQo+ICAgCX0NCj4g
DQo+IC0JREJHKCJjcHVmcmVxOiBpMmMgY2xvY2sgY2hpcCBmb3VuZDogJXNcbiIsIGh3Y2xvY2st
PmZ1bGxfbmFtZSk7DQo+ICsJREJHKCJjcHVmcmVxOiBpMmMgY2xvY2sgY2hpcCBmb3VuZDogJXBP
RlxuIiwgaHdjbG9jayk7DQo+IA0KPiAgIAkvKiBOb3cgZ2V0IGFsbCB0aGUgcGxhdGZvcm0gZnVu
Y3Rpb25zICovDQo+ICAgCXBmdW5jX2NwdV9nZXRmcmVxID0NCj4gZGlmZiAtLWdpdCBhL2RyaXZl
cnMvY3B1ZnJlcS9zdGktY3B1ZnJlcS5jIGIvZHJpdmVycy9jcHVmcmVxL3N0aS1jcHVmcmVxLmMN
Cj4gaW5kZXggZDJkMDQzMGQwOWQ0Li40NzEwNTczNWRmMTIgMTAwNjQ0DQo+IC0tLSBhL2RyaXZl
cnMvY3B1ZnJlcS9zdGktY3B1ZnJlcS5jDQo+ICsrKyBiL2RyaXZlcnMvY3B1ZnJlcS9zdGktY3B1
ZnJlcS5jDQo+IEBAIC02NSw4ICs2NSw4IEBAIHN0YXRpYyBpbnQgc3RpX2NwdWZyZXFfZmV0Y2hf
bWFqb3Iodm9pZCkgew0KPiAgIAlyZXQgPSBvZl9wcm9wZXJ0eV9yZWFkX3UzMl9pbmRleChucCwg
InN0LHN5c2NmZyIsDQo+ICAgCQkJCQkgTUFKT1JfSURfSU5ERVgsICZtYWpvcl9vZmZzZXQpOw0K
PiAgIAlpZiAocmV0KSB7DQo+IC0JCWRldl9lcnIoZGV2LCAiTm8gbWFqb3IgbnVtYmVyIG9mZnNl
dCBwcm92aWRlZCBpbiAlcyBbJWRdXG4iLA0KPiAtCQkJbnAtPmZ1bGxfbmFtZSwgcmV0KTsNCj4g
KwkJZGV2X2VycihkZXYsICJObyBtYWpvciBudW1iZXIgb2Zmc2V0IHByb3ZpZGVkIGluICVwT0Yg
WyVkXVxuIiwNCj4gKwkJCW5wLCByZXQpOw0KPiAgIAkJcmV0dXJuIHJldDsNCj4gICAJfQ0KPiAN
Cj4gQEAgLTkyLDggKzkyLDggQEAgc3RhdGljIGludCBzdGlfY3B1ZnJlcV9mZXRjaF9taW5vcih2
b2lkKQ0KPiAgIAkJCQkJIE1JTk9SX0lEX0lOREVYLCAmbWlub3Jfb2Zmc2V0KTsNCj4gICAJaWYg
KHJldCkgew0KPiAgIAkJZGV2X2VycihkZXYsDQo+IC0JCQkiTm8gbWlub3IgbnVtYmVyIG9mZnNl
dCBwcm92aWRlZCAlcyBbJWRdXG4iLA0KPiAtCQkJbnAtPmZ1bGxfbmFtZSwgcmV0KTsNCj4gKwkJ
CSJObyBtaW5vciBudW1iZXIgb2Zmc2V0IHByb3ZpZGVkICVwT0YgWyVkXVxuIiwNCj4gKwkJCW5w
LCByZXQpOw0KPiAgIAkJcmV0dXJuIHJldDsNCj4gICAJfQ0KPiANCj4gLS0NCj4gMi4xMS4wDQo+
IA0KDQpGb3IgU1QgY3B1ZnJlcToNCg0KQWNrZWQtYnk6IFBhdHJpY2UgQ2hvdGFyZCA8cGF0cmlj
ZS5jaG90YXJkQHN0LmNvbT4NCg0KVGhhbmtz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-19 7:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-18 21:42 [PATCH] cpufreq: Convert to using %pOF instead of full_name Rob Herring
2017-07-19 6:38 ` Viresh Kumar
2017-07-19 7:06 ` Patrice CHOTARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox