From: Al Viro <viro@ZenIV•linux.org.uk>
To: Paul Mackerras <paulus@ozlabs•org>
Cc: Nixiaoming <nixiaoming@huawei•com>,
David Hildenbrand <david@redhat•com>,
"agraf@suse•com" <agraf@suse•com>,
"pbonzini@redhat•com" <pbonzini@redhat•com>,
"rkrcmar@redhat•com" <rkrcmar@redhat•com>,
"benh@kernel•crashing.org" <benh@kernel•crashing.org>,
"mpe@ellerman•id.au" <mpe@ellerman•id.au>,
"kvm-ppc@vger•kernel.org" <kvm-ppc@vger•kernel.org>,
"kvm@vger•kernel.org" <kvm@vger•kernel.org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce
Date: Sun, 27 Aug 2017 22:02:20 +0100 [thread overview]
Message-ID: <20170827210220.GG5426@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20170823060624.GA13958@fergus.ozlabs.ibm.com>
On Wed, Aug 23, 2017 at 04:06:24PM +1000, Paul Mackerras wrote:
> It seems to me that it would be better to do the anon_inode_getfd()
> call before the kvm_get_kvm() call, and go to the fail label if it
> fails.
And what happens if another thread does close() on the (guessed) fd?
next prev parent reply other threads:[~2017-08-27 21:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 14:28 [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce nixiaoming
2017-08-22 15:15 ` David Hildenbrand
2017-08-22 15:23 ` David Hildenbrand
2017-08-23 1:43 ` Nixiaoming
2017-08-23 6:06 ` Paul Mackerras
2017-08-23 8:25 ` David Hildenbrand
2017-08-23 9:16 ` David Hildenbrand
2017-08-23 10:17 ` 答复: " Nixiaoming
2017-08-24 1:06 ` Nixiaoming
2017-08-27 21:02 ` Al Viro [this message]
2017-08-28 4:38 ` Paul Mackerras
2017-08-28 5:28 ` Al Viro
2017-08-28 6:06 ` Paul Mackerras
2017-08-28 11:31 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170827210220.GG5426@ZenIV.linux.org.uk \
--to=viro@zeniv$(echo .)linux.org.uk \
--cc=agraf@suse$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=david@redhat$(echo .)com \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=nixiaoming@huawei$(echo .)com \
--cc=paulus@ozlabs$(echo .)org \
--cc=pbonzini@redhat$(echo .)com \
--cc=rkrcmar@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox