From: Mark Rutland <mark.rutland@arm•com>
To: Pavel Tatashin <pasha.tatashin@oracle•com>
Cc: linux-kernel@vger•kernel.org, sparclinux@vger•kernel.org,
linux-mm@kvack•org, linuxppc-dev@lists•ozlabs.org,
linux-s390@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
x86@kernel•org, kasan-dev@googlegroups•com,
borntraeger@de•ibm.com, heiko.carstens@de•ibm.com,
davem@davemloft•net, willy@infradead•org, mhocko@kernel•org,
ard.biesheuvel@linaro•org, will.deacon@arm•com,
catalin.marinas@arm•com, sam@ravnborg•org,
mgorman@techsingularity•net, Steven.Sistare@oracle•com,
daniel.m.jordan@oracle•com, bob.picco@oracle•com
Subject: Re: [PATCH v8 10/11] arm64/kasan: explicitly zero kasan shadow memory
Date: Fri, 15 Sep 2017 22:51:48 +0100 [thread overview]
Message-ID: <20170915215147.GA11849@remoulade> (raw)
In-Reply-To: <bff836ec-3922-1783-6cb4-94d1be92544b@oracle.com>
On Fri, Sep 15, 2017 at 05:20:59PM -0400, Pavel Tatashin wrote:
> Hi Mark,
>
> I had this option back upto version 3, where zero flag was passed into
> vmemmap_alloc_block(), but I was asked to remove it, because it required too
> many changes in other places.
Ok. Sorry for bringing back a point that had already been covered.
> So, the current approach is cleaner, but the idea is that kasan should use
> its own version of vmemmap_populate() for both x86 and ARM, but I think it is
> outside of the scope of this work.
I appreciate that this is unrelated to your ultimate goal, and that this is
somewhat frustrating given the KASAN code is arguably abusing the
vmemmap_populate() interface.
However, I do think we need to migrate the KASAN code to a proper interface
immediately, rather than making it worse in the interim.
> If you think I should add these function in this project, than sure I can
> send a new version with kasanmap_populate() functions.
I would very much appreciate if you could send a version with a
kasan_map_populate() interface. I'm more than happy to review/test that portion
of the series, or to help if there's some problem which makes that difficult.
Thanks,
Mark.
next prev parent reply other threads:[~2017-09-15 22:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 22:35 [PATCH v7 00/11] complete deferred page initialization Pavel Tatashin
2017-09-14 22:35 ` [PATCH v8 01/11] x86/mm: setting fields in deferred pages Pavel Tatashin
2017-09-14 22:35 ` [PATCH v8 02/11] sparc64/mm: " Pavel Tatashin
2017-09-14 22:35 ` [PATCH v8 03/11] mm: deferred_init_memmap improvements Pavel Tatashin
2017-09-14 22:35 ` [PATCH v8 04/11] sparc64: simplify vmemmap_populate Pavel Tatashin
2017-09-14 22:35 ` [PATCH v8 05/11] mm: defining memblock_virt_alloc_try_nid_raw Pavel Tatashin
2017-09-14 22:35 ` [PATCH v8 06/11] mm: zero struct pages during initialization Pavel Tatashin
2017-09-14 22:35 ` [PATCH v8 07/11] sparc64: optimized struct page zeroing Pavel Tatashin
2017-09-14 22:35 ` [PATCH v8 08/11] mm: zero reserved and unavailable struct pages Pavel Tatashin
2017-09-14 22:35 ` [PATCH v8 09/11] x86/kasan: explicitly zero kasan shadow memory Pavel Tatashin
2017-09-14 22:35 ` [PATCH v8 10/11] arm64/kasan: " Pavel Tatashin
2017-09-15 1:10 ` Mark Rutland
2017-09-15 1:30 ` Pavel Tatashin
2017-09-15 20:38 ` Mark Rutland
2017-09-15 21:20 ` Pavel Tatashin
2017-09-15 21:51 ` Mark Rutland [this message]
2017-09-14 22:35 ` [PATCH v8 11/11] mm: stop zeroing memory during allocation in vmemmap Pavel Tatashin
2017-09-14 22:40 ` [PATCH v8 00/11] complete deferred page initialization Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915215147.GA11849@remoulade \
--to=mark.rutland@arm$(echo .)com \
--cc=Steven.Sistare@oracle$(echo .)com \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=bob.picco@oracle$(echo .)com \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=daniel.m.jordan@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=kasan-dev@googlegroups$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mgorman@techsingularity$(echo .)net \
--cc=mhocko@kernel$(echo .)org \
--cc=pasha.tatashin@oracle$(echo .)com \
--cc=sam@ravnborg$(echo .)org \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=will.deacon@arm$(echo .)com \
--cc=willy@infradead$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox