From: "Paul E. McKenney" <paulmck@linux•vnet.ibm.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios•com>
Cc: Peter Zijlstra <peterz@infradead•org>,
linux-kernel@vger•kernel.org, Boqun Feng <boqun.feng@gmail•com>,
Andrew Hunter <ahh@google•com>,
Maged Michael <maged.michael@gmail•com>,
gromer@google•com, Avi Kivity <avi@scylladb•com>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Michael Ellerman <mpe@ellerman•id.au>,
Dave Watson <davejwatson@fb•com>,
Alan Stern <stern@rowland•harvard.edu>,
Will Deacon <will.deacon@arm•com>,
Andy Lutomirski <luto@kernel•org>, Ingo Molnar <mingo@redhat•com>,
Alexander Viro <viro@zeniv•linux.org.uk>,
linuxppc-dev@lists•ozlabs.org, linux-arch@vger•kernel.org
Subject: Re: [RFC PATCH for 4.14 1/2] membarrier: Remove unused code for architectures without membarrier hooks
Date: Fri, 6 Oct 2017 14:08:01 -0700 [thread overview]
Message-ID: <20171006210801.GL3521@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171005223327.3500-1-mathieu.desnoyers@efficios.com>
On Thu, Oct 05, 2017 at 06:33:26PM -0400, Mathieu Desnoyers wrote:
> Architectures without membarrier hooks don't need to emit the
> empty membarrier_arch_switch_mm() static inline when
> CONFIG_MEMBARRIER=y.
>
> Adapt the CONFIG_MEMBARRIER=n counterpart to only emit the empty
> membarrier_arch_switch_mm() for architectures with membarrier hooks.
>
> Reported-by: Nicholas Piggin <npiggin@gmail•com>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios•com>
Queued for further review and testing, targeting v4.15. Please let me
know if you need it sooner.
Thanx, Paul
> CC: Peter Zijlstra <peterz@infradead•org>
> CC: Paul E. McKenney <paulmck@linux•vnet.ibm.com>
> CC: Boqun Feng <boqun.feng@gmail•com>
> CC: Andrew Hunter <ahh@google•com>
> CC: Maged Michael <maged.michael@gmail•com>
> CC: gromer@google•com
> CC: Avi Kivity <avi@scylladb•com>
> CC: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> CC: Paul Mackerras <paulus@samba•org>
> CC: Michael Ellerman <mpe@ellerman•id.au>
> CC: Dave Watson <davejwatson@fb•com>
> CC: Alan Stern <stern@rowland•harvard.edu>
> CC: Will Deacon <will.deacon@arm•com>
> CC: Andy Lutomirski <luto@kernel•org>
> CC: Ingo Molnar <mingo@redhat•com>
> CC: Alexander Viro <viro@zeniv•linux.org.uk>
> CC: linuxppc-dev@lists•ozlabs.org
> CC: linux-arch@vger•kernel.org
> ---
> include/linux/sched/mm.h | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h
> index d5a9ab8f3836..b2767ecb21a8 100644
> --- a/include/linux/sched/mm.h
> +++ b/include/linux/sched/mm.h
> @@ -215,10 +215,6 @@ static inline void memalloc_noreclaim_restore(unsigned int flags)
> #ifdef CONFIG_ARCH_HAS_MEMBARRIER_HOOKS
> #include <asm/membarrier.h>
> #else
> -static inline void membarrier_arch_switch_mm(struct mm_struct *prev,
> - struct mm_struct *next, struct task_struct *tsk)
> -{
> -}
> static inline void membarrier_arch_fork(struct task_struct *t,
> unsigned long clone_flags)
> {
> @@ -247,10 +243,12 @@ static inline void membarrier_execve(struct task_struct *t)
> membarrier_arch_execve(t);
> }
> #else
> +#ifdef CONFIG_ARCH_HAS_MEMBARRIER_HOOKS
> static inline void membarrier_arch_switch_mm(struct mm_struct *prev,
> struct mm_struct *next, struct task_struct *tsk)
> {
> }
> +#endif
> static inline void membarrier_fork(struct task_struct *t,
> unsigned long clone_flags)
> {
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-10-06 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 22:33 [RFC PATCH for 4.14 1/2] membarrier: Remove unused code for architectures without membarrier hooks Mathieu Desnoyers
2017-10-05 22:33 ` [RFC PATCH v2 for 4.14 2/2] Fix: membarrier: Handle CLONE_VM + !CLONE_THREAD correctly on powerpc Mathieu Desnoyers
2017-10-06 21:08 ` Paul E. McKenney [this message]
2017-10-06 21:53 ` [RFC PATCH for 4.14 1/2] membarrier: Remove unused code for architectures without membarrier hooks Mathieu Desnoyers
-- strict thread matches above, loose matches on Subject: below --
2017-10-05 21:40 Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171006210801.GL3521@linux.vnet.ibm.com \
--to=paulmck@linux$(echo .)vnet.ibm.com \
--cc=ahh@google$(echo .)com \
--cc=avi@scylladb$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=boqun.feng@gmail$(echo .)com \
--cc=davejwatson@fb$(echo .)com \
--cc=gromer@google$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=luto@kernel$(echo .)org \
--cc=maged.michael@gmail$(echo .)com \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=stern@rowland$(echo .)harvard.edu \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=will.deacon@arm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox