Subject: Re: [PATCH v1 05/15] ASoC: fsl_ssi: Clean up helper functions of trigger()

From: Nicolin Chen <[email-masked]>
Date: Thu, 4 Jan 2018 11:44:06 -0800

On Mon, Jan 01, 2018 at 10:59:30PM +0100, Maciej S. Szmigiero wrote:

> > +static void fsl_ssi_config_enable(struct fsl_ssi *ssi, bool tx)

> > +		srcr = vals[tx].srcr;
> > +		stcr = vals[tx].stcr;
> > +		sier = vals[tx].sier;
> 
> Implicit assumption here that RX == 0, TX == 1, as in the 03 patch.

Could replace it with "bool dir" as well. Thanks for the review.