From: David Gibson <david@gibson•dropbear.id.au>
To: Michael Ellerman <mpe@ellerman•id.au>
Cc: "Michal Suchanek" <msuchanek@suse•de>,
"Benjamin Herrenschmidt" <benh@kernel•crashing.org>,
"Paul Mackerras" <paulus@samba•org>,
"Philippe Ombredanne" <pombredanne@nexb•com>,
"Cédric Le Goater" <clg@kaod•org>,
"Thomas Falcon" <tlfalcon@linux•vnet.ibm.com>,
"Tobin C. Harding" <me@tobin•cc>,
"Michael Neuling" <mikey@neuling•org>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h
Date: Tue, 16 Jan 2018 15:53:47 +1100 [thread overview]
Message-ID: <20180116045347.GC30352@umbus.fritz.box> (raw)
In-Reply-To: <87wp0ia3x1.fsf@concordia.ellerman.id.au>
[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]
On Tue, Jan 16, 2018 at 02:16:58PM +1100, Michael Ellerman wrote:
> Michal Suchanek <msuchanek@suse•de> writes:
>
> > Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> > settings") uses u64 in asm/hvcall.h without including linux/types.h
> >
> > This breaks hvcall.h users that do not include the header themselves.
> >
> > Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> > settings")
> >
> > Signed-off-by: Michal Suchanek <msuchanek@suse•de>
> > ---
> > arch/powerpc/include/asm/hvcall.h | 1 +
> > 1 file changed, 1 insertion(+)
>
> Thanks. None of my ~250 defconfig test builds hit this, what config are
> you using?
I also hit this, but only when I backported the change to RH's 3.10
kernel. I assumed something since then had added an indirect include.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-01-16 4:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 13:30 [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h Michal Suchanek
2018-01-16 3:16 ` Michael Ellerman
2018-01-16 4:53 ` David Gibson [this message]
2018-01-17 13:25 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116045347.GC30352@umbus.fritz.box \
--to=david@gibson$(echo .)dropbear.id.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=clg@kaod$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=me@tobin$(echo .)cc \
--cc=mikey@neuling$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=msuchanek@suse$(echo .)de \
--cc=paulus@samba$(echo .)org \
--cc=pombredanne@nexb$(echo .)com \
--cc=tlfalcon@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox