* [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h
@ 2018-01-15 13:30 Michal Suchanek
2018-01-16 3:16 ` Michael Ellerman
2018-01-17 13:25 ` Michael Ellerman
0 siblings, 2 replies; 4+ messages in thread
From: Michal Suchanek @ 2018-01-15 13:30 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Philippe Ombredanne, Cédric Le Goater, David Gibson,
Thomas Falcon, Michal Suchanek, Tobin C. Harding, Michael Neuling,
linuxppc-dev, linux-kernel
Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
settings") uses u64 in asm/hvcall.h without including linux/types.h
This breaks hvcall.h users that do not include the header themselves.
Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
settings")
Signed-off-by: Michal Suchanek <msuchanek@suse•de>
---
arch/powerpc/include/asm/hvcall.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h
index f0461618bf7b..eca3f9c68907 100644
--- a/arch/powerpc/include/asm/hvcall.h
+++ b/arch/powerpc/include/asm/hvcall.h
@@ -353,6 +353,7 @@
#define PROC_TABLE_GTSE 0x01
#ifndef __ASSEMBLY__
+#include <linux/types.h>
/**
* plpar_hcall_norets: - Make a pseries hypervisor call with no return arguments
--
2.13.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h
2018-01-15 13:30 [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h Michal Suchanek
@ 2018-01-16 3:16 ` Michael Ellerman
2018-01-16 4:53 ` David Gibson
2018-01-17 13:25 ` Michael Ellerman
1 sibling, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2018-01-16 3:16 UTC (permalink / raw)
To: Michal Suchanek, Benjamin Herrenschmidt, Paul Mackerras,
Philippe Ombredanne, Cédric Le Goater, David Gibson,
Thomas Falcon, Michal Suchanek, Tobin C. Harding, Michael Neuling,
linuxppc-dev, linux-kernel
Michal Suchanek <msuchanek@suse•de> writes:
> Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> settings") uses u64 in asm/hvcall.h without including linux/types.h
>
> This breaks hvcall.h users that do not include the header themselves.
>
> Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> settings")
>
> Signed-off-by: Michal Suchanek <msuchanek@suse•de>
> ---
> arch/powerpc/include/asm/hvcall.h | 1 +
> 1 file changed, 1 insertion(+)
Thanks. None of my ~250 defconfig test builds hit this, what config are
you using?
cheers
> diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h
> index f0461618bf7b..eca3f9c68907 100644
> --- a/arch/powerpc/include/asm/hvcall.h
> +++ b/arch/powerpc/include/asm/hvcall.h
> @@ -353,6 +353,7 @@
> #define PROC_TABLE_GTSE 0x01
>
> #ifndef __ASSEMBLY__
> +#include <linux/types.h>
>
> /**
> * plpar_hcall_norets: - Make a pseries hypervisor call with no return arguments
> --
> 2.13.6
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h
2018-01-16 3:16 ` Michael Ellerman
@ 2018-01-16 4:53 ` David Gibson
0 siblings, 0 replies; 4+ messages in thread
From: David Gibson @ 2018-01-16 4:53 UTC (permalink / raw)
To: Michael Ellerman
Cc: Michal Suchanek, Benjamin Herrenschmidt, Paul Mackerras,
Philippe Ombredanne, Cédric Le Goater, Thomas Falcon,
Tobin C. Harding, Michael Neuling, linuxppc-dev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]
On Tue, Jan 16, 2018 at 02:16:58PM +1100, Michael Ellerman wrote:
> Michal Suchanek <msuchanek@suse•de> writes:
>
> > Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> > settings") uses u64 in asm/hvcall.h without including linux/types.h
> >
> > This breaks hvcall.h users that do not include the header themselves.
> >
> > Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> > settings")
> >
> > Signed-off-by: Michal Suchanek <msuchanek@suse•de>
> > ---
> > arch/powerpc/include/asm/hvcall.h | 1 +
> > 1 file changed, 1 insertion(+)
>
> Thanks. None of my ~250 defconfig test builds hit this, what config are
> you using?
I also hit this, but only when I backported the change to RH's 3.10
kernel. I assumed something since then had added an indirect include.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: powerpc/pseries: include linux/types.h in asm/hvcall.h
2018-01-15 13:30 [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h Michal Suchanek
2018-01-16 3:16 ` Michael Ellerman
@ 2018-01-17 13:25 ` Michael Ellerman
1 sibling, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2018-01-17 13:25 UTC (permalink / raw)
To: Michal Suchanek, Benjamin Herrenschmidt, Paul Mackerras,
Philippe Ombredanne, Cédric Le Goater, David Gibson,
Thomas Falcon, Michal Suchanek, Tobin C. Harding, Michael Neuling,
linuxppc-dev, linux-kernel
On Mon, 2018-01-15 at 13:30:03 UTC, Michal Suchanek wrote:
> Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> settings") uses u64 in asm/hvcall.h without including linux/types.h
>
> This breaks hvcall.h users that do not include the header themselves.
>
> Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> settings")
>
> Signed-off-by: Michal Suchanek <msuchanek@suse•de>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/1b689a95ce7427075f9ac9fb4aea1a
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-17 13:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-15 13:30 [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h Michal Suchanek
2018-01-16 3:16 ` Michael Ellerman
2018-01-16 4:53 ` David Gibson
2018-01-17 13:25 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox