From: Mathieu Malaterre <malat@debian•org>
To: Michael Ellerman <mpe@ellerman•id.au>
Cc: Laurent Vivier <lvivier@redhat•com>,
Mathieu Malaterre <malat@debian•org>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Subject: [PATCH v2] powerpc/via-pmu: Fix section mismatch warning
Date: Wed, 14 Feb 2018 22:15:18 +0100 [thread overview]
Message-ID: <20180214211519.15683-1-malat@debian.org> (raw)
In-Reply-To: <20180207194439.32680-1-malat@debian.org>
Make the struct via_pmu_driver const to avoid following warning:
WARNING: vmlinux.o(.data+0x4739c): Section mismatch in reference from the variable via_pmu_driver to the function .init.text:pmu_init()
The variable via_pmu_driver references
the function __init pmu_init()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
Signed-off-by: Mathieu Malaterre <malat@debian•org>
Suggested-by: Laurent Vivier <lvivier@redhat•com>
---
v2: pmu_init() is really an init function, leave __init marker
drivers/macintosh/via-pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index 94c0f3f7df69..fc56c7067732 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -198,7 +198,7 @@ static const struct file_operations pmu_battery_proc_fops;
static const struct file_operations pmu_options_proc_fops;
#ifdef CONFIG_ADB
-struct adb_driver via_pmu_driver = {
+const struct adb_driver via_pmu_driver = {
"PMU",
pmu_probe,
pmu_init,
--
2.11.0
next prev parent reply other threads:[~2018-02-14 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 19:44 [PATCH] powerpc/via-pmu: Fix section mismatch warning Mathieu Malaterre
2018-02-13 18:54 ` Laurent Vivier
2018-02-14 21:16 ` Mathieu Malaterre
2018-02-14 21:15 ` Mathieu Malaterre [this message]
2018-02-15 10:35 ` [PATCH v2] " Laurent Vivier
2018-03-14 9:27 ` [v2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214211519.15683-1-malat@debian.org \
--to=malat@debian$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lvivier@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox