From: Marcus Folkesson <marcus.folkesson@gmail•com>
To: William Breathitt Gray <vilhelm.gray@gmail•com>
Cc: Guenter Roeck <linux@roeck-us•net>,
Wim Van Sebroeck <wim@linux-watchdog•org>,
Joel Stanley <joel@jms•id.au>,
Nicolas Ferre <nicolas.ferre@microchip•com>,
Alexandre Belloni <alexandre.belloni@free-electrons•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Ray Jui <rjui@broadcom•com>,
Scott Branden <sbranden@broadcom•com>,
bcm-kernel-feedback-list@broadcom•com,
Eric Anholt <eric@anholt•net>,
Stefan Wahren <stefan.wahren@i2se•com>,
Linus Walleij <linus.walleij@linaro•org>,
Support Opensource <support.opensource@diasemi•com>,
Baruch Siach <baruch@tkos•co.il>,
Jimmy Vance <jimmy.vance@hpe•com>,
Keguang Zhang <keguang.zhang@gmail•com>,
Joachim Eastwood <manabian@gmail•com>,
Tomas Winkler <tomas.winkler@intel•com>,
Johannes Thumshirn <morbidrsa@gmail•com>,
Andreas Werner <andreas.werner@men•de>,
Carlo Caione <carlo@caione•org>,
Kevin Hilman <khilman@baylibre•com>,
Matthias Brugger <matthias.bgg@gmail•com>,
Wan ZongShun <mcuos.com@gmail•com>,
Michal Simek <michal.simek@xilinx•com>,
Vladimir Zapolskiy <vz@mleia•com>,
Sylvain Lemieux <slemieux.tyco@gmail•com>,
Kukjin Kim <kgene@kernel•org>,
Krzysztof Kozlowski <krzk@kernel•org>,
Zwane Mwaikambo <zwanem@gmail•com>,
Jim Cromie <jim.cromie@gmail•com>, Barry Song <baohua@kernel•org>,
Patrice Chotard <patrice.chotard@st•com>,
Maxime Ripard <maxime.ripard@bootlin•com>,
Chen-Yu Tsai <wens@csie•org>,
Marc Gonzalez <marc.w.gonzalez@free•fr>,
Mans Rullgard <mans@mansr•com>,
Thierry Reding <thierry.reding@gmail•com>,
Jonathan Hunter <jonathanh@nvidia•com>,
Masahiro Yamada <yamada.masahiro@socionext•com>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Michael Ellerman <mpe@ellerman•id.au>,
Jun Nie <jun.nie@linaro•org>, Baoyou Xie <baoyou.xie@linaro•org>,
Shawn Guo <shawnguo@kernel•org>,
linux-watchdog@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-rpi-kernel@lists•infradead.org,
adi-buildroot-devel@lists•sourceforge.net,
linux-mips@linux-mips•org, linux-amlogic@lists•infradead.org,
linux-mediatek@lists•infradead.org,
linux-samsung-soc@vger•kernel.org, linux-tegra@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, patches@opensource•cirrus.com
Subject: Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem
Date: Tue, 20 Feb 2018 19:45:22 +0100 [thread overview]
Message-ID: <20180220184522.GF24311@gmail.com> (raw)
In-Reply-To: <20180220181427.GA25467@sophia>
[-- Attachment #1: Type: text/plain, Size: 4784 bytes --]
On Tue, Feb 20, 2018 at 01:14:27PM -0500, William Breathitt Gray wrote:
> On Tue, Feb 20, 2018 at 04:33:26PM +0100, Marcus Folkesson wrote:
> >On Tue, Feb 20, 2018 at 07:13:43AM -0800, Guenter Roeck wrote:
> >> On 02/20/2018 05:21 AM, Marcus Folkesson wrote:
> >> > Hello William,
> >> >
> >> > On Tue, Feb 20, 2018 at 07:49:55AM -0500, William Breathitt Gray wrote:
> >> > > On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote:
> >> > > > - Add SPDX identifier
> >> > > > - Remove boiler plate license text
> >> > > > - If MODULE_LICENSE and boiler plate does not match, go for boiler plate
> >> > > > license
> >> > > >
> >> > > > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail•com>
> >> > > > Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi•com>
> >> > > > Acked-by: Charles Keepax <ckeepax@opensource•cirrus.com>
> >> > > > Acked-by: Nicolas Ferre <nicolas.ferre@microchip•com>
> >> > > > Acked-by: Michal Simek <michal.simek@xilinx•com>
> >> > > > ---
> >> > > >
> >> > > > Notes:
> >> > > > v2:
> >> > > > - Put back removed copyright texts for meson_gxbb_wdt and coh901327_wdt
> >> > > > - Change to BSD-3-Clause for meson_gxbb_wdt
> >> > > > v1: Please have an extra look at meson_gxbb_wdt.c
> >> > >
> >> > > [...]
> >> > >
> >> > > > diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384_wdt.c
> >> > > > index 2170b275ea01..c173b6f5c866 100644
> >> > > > --- a/drivers/watchdog/ebc-c384_wdt.c
> >> > > > +++ b/drivers/watchdog/ebc-c384_wdt.c
> >> > > > @@ -1,15 +1,8 @@
> >> > > > +// SPDX-License-Identifier: GPL-2.0
> >> > > > /*
> >> > > > * Watchdog timer driver for the WinSystems EBC-C384
> >> > > > * Copyright (C) 2016 William Breathitt Gray
> >> > > > *
> >
> >The copyright is untouched?
> >
> >> > > > - * This program is free software; you can redistribute it and/or modify
> >> > > > - * it under the terms of the GNU General Public License, version 2, as
> >> > > > - * published by the Free Software Foundation.
> >> > > > - *
> >> > > > - * This program is distributed in the hope that it will be useful, but
> >> > > > - * WITHOUT ANY WARRANTY; without even the implied warranty of
> >> > > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> >> > > > - * General Public License for more details.
> >> > > > */
> >> > > > #include <linux/device.h>
> >> > > > #include <linux/dmi.h>
> >> >
> >> > Thank you for your feedback!
> >> > >
> >> > > I have no problem with adding a SPDX line to the top of this file, but
> >> > > use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional
> >> > > with the selection of GPL version 2 only when I published this code.
> >> >
> >> > SPDX-License-Identifier: GPL-2.0
> >> > Is GPL-2.0 only [1], so it respects your choice of license.
>
> Ah, this should be fine then. :)
>
Good!
> >> >
> >> > >
> >> > > Furthermore, please do not remove the existing copyright text; although
> >> >
> >>
> >> It is not a matter if you CAN keep a copyright. You MUST NOT remove a copyright.
> >> As long as you do, the series is
> >>
> >> Nacked-by: Guenter Roeck <linux@roeck-us•net>
> >>
> >> Guenter
> >
> >I'm sorry, I do not see where the copyright is removed unless you count
> >the license text as part of the copyright.
> >
> >Can you please point it out?
> >
> >>
> >> > The copyright text:
> >> >
> >> > Copyright (C) 2016 William Breathitt Gray
> >> >
> >> > Is still in the file.
> >
> >^^^
> >
> >> >
> >> >
> >> > > it's just boilerplate for some, I was careful with the selection of
> >> > > these words, and I worry the SPDX line only -- despite its useful
> >> > > conciseness -- may lead to misunderstandings about my intentioned
> >> > > license for this code.
> >> >
> >> > I'm not sure I understand your concerns here, the SPDX identifier is
> >> > a shorthand for the GPL 2.0 only license. See [1] - Linux kernel licensing rules.
> >> >
> >> > One of the biggest benefits with SPDX identifier is that it is hard to verify
> >> > boiler plate licenses due to formatting, types, different formulations and so on.
> >> >
> >> > If still worrying, I think we could keep the license text as
> >> > well.
>
> I'm sorry for the confusion, I should have wrote "license text" rather
> than "copyright text" in my previous message. I agree with the benefits
No problem at all.
> of utilizing the SPDX identifier, and I see the addition of the SPDX
> line as useful, but I would prefer the original license text remain as
> well.
Of course, I will keep the the original license intact for v3.
>
> William Breathitt Gray
>
Best regards
Marcus Folkesson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-20 21:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 10:45 [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem Marcus Folkesson
2018-02-20 10:58 ` Måns Rullgård
2018-02-20 11:24 ` Thierry Reding
2018-02-20 11:25 ` Neil Armstrong
2018-02-20 12:49 ` William Breathitt Gray
2018-02-20 13:21 ` Marcus Folkesson
2018-02-20 15:13 ` Guenter Roeck
2018-02-20 15:33 ` Marcus Folkesson
2018-02-20 18:14 ` William Breathitt Gray
2018-02-20 18:45 ` Marcus Folkesson [this message]
2018-02-20 16:26 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220184522.GF24311@gmail.com \
--to=marcus.folkesson@gmail$(echo .)com \
--cc=adi-buildroot-devel@lists$(echo .)sourceforge.net \
--cc=alexandre.belloni@free-electrons$(echo .)com \
--cc=andreas.werner@men$(echo .)de \
--cc=baohua@kernel$(echo .)org \
--cc=baoyou.xie@linaro$(echo .)org \
--cc=baruch@tkos$(echo .)co.il \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=carlo@caione$(echo .)org \
--cc=eric@anholt$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jim.cromie@gmail$(echo .)com \
--cc=jimmy.vance@hpe$(echo .)com \
--cc=joel@jms$(echo .)id.au \
--cc=jonathanh@nvidia$(echo .)com \
--cc=jun.nie@linaro$(echo .)org \
--cc=keguang.zhang@gmail$(echo .)com \
--cc=kgene@kernel$(echo .)org \
--cc=khilman@baylibre$(echo .)com \
--cc=krzk@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linux-watchdog@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=manabian@gmail$(echo .)com \
--cc=mans@mansr$(echo .)com \
--cc=marc.w.gonzalez@free$(echo .)fr \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=maxime.ripard@bootlin$(echo .)com \
--cc=mcuos.com@gmail$(echo .)com \
--cc=michal.simek@xilinx$(echo .)com \
--cc=morbidrsa@gmail$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=nicolas.ferre@microchip$(echo .)com \
--cc=patches@opensource$(echo .)cirrus.com \
--cc=patrice.chotard@st$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=rjui@broadcom$(echo .)com \
--cc=sbranden@broadcom$(echo .)com \
--cc=shawnguo@kernel$(echo .)org \
--cc=slemieux.tyco@gmail$(echo .)com \
--cc=stefan.wahren@i2se$(echo .)com \
--cc=support.opensource@diasemi$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=tomas.winkler@intel$(echo .)com \
--cc=vilhelm.gray@gmail$(echo .)com \
--cc=vz@mleia$(echo .)com \
--cc=wens@csie$(echo .)org \
--cc=wim@linux-watchdog$(echo .)org \
--cc=yamada.masahiro@socionext$(echo .)com \
--cc=zwanem@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox