Subject: Re: [PATCH v1 1/1] misc: IBM Virtual Management Channel Driver

From: Greg KH <[email-masked]>
Date: Tue, 24 Apr 2018 16:29:18 +0200

On Mon, Apr 23, 2018 at 02:17:28PM -0700, Randy Dunlap wrote:
> On 04/23/18 12:53, Greg KH wrote:
> > On Mon, Apr 23, 2018 at 11:38:18AM -0700, Randy Dunlap wrote:
> >> On 04/23/18 07:46, Bryant G. Ly wrote:
> >>> This driver is a logical device which provides an
> >>> interface between the hypervisor and a management
> >>> partition.
> >>>
> >>> This driver is to be used for the POWER Virtual
> >>> Management Channel Virtual Adapter on the PowerVM
> >>> platform. It provides both request/response and
> >>> async message support through the /dev/ibmvmc node.
> >>>
> >>> Signed-off-by: Bryant G. Ly <[email-masked]>
> >>> Reviewed-by: Steven Royer <[email-masked]>
> >>> Reviewed-by: Adam Reznechek <[email-masked]>
> >>> Tested-by: Taylor Jakobson <[email-masked]>
> >>> Tested-by: Brad Warrum <[email-masked]>
> >>> Cc: Greg Kroah-Hartman <[email-masked]>
> >>> Cc: Arnd Bergmann <[email-masked]>
> >>> Cc: Benjamin Herrenschmidt <[email-masked]>
> >>> Cc: Michael Ellerman <[email-masked]>
> >>> ---
> >>>  Documentation/ioctl/ioctl-number.txt  |    1 +
> >>>  Documentation/misc-devices/ibmvmc.txt |  161 +++
> >>>  MAINTAINERS                           |    6 +
> >>>  arch/powerpc/include/asm/hvcall.h     |    1 +
> >>>  drivers/misc/Kconfig                  |   14 +
> >>>  drivers/misc/Makefile                 |    1 +
> >>>  drivers/misc/ibmvmc.c                 | 2415 +++++++++++++++++++++++++++++++++
> >>>  drivers/misc/ibmvmc.h                 |  209 +++
> >>>  8 files changed, 2808 insertions(+)
> >>>  create mode 100644 Documentation/misc-devices/ibmvmc.txt
> >>>  create mode 100644 drivers/misc/ibmvmc.c
> >>>  create mode 100644 drivers/misc/ibmvmc.h
> >>
> >>> diff --git a/Documentation/misc-devices/ibmvmc.txt b/Documentation/misc-devices/ibmvmc.txt
> >>> new file mode 100644
> >>> index 0000000..bae1064
> >>> --- /dev/null
> >>> +++ b/Documentation/misc-devices/ibmvmc.txt
> > 
> > Aren't we doing new documentation in .rst format instead of .txt?
> 
> I am not aware that .rst format is a *requirement* for new documentation.
> 
> ??

Why wouldn't you create new documentation in that format?  Just saves
the step of having to change it again in the future.

thanks,

greg k-h