Subject: Re: [PATCH v6 2/4] powerpc/64: enhance memcmp() with VMX instruction for long bytes comparision

From: Segher Boessenkool <[email-masked]>
Date: Mon, 28 May 2018 06:05:59 -0500

On Fri, May 25, 2018 at 12:07:34PM +0800, [email-masked] wrote:
> +	/* save and restore cr0 */
> +	mfocrf  r5,64
> +	EXIT_VMX_OPS
> +	mtocrf	64,r5
> +	b	.LcmpAB_lightweight

That's cr1, not cr0.  You can use mcrf instead, it is cheaper (esp. if
you have it in a non-volatile CR field before so you need only one, if any).

> +	vcmpequb.  v7,v9,v10
> +	bnl	cr6,.Ldiffoffset_vmx_diff_found

In other places you say  bf 24,...  Dunno which is more readable, but
please pick one?

Segher