From: Baoquan He <bhe@redhat•com>
To: Andy Shevchenko <andy.shevchenko@gmail•com>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger•kernel.org>,
"Andrew Morton" <akpm@linux-foundation•org>,
"Rob Herring" <robh+dt@kernel•org>,
"Dan Williams" <dan.j.williams@intel•com>,
"Nicolas Pitre" <nicolas.pitre@linaro•org>,
"Josh Triplett" <josh@joshtriplett•org>,
"kbuild test robot" <fengguang.wu@intel•com>,
"Borislav Petkov" <bp@suse•de>,
"Patrik Jakobsson" <patrik.r.jakobsson@gmail•com>,
"David Airlie" <airlied@linux•ie>,
"KY Srinivasan" <kys@microsoft•com>,
"Haiyang Zhang" <haiyangz@microsoft•com>,
"Stephen Hemminger" <sthemmin@microsoft•com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail•com>,
"Frank Rowand" <frowand.list@gmail•com>,
"Keith Busch" <keith.busch@intel•com>,
"Jon Derrick" <jonathan.derrick@intel•com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm•com>,
"Bjorn Helgaas" <bhelgaas@google•com>,
"Thomas Gleixner" <tglx@linutronix•de>,
brijesh.singh@amd•com, "Jérôme Glisse" <jglisse@redhat•com>,
"Tom Lendacky" <thomas.lendacky@amd•com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
baiyaowei@cmss•chinamobile.com, richard.weiyang@gmail•com,
devel@linuxdriverproject•org,
linux-input <linux-input@vger•kernel.org>,
linux-nvdimm@lists•01.org,
devicetree <devicetree@vger•kernel.org>,
linux-pci@vger•kernel.org,
"Eric Biederman" <ebiederm@xmission•com>,
"Vivek Goyal" <vgoyal@redhat•com>,
"Dave Young" <dyoung@redhat•com>,
"Yinghai Lu" <yinghai@kernel•org>,
kexec@lists•infradead.org, "Michal Simek" <monstr@monstr•eu>,
"David S. Miller" <davem@davemloft•net>,
"Chris Zankel" <chris@zankel•net>,
"Max Filippov" <jcmvbkbc@gmail•com>,
"Gustavo Padovan" <gustavo@padovan•org>,
"Maarten Lankhorst" <maarten.lankhorst@linux•intel.com>,
"Sean Paul" <seanpaul@chromium•org>,
linux-parisc@vger•kernel.org,
"open list:LINUX FOR POWERPC PA SEMI PWRFICIENT"
<linuxppc-dev@lists•ozlabs.org>,
"Benjamin Herrenschmidt" <benh@kernel•crashing.org>,
"Paul Mackerras" <paulus@samba•org>,
"Michael Ellerman" <mpe@ellerman•id.au>
Subject: Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
Date: Tue, 12 Jun 2018 17:38:12 +0800 [thread overview]
Message-ID: <20180612093812.GC1820@MiWiFi-R3L-srv> (raw)
In-Reply-To: <CAHp75Vd6v4+RTq-5uw_BJpT6=w2KGjTfU+rEst6+8igs2cyntw@mail.gmail.com>
On 06/12/18 at 11:29am, Andy Shevchenko wrote:
> On Tue, Jun 12, 2018 at 6:28 AM, Baoquan He <bhe@redhat•com> wrote:
> > reparent_resources() is duplicated in arch/microblaze/pci/pci-common.c
> > and arch/powerpc/kernel/pci-common.c, so move it to kernel/resource.c
> > so that it's shared. Later its code also need be updated using list_head
> > to replace singly linked list.
>
> While this is a good deduplication of the code, some requirements for
> public functions would be good to satisfy.
>
> > +/*
> > + * Reparent resource children of pr that conflict with res
> > + * under res, and make res replace those children.
> > + */
>
> kernel doc format, though...
>
> > +static int reparent_resources(struct resource *parent,
> > + struct resource *res)
>
> ...is it really public with static keyword?!
Thanks for looking into this. This is a code bug, I copied and changed,
but forgot merging the changing to local commit. And the error reported
by test robot in patch 2 was changed too locally, forgot merging it to
patch. Will repost to address this.
>
>
>
> > +{
>
> > + for (pp = &parent->child; (p = *pp) != NULL; pp = &p->sibling) {
> > + if (p->end < res->start)
> > + continue;
> > + if (res->end < p->start)
> > + break;
>
> > + if (p->start < res->start || p->end > res->end)
> > + return -1; /* not completely contained */
>
> Usually we are expecting real eeror codes.
Hmm, I just copied it from arch/powerpc/kernel/pci-common.c. The
function interface expects an integer returned value, not sure what a
real error codes look like, could you give more hints? Will change
accordingly.
>
> > + if (firstpp == NULL)
> > + firstpp = pp;
> > + }
>
> > + if (firstpp == NULL)
> > + return -1; /* didn't find any conflicting entries? */
>
> Ditto.
>
> > +}
> > +EXPORT_SYMBOL(reparent_resources);
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2018-06-12 9:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 3:28 [PATCH v5 0/4] resource: Use list_head to link sibling resource Baoquan He
2018-06-12 3:28 ` [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public Baoquan He
2018-06-12 3:34 ` Baoquan He
2018-06-12 3:55 ` kbuild test robot
2018-06-12 8:29 ` Andy Shevchenko
2018-06-12 9:38 ` Baoquan He [this message]
2018-06-12 14:20 ` Andy Shevchenko
2018-06-12 14:24 ` Andy Shevchenko
2018-07-03 14:55 ` Baoquan He
2018-07-03 20:57 ` Andy Shevchenko
2018-07-04 4:18 ` Baoquan He
2018-06-12 9:49 ` Baoquan He
2018-06-12 3:28 ` [PATCH v5 2/4] resource: Use list_head to link sibling resource Baoquan He
2018-06-12 4:37 ` kbuild test robot
2018-06-12 4:49 ` kbuild test robot
2018-06-12 3:28 ` [PATCH v5 3/4] resource: add walk_system_ram_res_rev() Baoquan He
2018-06-12 3:28 ` [PATCH v5 4/4] kexec_file: Load kernel at top of system RAM if required Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612093812.GC1820@MiWiFi-R3L-srv \
--to=bhe@redhat$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andy.shevchenko@gmail$(echo .)com \
--cc=baiyaowei@cmss$(echo .)chinamobile.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bhelgaas@google$(echo .)com \
--cc=bp@suse$(echo .)de \
--cc=brijesh.singh@amd$(echo .)com \
--cc=chris@zankel$(echo .)net \
--cc=dan.j.williams@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devel@linuxdriverproject$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=dyoung@redhat$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=fengguang.wu@intel$(echo .)com \
--cc=frowand.list@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=gustavo@padovan$(echo .)org \
--cc=haiyangz@microsoft$(echo .)com \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=jglisse@redhat$(echo .)com \
--cc=jonathan.derrick@intel$(echo .)com \
--cc=josh@joshtriplett$(echo .)org \
--cc=keith.busch@intel$(echo .)com \
--cc=kexec@lists$(echo .)infradead.org \
--cc=kys@microsoft$(echo .)com \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nvdimm@lists$(echo .)01.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=monstr@monstr$(echo .)eu \
--cc=mpe@ellerman$(echo .)id.au \
--cc=nicolas.pitre@linaro$(echo .)org \
--cc=patrik.r.jakobsson@gmail$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=richard.weiyang@gmail$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=seanpaul@chromium$(echo .)org \
--cc=sthemmin@microsoft$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=thomas.lendacky@amd$(echo .)com \
--cc=vgoyal@redhat$(echo .)com \
--cc=yinghai@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox