From: Gautham R Shenoy <ego@linux•vnet.ibm.com>
To: Akshay Adiga <akshay.adiga@linux•vnet.ibm.com>
Cc: linux-kernel@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-pm@vger•kernel.org, rjw@rjwysocki•net,
stewart@linux•vnet.ibm.com, benh@kernel•crashing.org,
svaidy@linux•vnet.ibm.com, ego@linux•vnet.ibm.com,
npiggin@gmail•com, mpe@ellerman•id.au
Subject: Re: [PATCH v3 2/2] powernv/cpuidle: Use parsed device tree values for cpuidle_init
Date: Tue, 3 Jul 2018 15:17:59 +0530 [thread overview]
Message-ID: <20180703094759.GB24693@in.ibm.com> (raw)
In-Reply-To: <1530609656-13301-3-git-send-email-akshay.adiga@linux.vnet.ibm.com>
Hi Akshay,
On Tue, Jul 03, 2018 at 02:50:56PM +0530, Akshay Adiga wrote:
> Export pnv_idle_states and nr_pnv_idle_states so that its accessible to
> cpuidle driver. Use properties from pnv_idle_states structure for powernv
> cpuidle_init.
>
> Signed-off-by: Akshay Adiga <akshay.adiga@linux•vnet.ibm.com>
> Reviewed-by: Nicholas Piggin <npiggin@gmail•com>
> ---
[..snip..]
>
> /*
> * For nap and fastsleep, use default target_residency
> * values if f/w does not expose it.
> */
This comment can also go, since we are no longer hard-coding the
residency values in the kernel.
Otherwise looks good to me.
Reviewed-by: Gautham R. Shenoy <ego@linux•vnet.ibm.com>
--
Thanks and Regards
gautham.
next prev parent reply other threads:[~2018-07-03 9:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 9:20 [PATCH v3 0/2] powernv/cpuidle Device-tree parsing cleanup Akshay Adiga
2018-07-03 9:20 ` [PATCH v3 1/2] powernv/cpuidle: Parse dt idle properties into global structure Akshay Adiga
2018-07-03 9:46 ` Gautham R Shenoy
2018-07-03 9:20 ` [PATCH v3 2/2] powernv/cpuidle: Use parsed device tree values for cpuidle_init Akshay Adiga
2018-07-03 9:47 ` Gautham R Shenoy [this message]
2018-07-04 10:54 ` [PATCH v3 0/2] powernv/cpuidle Device-tree parsing cleanup Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703094759.GB24693@in.ibm.com \
--to=ego@linux$(echo .)vnet.ibm.com \
--cc=akshay.adiga@linux$(echo .)vnet.ibm.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
--cc=rjw@rjwysocki$(echo .)net \
--cc=stewart@linux$(echo .)vnet.ibm.com \
--cc=svaidy@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox