Subject: Re: [PATCH v3 2/2] powernv/cpuidle: Use parsed device tree values for cpuidle_init

From: Gautham R Shenoy <[email-masked]>
Date: Tue, 3 Jul 2018 15:17:59 +0530

Hi Akshay,

On Tue, Jul 03, 2018 at 02:50:56PM +0530, Akshay Adiga wrote:
> Export pnv_idle_states and nr_pnv_idle_states so that its accessible to
> cpuidle driver. Use properties from pnv_idle_states structure for powernv
> cpuidle_init.
> 
> Signed-off-by: Akshay Adiga <[email-masked]>
> Reviewed-by: Nicholas Piggin <[email-masked]>
> ---

[..snip..]

> 
>  		/*
>  		 * For nap and fastsleep, use default target_residency
>  		 * values if f/w does not expose it.
>  		 */

This comment can also go, since we are no longer hard-coding the
residency values in the kernel.

Otherwise looks good to me.

Reviewed-by: Gautham R. Shenoy <[email-masked]>

--
Thanks and Regards
gautham.