From: Michal Hocko <mhocko@kernel•org>
To: Joonsoo Kim <js1304@gmail•com>
Cc: Marek Szyprowski <m.szyprowski@samsung•com>,
Linux Memory Management List <linux-mm@kvack•org>,
LKML <linux-kernel@vger•kernel.org>,
linux-arm-kernel@lists•infradead.org,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
iommu@lists•linux-foundation.org,
Andrew Morton <akpm@linux-foundation•org>,
Michal Nazarewicz <mina86@mina86•com>,
Joonsoo Kim <iamjoonsoo.kim@lge•com>,
Vlastimil Babka <vbabka@suse•cz>, Christoph Hellwig <hch@lst•de>,
Russell King <linux@armlinux•org.uk>,
Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will.deacon@arm•com>,
Paul Mackerras <paulus@ozlabs•org>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Chris Zankel <chris@zankel•net>,
Martin Schwidefsky <schwidefsky@de•ibm.com>,
Joerg Roedel <joro@8bytes•org>,
Sumit Semwal <sumit.semwal@linaro•org>,
Robin Murphy <robin.murphy@arm•com>,
Laura Abbott <labbott@redhat•com>,
linaro-mm-sig@lists•linaro.org
Subject: Re: [PATCH 1/2] mm/cma: remove unsupported gfp_mask parameter from cma_alloc()
Date: Tue, 10 Jul 2018 11:50:56 +0200 [thread overview]
Message-ID: <20180710095056.GE14284@dhcp22.suse.cz> (raw)
In-Reply-To: <CAAmzW4PPNYhUj_MeZox+ddq8MjXqnJs_AJ3xkayf710udD1pSg@mail.gmail.com>
On Tue 10-07-18 16:19:32, Joonsoo Kim wrote:
> Hello, Marek.
>
> 2018-07-09 21:19 GMT+09:00 Marek Szyprowski <m.szyprowski@samsung•com>:
> > cma_alloc() function doesn't really support gfp flags other than
> > __GFP_NOWARN, so convert gfp_mask parameter to boolean no_warn parameter.
>
> Although gfp_mask isn't used in cma_alloc() except no_warn, it can be used
> in alloc_contig_range(). For example, if passed gfp mask has no __GFP_FS,
> compaction(isolation) would work differently. Do you have considered
> such a case?
Does any of cma_alloc users actually care about GFP_NO{FS,IO}?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-07-10 9:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180709122019eucas1p2340da484acfcc932537e6014f4fd2c29@eucas1p2.samsung.com>
[not found] ` <20180709121956.20200-1-m.szyprowski@samsung.com>
2018-07-09 12:19 ` [PATCH 1/2] mm/cma: remove unsupported gfp_mask parameter from cma_alloc() Marek Szyprowski
2018-07-09 13:09 ` Michal Hocko
2018-07-09 17:27 ` Laura Abbott
2018-07-10 7:19 ` Joonsoo Kim
2018-07-10 9:50 ` Michal Hocko [this message]
2018-07-11 7:35 ` Joonsoo Kim
2018-07-11 8:54 ` Michal Hocko
2018-07-12 2:48 ` Joonsoo Kim
2018-07-12 7:15 ` Christoph Hellwig
2018-07-13 6:29 ` Joonsoo Kim
2018-07-16 7:45 ` Vlastimil Babka
2018-07-17 15:08 ` Christoph Hellwig
2018-07-09 12:19 ` [PATCH 2/2] dma: remove unsupported gfp_mask parameter from dma_alloc_from_contiguous() Marek Szyprowski
2018-07-16 7:45 ` Vlastimil Babka
2018-07-17 15:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710095056.GE14284@dhcp22.suse.cz \
--to=mhocko@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chris@zankel$(echo .)net \
--cc=hch@lst$(echo .)de \
--cc=iamjoonsoo.kim@lge$(echo .)com \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=joro@8bytes$(echo .)org \
--cc=js1304@gmail$(echo .)com \
--cc=labbott@redhat$(echo .)com \
--cc=linaro-mm-sig@lists$(echo .)linaro.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=mina86@mina86$(echo .)com \
--cc=paulus@ozlabs$(echo .)org \
--cc=robin.murphy@arm$(echo .)com \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sumit.semwal@linaro$(echo .)org \
--cc=vbabka@suse$(echo .)cz \
--cc=will.deacon@arm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox