From: Baoquan He <bhe@redhat•com>
To: linux-kernel@vger•kernel.org, akpm@linux-foundation•org,
robh+dt@kernel•org, dan.j.williams@intel•com,
nicolas.pitre@linaro•org, josh@joshtriplett•org,
fengguang.wu@intel•com, bp@suse•de, andy.shevchenko@gmail•com
Cc: patrik.r.jakobsson@gmail•com, airlied@linux•ie,
kys@microsoft•com, haiyangz@microsoft•com,
sthemmin@microsoft•com, dmitry.torokhov@gmail•com,
frowand.list@gmail•com, keith.busch@intel•com,
jonathan.derrick@intel•com, lorenzo.pieralisi@arm•com,
bhelgaas@google•com, tglx@linutronix•de, brijesh.singh@amd•com,
jglisse@redhat•com, thomas.lendacky@amd•com,
gregkh@linuxfoundation•org, baiyaowei@cmss•chinamobile.com,
richard.weiyang@gmail•com, devel@linuxdriverproject•org,
linux-input@vger•kernel.org, linux-nvdimm@lists•01.org,
devicetree@vger•kernel.org, linux-pci@vger•kernel.org,
ebiederm@xmission•com, vgoyal@redhat•com, dyoung@redhat•com,
yinghai@kernel•org, monstr@monstr•eu, davem@davemloft•net,
chris@zankel•net, jcmvbkbc@gmail•com, gustavo@padovan•org,
maarten.lankhorst@linux•intel.com, seanpaul@chromium•org,
linux-parisc@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
Baoquan He <bhe@redhat•com>
Subject: [PATCH v7 0/4] resource: Use list_head to link sibling resource
Date: Wed, 18 Jul 2018 10:49:40 +0800 [thread overview]
Message-ID: <20180718024944.577-1-bhe@redhat.com> (raw)
This patchset is doing:
1) Move reparent_resources() to kernel/resource.c to clean up duplicated
code in arch/microblaze/pci/pci-common.c and
arch/powerpc/kernel/pci-common.c .
2) Replace struct resource's sibling list from singly linked list to
list_head. Clearing out those pointer operation within singly linked
list for better code readability.
2) Based on list_head replacement, add a new function
walk_system_ram_res_rev() which can does reversed iteration on
iomem_resource's siblings.
3) Change kexec_file loading to search system RAM top down for kernel
loadin, using walk_system_ram_res_rev().
Note:
This patchset only passed testing on x86_64 arch with network
enabling. The thing we need pay attetion to is that a root resource's
child member need be initialized specifically with LIST_HEAD_INIT() if
statically defined or INIT_LIST_HEAD() for dynamically definition. Here
Just like we do for iomem_resource/ioport_resource, or the change in
get_pci_domain_busn_res().
v6:
http://lkml.kernel.org/r/20180704041038.8190-1-bhe@redhat.com
v5:
http://lkml.kernel.org/r/20180612032831.29747-1-bhe@redhat.com
v4:
http://lkml.kernel.org/r/20180507063224.24229-1-bhe@redhat.com
v3:
http://lkml.kernel.org/r/20180419001848.3041-1-bhe@redhat.com
v2:
http://lkml.kernel.org/r/20180408024724.16812-1-bhe@redhat.com
v1:
http://lkml.kernel.org/r/20180322033722.9279-1-bhe@redhat.com
Changelog:
v6->v7:
Fix code bugs that test robot reported on mips and ia64.
Add error code description in reparent_resources() according to
Andy's comment, and fix minor log typo.
v5->v6:
Fix code style problems in reparent_resources() and use existing
error codes, according to Andy's suggestion.
Fix bugs test robot reported.
v4->v5:
Add new patch 0001 to move duplicated reparent_resources() to
kernel/resource.c to make it be shared by different ARCH-es.
Fix several code bugs reported by test robot on ARCH powerpc and
microblaze.
v3->v4:
Fix several bugs test robot reported. Rewrite cover letter and patch
log according to reviewer's comment.
v2->v3:
Rename resource functions first_child() and sibling() to
resource_first_chils() and resource_sibling(). Dan suggested this.
Move resource_first_chils() and resource_sibling() to linux/ioport.h
and make them as inline function. Rob suggested this. Accordingly add
linux/list.h including in linux/ioport.h, please help review if this
bring efficiency degradation or code redundancy.
The change on struct resource {} bring two pointers of size increase,
mention this in git log to make it more specifically, Rob suggested
this.
v1->v2:
Use list_head instead to link resource siblings. This is suggested by
Andrew.
Rewrite walk_system_ram_res_rev() after list_head is taken to link
resouce siblings.
Baoquan He (4):
resource: Move reparent_resources() to kernel/resource.c and make it
public
resource: Use list_head to link sibling resource
resource: add walk_system_ram_res_rev()
kexec_file: Load kernel at top of system RAM if required
arch/arm/plat-samsung/pm-check.c | 6 +-
arch/ia64/sn/kernel/io_init.c | 2 +-
arch/microblaze/pci/pci-common.c | 41 +----
arch/mips/pci/pci-rc32434.c | 12 +-
arch/powerpc/kernel/pci-common.c | 39 +---
arch/sparc/kernel/ioport.c | 2 +-
arch/xtensa/include/asm/pci-bridge.h | 4 +-
drivers/eisa/eisa-bus.c | 2 +
drivers/gpu/drm/drm_memory.c | 3 +-
drivers/gpu/drm/gma500/gtt.c | 5 +-
drivers/hv/vmbus_drv.c | 52 +++---
drivers/input/joystick/iforce/iforce-main.c | 4 +-
drivers/nvdimm/namespace_devs.c | 6 +-
drivers/nvdimm/nd.h | 5 +-
drivers/of/address.c | 4 +-
drivers/parisc/lba_pci.c | 4 +-
drivers/pci/controller/vmd.c | 8 +-
drivers/pci/probe.c | 2 +
drivers/pci/setup-bus.c | 2 +-
include/linux/ioport.h | 21 ++-
kernel/kexec_file.c | 2 +
kernel/resource.c | 266 ++++++++++++++++++----------
22 files changed, 260 insertions(+), 232 deletions(-)
--
2.13.6
next reply other threads:[~2018-07-18 2:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 2:49 Baoquan He [this message]
2018-07-18 2:49 ` [PATCH v7 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public Baoquan He
2018-07-18 16:36 ` Andy Shevchenko
2018-07-18 16:37 ` Andy Shevchenko
2018-07-19 15:18 ` Baoquan He
2018-07-18 2:49 ` [PATCH v7 2/4] resource: Use list_head to link sibling resource Baoquan He
2018-07-18 2:49 ` [PATCH v7 3/4] resource: add walk_system_ram_res_rev() Baoquan He
2018-07-18 2:49 ` [PATCH v7 4/4] kexec_file: Load kernel at top of system RAM if required Baoquan He
2018-07-18 22:33 ` Andrew Morton
2018-07-19 15:17 ` Baoquan He
2018-07-19 19:44 ` Andrew Morton
2018-07-25 2:21 ` Baoquan He
2018-07-23 14:34 ` Michal Hocko
2018-07-25 6:48 ` Baoquan He
2018-07-26 12:59 ` Michal Hocko
2018-07-26 13:09 ` Baoquan He
2018-07-26 13:12 ` Michal Hocko
2018-07-26 13:14 ` Michal Hocko
2018-07-26 13:37 ` Baoquan He
2018-07-26 14:01 ` Michal Hocko
2018-07-26 15:10 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718024944.577-1-bhe@redhat.com \
--to=bhe@redhat$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andy.shevchenko@gmail$(echo .)com \
--cc=baiyaowei@cmss$(echo .)chinamobile.com \
--cc=bhelgaas@google$(echo .)com \
--cc=bp@suse$(echo .)de \
--cc=brijesh.singh@amd$(echo .)com \
--cc=chris@zankel$(echo .)net \
--cc=dan.j.williams@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devel@linuxdriverproject$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=dyoung@redhat$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=fengguang.wu@intel$(echo .)com \
--cc=frowand.list@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=gustavo@padovan$(echo .)org \
--cc=haiyangz@microsoft$(echo .)com \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=jglisse@redhat$(echo .)com \
--cc=jonathan.derrick@intel$(echo .)com \
--cc=josh@joshtriplett$(echo .)org \
--cc=keith.busch@intel$(echo .)com \
--cc=kys@microsoft$(echo .)com \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nvdimm@lists$(echo .)01.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=monstr@monstr$(echo .)eu \
--cc=nicolas.pitre@linaro$(echo .)org \
--cc=patrik.r.jakobsson@gmail$(echo .)com \
--cc=richard.weiyang@gmail$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=seanpaul@chromium$(echo .)org \
--cc=sthemmin@microsoft$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=thomas.lendacky@amd$(echo .)com \
--cc=vgoyal@redhat$(echo .)com \
--cc=yinghai@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox