From: Murilo Opsfelder Araujo <muriloo@linux•ibm.com>
To: linux-kernel@vger•kernel.org
Cc: "Alastair D'Silva" <alastair@d-silva•org>,
Andrew Donnellan <andrew.donnellan@au1•ibm.com>,
Balbir Singh <bsingharora@gmail•com>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Christophe Leroy <christophe.leroy@c-s•fr>,
Cyril Bur <cyrilbur@gmail•com>,
"Eric W . Biederman" <ebiederm@xmission•com>,
Joe Perches <joe@perches•com>,
Michael Ellerman <mpe@ellerman•id.au>,
Michael Neuling <mikey@neuling•org>,
Murilo Opsfelder Araujo <muriloo@linux•ibm.com>,
Nicholas Piggin <npiggin@gmail•com>,
Paul Mackerras <paulus@samba•org>,
Simon Guo <wei.guo.simon@gmail•com>,
Sukadev Bhattiprolu <sukadev@linux•vnet.ibm.com>,
"Tobin C . Harding" <me@tobin•cc>,
linuxppc-dev@lists•ozlabs.org
Subject: [PATCH v3 6/9] powerpc: Do not call __kernel_text_address() in show_instructions()
Date: Tue, 31 Jul 2018 11:50:17 -0300 [thread overview]
Message-ID: <20180731145020.14009-7-muriloo@linux.ibm.com> (raw)
In-Reply-To: <20180731145020.14009-1-muriloo@linux.ibm.com>
Modify show_instructions() not to call __kernel_text_address(), allowing
userspace instruction dump. probe_kernel_address(), which returns -EFAULT
if something goes wrong, is still being called.
Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux•ibm.com>
---
arch/powerpc/kernel/process.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index e9533b4d2f08..50094c44bf79 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -1283,8 +1283,7 @@ static void show_instructions(struct pt_regs *regs)
pc = (unsigned long)phys_to_virt(pc);
#endif
- if (!__kernel_text_address(pc) ||
- probe_kernel_address((unsigned int __user *)pc, instr)) {
+ if (probe_kernel_address((unsigned int __user *)pc, instr)) {
pr_cont("XXXXXXXX ");
} else {
if (regs->nip == pc)
--
2.17.1
next prev parent reply other threads:[~2018-07-31 14:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 14:50 [PATCH v3 0/9] powerpc: Modernize unhandled signals message Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 1/9] powerpc/traps: Print unhandled signals in a separate function Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 2/9] powerpc/traps: Return early in show_signal_msg() Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 3/9] powerpc/traps: Use %lx format " Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 4/9] powerpc/traps: Print VMA for unhandled signals Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 5/9] powerpc/traps: Print signal name " Murilo Opsfelder Araujo
2018-08-01 6:37 ` Christophe LEROY
2018-08-01 7:03 ` Joe Perches
2018-08-01 7:49 ` Segher Boessenkool
2018-08-01 14:44 ` Murilo Opsfelder Araujo
2018-08-01 14:42 ` Murilo Opsfelder Araujo
2018-07-31 14:50 ` Murilo Opsfelder Araujo [this message]
2018-07-31 14:50 ` [PATCH v3 7/9] powerpc: Add stacktrace.h header Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 8/9] powerpc/traps: Show instructions on exceptions Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 9/9] powerpc/traps: Add line prefix in show_instructions() Murilo Opsfelder Araujo
2018-08-01 6:41 ` Christophe LEROY
2018-08-01 14:14 ` Michael Ellerman
2018-08-01 15:03 ` Murilo Opsfelder Araujo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731145020.14009-7-muriloo@linux.ibm.com \
--to=muriloo@linux$(echo .)ibm.com \
--cc=alastair@d-silva$(echo .)org \
--cc=andrew.donnellan@au1$(echo .)ibm.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bsingharora@gmail$(echo .)com \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=cyrilbur@gmail$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=me@tobin$(echo .)cc \
--cc=mikey@neuling$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=sukadev@linux$(echo .)vnet.ibm.com \
--cc=wei.guo.simon@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox