From: Nicholas Piggin <npiggin@gmail•com>
To: linuxppc-dev@lists•ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail•com>,
Akshay Adiga <akshay.adiga@linux•vnet.ibm.com>,
"Gautham R . Shenoy" <ego@linux•vnet.ibm.com>
Subject: [PATCH] powernv/cpuidle: Fix idle states all being marked invalid
Date: Fri, 3 Aug 2018 01:39:51 +1000 [thread overview]
Message-ID: <20180802153951.3576-1-npiggin@gmail.com> (raw)
Commit 9c7b185ab2 ("powernv/cpuidle: Parse dt idle properties into
global structure") parses dt idle states into structs, but never
marks them valid. This results in all idle states being lost.
Cc: Akshay Adiga <akshay.adiga@linux•vnet.ibm.com>
Cc: Gautham R. Shenoy <ego@linux•vnet.ibm.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail•com>
---
arch/powerpc/platforms/powernv/idle.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/idle.c b/arch/powerpc/platforms/powernv/idle.c
index 3116bab10aa3..ecb002c5db83 100644
--- a/arch/powerpc/platforms/powernv/idle.c
+++ b/arch/powerpc/platforms/powernv/idle.c
@@ -651,11 +651,12 @@ static int __init pnv_power9_idle_init(void)
&state->psscr_mask,
state->flags);
if (err) {
- state->valid = false;
report_invalid_psscr_val(state->psscr_val, err);
continue;
}
+ state->valid = true;
+
if (max_residency_ns < state->residency_ns) {
max_residency_ns = state->residency_ns;
pnv_deepest_stop_psscr_val = state->psscr_val;
--
2.17.0
next reply other threads:[~2018-08-02 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 15:39 Nicholas Piggin [this message]
2018-08-03 6:14 ` [PATCH] powernv/cpuidle: Fix idle states all being marked invalid Akshay Adiga
2018-08-03 10:48 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802153951.3576-1-npiggin@gmail.com \
--to=npiggin@gmail$(echo .)com \
--cc=akshay.adiga@linux$(echo .)vnet.ibm.com \
--cc=ego@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox