From: Gautham R Shenoy <ego@linux•vnet.ibm.com>
To: Srikar Dronamraju <srikar@linux•vnet.ibm.com>
Cc: "Gautham R. Shenoy" <ego@linux•vnet.ibm.com>,
Michael Ellerman <mpe@ellerman•id.au>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Michael Neuling <mikey@neuling•org>,
Vaidyanathan Srinivasan <svaidy@linux•vnet.ibm.com>,
Akshay Adiga <akshay.adiga@linux•vnet.ibm.com>,
Shilpasri G Bhat <shilpa.bhat@linux•vnet.ibm.com>,
"Oliver O'Halloran" <oohall@gmail•com>,
Nicholas Piggin <npiggin@gmail•com>,
Murilo Opsfelder Araujo <muriloo@linux•ibm.com>,
Anton Blanchard <anton@samba•org>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH v6 2/2] powerpc: Use cpu_smallcore_sibling_mask at SMT level on bigcores
Date: Mon, 13 Aug 2018 17:37:32 +0530 [thread overview]
Message-ID: <20180813120732.GA13369@in.ibm.com> (raw)
In-Reply-To: <20180809132657.GA42474@linux.vnet.ibm.com>
On Thu, Aug 09, 2018 at 06:26:57AM -0700, Srikar Dronamraju wrote:
> * Gautham R. Shenoy <ego@linux•vnet.ibm.com> [2018-08-09 11:02:08]:
>
> >
> > 3) ppc64_cpu --smt=2
> > SMT domain ceases to exist as each domain consists of just one
> > group.
> >
>
> When seen in isolation, the above looks as if ppc64_cpu --smt=2 o/p says
> " SMT domain ceases to exist...."
Ok. The intent was to say that one of the sched-domain level
collapses, thereby leaving only CACHE, DIE and NUMA. Will word it
better.
>
> > @@ -999,7 +1012,17 @@ static void add_cpu_to_masks(int cpu)
> > {
> > int first_thread = cpu_first_thread_sibling(cpu);
> > int chipid = cpu_to_chip_id(cpu);
> > - int i;
> > +
> > + struct thread_groups tg;
> > + int i, cpu_group_start = -1;
> > +
> > + if (has_big_cores) {
> > + struct device_node *dn = of_get_cpu_node(cpu, NULL);
> > +
>
> Not checking for validity of dn and no of_node_puts?
Will fix this. Thanks for catching this.
>
> > + parse_thread_groups(dn, &tg);
> > + cpu_group_start = get_cpu_thread_group_start(cpu, &tg);
> > + cpumask_set_cpu(cpu, cpu_smallcore_sibling_mask(cpu));
> > + }
> >
> > /*
> > * This CPU will not be in the online mask yet so we need to manually
>
> The rest looks good
Thanks for the review.
>
prev parent reply other threads:[~2018-08-13 12:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 5:32 [PATCH v6 0/2] powerpc: Detection and scheduler optimization for POWER9 bigcore Gautham R. Shenoy
2018-08-09 5:32 ` [PATCH v6 1/2] powerpc: Detect the presence of big-cores via "ibm, thread-groups" Gautham R. Shenoy
2018-08-09 13:27 ` [PATCH v6 1/2] powerpc: Detect the presence of big-cores via "ibm,thread-groups" Srikar Dronamraju
2018-08-13 6:43 ` Christoph Hellwig
2018-08-13 11:36 ` Gautham R Shenoy
2018-08-13 13:51 ` Benjamin Herrenschmidt
2018-08-09 5:32 ` [PATCH v6 2/2] powerpc: Use cpu_smallcore_sibling_mask at SMT level on bigcores Gautham R. Shenoy
2018-08-09 13:26 ` Srikar Dronamraju
2018-08-13 12:07 ` Gautham R Shenoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813120732.GA13369@in.ibm.com \
--to=ego@linux$(echo .)vnet.ibm.com \
--cc=akshay.adiga@linux$(echo .)vnet.ibm.com \
--cc=anton@samba$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=muriloo@linux$(echo .)ibm.com \
--cc=npiggin@gmail$(echo .)com \
--cc=oohall@gmail$(echo .)com \
--cc=shilpa.bhat@linux$(echo .)vnet.ibm.com \
--cc=srikar@linux$(echo .)vnet.ibm.com \
--cc=svaidy@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox