Subject: Re: [PATCH] powerpc64/ftrace: Include ftrace.h needed for enable/disable calls

From: Luke Dashjr <[email-masked]>
Date: Fri, 17 Aug 2018 15:16:33 +0000

On Friday 17 August 2018 10:25:40 Naveen N. Rao wrote:
> Luke Dashjr wrote:
> > this_cpu_disable_ftrace and this_cpu_enable_ftrace are inlines in
> > ftrace.h Without it included, the build fails.
>
> I'm unable to reproduce this. Can you share your .config and the build
> environment?

https://luke.dashjr.org/tmp/code/4.18-config.xz

Gentoo GNU/Linux (mostly stable keywords) on a Raptor Talos II POWER9 system.

> > Fixes: a4bc64d305af ("powerpc64/ftrace: Disable ftrace during kvm
> > entry/exit") Signed-off-by: Luke Dashjr <[email-masked]>
> > Cc: [email-masked]
> > ---
> >  arch/powerpc/kvm/book3s_hv.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
> > index ee4a8854985e..15c2c64291f4 100644
> > --- a/arch/powerpc/kvm/book3s_hv.c
> > +++ b/arch/powerpc/kvm/book3s_hv.c
> > @@ -46,6 +46,7 @@
> >  #include <linux/compiler.h>
> >  #include <linux/of.h>
> >
> > +#include <asm/ftrace.h>
> >  #include <asm/reg.h>
> >  #include <asm/ppc-opcode.h>
> >  #include <asm/asm-prototypes.h>
>
> In any case, this change itself looks alright to me. So:
> Acked-by: Naveen N. Rao <[email-masked]>
>
>
> Thanks,
> Naveen