From: Peter Zijlstra <peterz@infradead•org>
To: Srikar Dronamraju <srikar@linux•vnet.ibm.com>
Cc: Ingo Molnar <mingo@kernel•org>,
LKML <linux-kernel@vger•kernel.org>,
Mel Gorman <mgorman@techsingularity•net>,
Rik van Riel <riel@surriel•com>,
Thomas Gleixner <tglx@linutronix•de>,
Michael Ellerman <mpe@ellerman•id.au>,
Heiko Carstens <heiko.carstens@de•ibm.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd•com>,
Andre Wild <wild@linux•vnet.ibm.com>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH 1/2] sched/topology: Set correct numa topology type
Date: Tue, 21 Aug 2018 15:59:49 +0200 [thread overview]
Message-ID: <20180821135949.GI24082@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180821110258.GA2080@linux.vnet.ibm.com>
On Tue, Aug 21, 2018 at 04:02:58AM -0700, Srikar Dronamraju wrote:
> * Srikar Dronamraju <srikar@linux•vnet.ibm.com> [2018-08-10 22:30:18]:
>
> > With commit 051f3ca02e46 ("sched/topology: Introduce NUMA identity node
> > sched domain") scheduler introduces an new numa level. However this
> > leads to numa topology on 2 node systems no more marked as NUMA_DIRECT.
> > After this commit, it gets reported as NUMA_BACKPLANE. This is because
> > sched_domains_numa_level is now 2 on 2 node systems.
> >
> > Fix this by allowing setting systems that have upto 2 numa levels as
> > NUMA_DIRECT.
> >
> > While here remove a code that assumes level can be 0.
> >
> > Fixes: 051f3ca02e46 "Introduce NUMA identity node sched domain"
> > Signed-off-by: Srikar Dronamraju <srikar@linux•vnet.ibm.com>
> > ---
>
> Hey Peter,
>
> Did you look at these two patches?
Nope, been on holidays and the inbox is an even bigger mess than normal.
I'll get to it, eventually :/
next prev parent reply other threads:[~2018-08-21 14:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <reply-to=<20180808081942.GA37418@linux.vnet.ibm.com>
2018-08-10 17:00 ` [PATCH 1/2] sched/topology: Set correct numa topology type Srikar Dronamraju
2018-08-10 17:00 ` [PATCH 2/2] sched/topology: Expose numa_mask set/clear functions to arch Srikar Dronamraju
2018-08-29 8:02 ` Peter Zijlstra
2018-08-31 10:27 ` Srikar Dronamraju
2018-08-31 11:12 ` Peter Zijlstra
2018-08-31 11:26 ` Peter Zijlstra
2018-08-31 11:53 ` Srikar Dronamraju
2018-08-31 12:05 ` Peter Zijlstra
2018-08-31 12:08 ` Peter Zijlstra
2018-08-21 11:02 ` [PATCH 1/2] sched/topology: Set correct numa topology type Srikar Dronamraju
2018-08-21 13:59 ` Peter Zijlstra [this message]
2018-09-10 10:06 ` [tip:sched/core] sched/topology: Set correct NUMA " tip-bot for Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821135949.GI24082@hirez.programming.kicks-ass.net \
--to=peterz@infradead$(echo .)org \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mgorman@techsingularity$(echo .)net \
--cc=mingo@kernel$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=riel@surriel$(echo .)com \
--cc=srikar@linux$(echo .)vnet.ibm.com \
--cc=suravee.suthikulpanit@amd$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=wild@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox