From: Peter Zijlstra <peterz@infradead•org>
To: Srikar Dronamraju <srikar@linux•vnet.ibm.com>
Cc: Ingo Molnar <mingo@kernel•org>,
LKML <linux-kernel@vger•kernel.org>,
Mel Gorman <mgorman@techsingularity•net>,
Rik van Riel <riel@surriel•com>,
Thomas Gleixner <tglx@linutronix•de>,
Michael Ellerman <mpe@ellerman•id.au>,
Heiko Carstens <heiko.carstens@de•ibm.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd•com>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
Andre Wild <wild@linux•vnet.ibm.com>
Subject: Re: [PATCH] sched/topology: Use Identity node only if required
Date: Wed, 29 Aug 2018 10:57:38 +0200 [thread overview]
Message-ID: <20180829085738.GS24142@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180829084348.GO24124@hirez.programming.kicks-ass.net>
On Wed, Aug 29, 2018 at 10:43:48AM +0200, Peter Zijlstra wrote:
> DIE(j) should be:
>
> cpu_cpu_mask(j) := cpumask_of_node(cpu_to_node(j))
FWIW, I was expecting that to be topology_core_cpumask(), so I'm a
little confused myself just now.
> and NODE(j) should be:
>
> \Union_k cpumask_of_node(k) ; where node_distance(j,k) <= node_distance(0,0)
>
> which, _should_ reduce to:
>
> cpumask_of_node(j)
>
> and thus DIE and NODE _should_ be the same here.
>
> So what's going sideways?
next prev parent reply other threads:[~2018-08-29 8:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1533712172-11428-1-git-send-email-srikar@linux.vnet.ibm.com>
[not found] ` <20180808075840.GO2494@hirez.programming.kicks-ass.net>
2018-08-10 16:45 ` [PATCH] sched/topology: Use Identity node only if required Srikar Dronamraju
2018-08-29 8:43 ` Peter Zijlstra
2018-08-29 8:57 ` Peter Zijlstra [this message]
2018-08-31 10:22 ` Srikar Dronamraju
2018-08-31 10:41 ` Peter Zijlstra
2018-08-31 11:26 ` Srikar Dronamraju
2018-08-31 12:06 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829085738.GS24142@hirez.programming.kicks-ass.net \
--to=peterz@infradead$(echo .)org \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mgorman@techsingularity$(echo .)net \
--cc=mingo@kernel$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=riel@surriel$(echo .)com \
--cc=srikar@linux$(echo .)vnet.ibm.com \
--cc=suravee.suthikulpanit@amd$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=wild@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox