From: Jonathan Cameron <jonathan.cameron@huawei•com>
To: Arnd Bergmann <arnd@arndb•de>
Cc: <viro@zeniv•linux.org.uk>, <linux-fsdevel@vger•kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"David S. Miller" <davem@davemloft•net>,
<devel@driverdev•osuosl.org>, <linux-kernel@vger•kernel.org>,
<qat-linux@intel•com>, <linux-crypto@vger•kernel.org>,
<linux-media@vger•kernel.org>, <dri-devel@lists•freedesktop.org>,
<linaro-mm-sig@lists•linaro.org>, <amd-gfx@lists•freedesktop.org>,
<linux-input@vger•kernel.org>, <linux-iio@vger•kernel.org>,
<linux-rdma@vger•kernel.org>, <linux-nvdimm@lists•01.org>,
<linux-nvme@lists•infradead.org>, <linux-pci@vger•kernel.org>,
<platform-driver-x86@vger•kernel.org>,
<linux-remoteproc@vger•kernel.org>, <sparclinux@vger•kernel.org>,
<linux-scsi@vger•kernel.org>, <linux-usb@vger•kernel.org>,
<linux-fbdev@vger•kernel.org>, <linuxppc-dev@lists•ozlabs.org>,
<linux-btrfs@vger•kernel.org>, <ceph-devel@vger•kernel.org>,
<linux-wireless@vger•kernel.org>, <netdev@vger•kernel.org>
Subject: Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg
Date: Mon, 17 Sep 2018 10:33:48 +0100 [thread overview]
Message-ID: <20180917103348.00003f31@huawei.com> (raw)
In-Reply-To: <20180912151134.436719-1-arnd@arndb.de>
On Wed, 12 Sep 2018 17:08:52 +0200
Arnd Bergmann <arnd@arndb•de> wrote:
> The .ioctl and .compat_ioctl file operations have the same prototype so
> they can both point to the same function, which works great almost all
> the time when all the commands are compatible.
>
> One exception is the s390 architecture, where a compat pointer is only
> 31 bit wide, and converting it into a 64-bit pointer requires calling
> compat_ptr(). Most drivers here will ever run in s390, but since we now
> have a generic helper for it, it's easy enough to use it consistently.
>
> I double-checked all these drivers to ensure that all ioctl arguments
> are used as pointers or are ignored, but are not interpreted as integer
> values.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
> ---
For IIO part.
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei•com>
Thanks,
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index a062cfddc5af..22844b94b0e9 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -1630,7 +1630,7 @@ static const struct file_operations iio_buffer_fileops = {
> .owner = THIS_MODULE,
> .llseek = noop_llseek,
> .unlocked_ioctl = iio_ioctl,
> - .compat_ioctl = iio_ioctl,
> + .compat_ioctl = generic_compat_ioctl_ptrarg,
> };
>
next prev parent reply other threads:[~2018-09-17 9:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180912150142.157913-1-arnd@arndb.de>
2018-09-12 15:01 ` [PATCH v2 03/17] compat_ioctl: use correct compat_ptr() translation in drivers Arnd Bergmann
2018-09-12 18:13 ` Greg Kroah-Hartman
2018-09-13 0:48 ` Andrew Donnellan
2018-09-13 11:03 ` Felipe Balbi
2018-09-12 15:08 ` [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg Arnd Bergmann
2018-09-12 15:56 ` Jason Gunthorpe
2018-09-12 15:58 ` Daniel Vetter
2018-09-12 16:01 ` Mauro Carvalho Chehab
2018-09-12 18:13 ` Greg Kroah-Hartman
2018-09-14 14:23 ` David Sterba
2018-09-14 20:35 ` Darren Hart
2018-09-14 20:57 ` Al Viro
2018-09-18 17:51 ` Darren Hart
2018-09-18 17:59 ` Jason Gunthorpe
2018-09-24 20:18 ` Arnd Bergmann
2018-09-24 20:35 ` Jason Gunthorpe
2018-09-24 21:17 ` Arnd Bergmann
2018-09-17 9:33 ` Jonathan Cameron [this message]
2018-10-06 7:05 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917103348.00003f31@huawei.com \
--to=jonathan.cameron@huawei$(echo .)com \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=arnd@arndb$(echo .)de \
--cc=ceph-devel@vger$(echo .)kernel.org \
--cc=davem@davemloft$(echo .)net \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linaro-mm-sig@lists$(echo .)linaro.org \
--cc=linux-btrfs@vger$(echo .)kernel.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-fbdev@vger$(echo .)kernel.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-nvdimm@lists$(echo .)01.org \
--cc=linux-nvme@lists$(echo .)infradead.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-remoteproc@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=platform-driver-x86@vger$(echo .)kernel.org \
--cc=qat-linux@intel$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox