From: Segher Boessenkool <segher@kernel•crashing.org>
To: Bin Meng <bmeng.cn@gmail•com>
Cc: linuxppc-dev <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH 1/2] powerpc/64: Remove duplicated -mabi=elfv2 for little endian targets
Date: Mon, 1 Oct 2018 03:59:15 -0500 [thread overview]
Message-ID: <20181001085915.GC23155@gate.crashing.org> (raw)
In-Reply-To: <1538288720-14910-1-git-send-email-bmeng.cn@gmail.com>
On Sat, Sep 29, 2018 at 11:25:19PM -0700, Bin Meng wrote:
> The -mabi=elfv2 is currently specified twice in the makefile. Remove
> the one that does not test compiler.
This was
ifdef CONFIG_PPC64
cflags-$(CONFIG_CPU_BIG_ENDIAN) += $(call cc-option,-mabi=elfv1)
cflags-$(CONFIG_CPU_BIG_ENDIAN) += $(call cc-option,-mcall-aixdesc)
aflags-$(CONFIG_CPU_BIG_ENDIAN) += $(call cc-option,-mabi=elfv1)
aflags-$(CONFIG_CPU_LITTLE_ENDIAN) += -mabi=elfv2
endif
and the later setting is
ifeq ($(CONFIG_CPU_LITTLE_ENDIAN),y)
CFLAGS-$(CONFIG_PPC64) += $(call cc-option,-mabi=elfv2,$(call cc-option,-mcall-aixdesc))
AFLAGS-$(CONFIG_PPC64) += $(call cc-option,-mabi=elfv2)
else
CFLAGS-$(CONFIG_PPC64) += $(call cc-option,-mabi=elfv1)
CFLAGS-$(CONFIG_PPC64) += $(call cc-option,-mcall-aixdesc)
AFLAGS-$(CONFIG_PPC64) += $(call cc-option,-mabi=elfv1)
endif
Maybe these two pieces should be joined completely?
Segher
next prev parent reply other threads:[~2018-10-01 9:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-30 6:25 [PATCH 1/2] powerpc/64: Remove duplicated -mabi=elfv2 for little endian targets Bin Meng
2018-09-30 6:25 ` [PATCH 2/2] powerpc/64: Increase stack redzone for 64-bit kernel to 512 bytes Bin Meng
2018-09-30 23:27 ` Nicholas Piggin
2018-10-01 1:11 ` Bin Meng
2018-10-01 2:22 ` Nicholas Piggin
2018-10-01 8:51 ` Segher Boessenkool
2018-10-01 23:59 ` Nicholas Piggin
2018-10-02 8:30 ` Segher Boessenkool
2018-10-01 12:41 ` Bin Meng
2018-10-02 0:03 ` Nicholas Piggin
2018-10-01 9:07 ` Segher Boessenkool
2018-10-01 8:59 ` Segher Boessenkool [this message]
2018-10-01 12:19 ` [PATCH 1/2] powerpc/64: Remove duplicated -mabi=elfv2 for little endian targets Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001085915.GC23155@gate.crashing.org \
--to=segher@kernel$(echo .)crashing.org \
--cc=bmeng.cn@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox