From: Anton Blanchard <anton@ozlabs•org>
To: Nicholas Piggin <npiggin@gmail•com>
Cc: mikey@neuling•org, paulus@samba•org, oohall@gmail•com,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 2/2] powerpc/time: Only cap decrementer when watchdog is enabled
Date: Tue, 2 Oct 2018 08:57:51 +1000 [thread overview]
Message-ID: <20181002085751.0dc17ff2@kryten> (raw)
In-Reply-To: <20180929151618.1e15ca4c@roar.ozlabs.ibm.com>
Hi Nick,
> Thanks for tracking this down. It's a fix for my breakage
>
> a7cba02deced ("powerpc: allow soft-NMI watchdog to cover timer
> interrupts with large decrementers")
>
> Taking another look... what I had expected here is the timer subsystem
> would have stopped the decrementer device after it processed the timer
> and found nothing left. And we should have set DEC to max at that
> time.
>
> The above patch was really intended to only cover the timer interrupt
> itself locking up. I wonder if we need to add
>
> .set_state_oneshot_stopped = decrementer_shutdown
>
> In our decremementer clockevent device?
Thanks Nick, that looks much nicer, and passes my tests.
Anton
prev parent reply other threads:[~2018-10-01 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 1:26 [PATCH 1/2] powerpc/time: Use clockevents_register_device(), fixing an issue with large decrementer Anton Blanchard
2018-09-29 1:26 ` [PATCH 2/2] powerpc/time: Only cap decrementer when watchdog is enabled Anton Blanchard
2018-09-29 4:11 ` kbuild test robot
2018-09-29 5:16 ` Nicholas Piggin
2018-10-01 22:57 ` Anton Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002085751.0dc17ff2@kryten \
--to=anton@ozlabs$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
--cc=npiggin@gmail$(echo .)com \
--cc=oohall@gmail$(echo .)com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox